Sign upLogin

rugk/threema-msgapi-sdk-php

View on GitHub
Star

Showing 299 of 299 total issues

Avoid assigning values to variables in if clauses and the like (line '204', column '7').
Open

    private function createDefaultOptions(\Closure $progress = null) {
        $options = array(
            CURLOPT_RETURNTRANSFER => true
        );
Severity: Minor
Found in source/Threema/MsgApi/Connection.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method call uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return $response;
        }
Severity: Minor
Found in source/Threema/MsgApi/Connection.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$isMsgApiKeystore'.
Open

        $isMsgApiKeystore = true;
Severity: Minor
Found in source/Threema/MsgApi/PublicKeyStores/PhpFile.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$prefix'.
Open

        $this->doTest(function(CryptTool $cryptTool, $prefix) use($threemaIconContent) {
Severity: Minor
Found in source/Threema/MsgApi/Tests/CryptToolTest.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Threema\MsgApi\Tools\CryptTool' in method 'doTest'.
Open

                    'Salt' => CryptTool::createInstance(CryptTool::TYPE_SALT),
Severity: Minor
Found in source/Threema/MsgApi/Tests/CryptToolTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Core\AssocArray' in method 'decryptMessage'.
Open

                $values = AssocArray::byJsonString(substr($data, 1), array('b', 't', 'k', 'm', 'n', 's'));
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptTool.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Sodium' in method 'derivePublicKey'.
Open

        return Sodium::crypto_box_publickey_from_secretkey($privateKey);
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptToolSodiumDep.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

        Common::required($result);
Severity: Minor
Found in source/Threema/Console/Command/Credits.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

        Common::l($hashedEmail);
Severity: Minor
Found in source/Threema/Console/Command/HashEmail.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

            Common::l('Message ID: '.$result->getMessageId());
Severity: Minor
Found in source/Threema/Console/Command/SendE2EText.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Threema\Console\Common' in method 'help'.
Open

                Common::l();
Severity: Minor
Found in source/Threema/Console/Run.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method createDefaultOptions() has an NPath complexity of 216. The configured NPath complexity threshold is 200.
Open

    private function createDefaultOptions(\Closure $progress = null) {
        $options = array(
            CURLOPT_RETURNTRANSFER => true
        );
Severity: Minor
Found in source/Threema/MsgApi/Connection.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method receiveMessage() has an NPath complexity of 1566. The configured NPath complexity threshold is 200.
Open

    public final function receiveMessage($threemaId,
                                         $messageId,
                                         $box,
                                         $nonce,
                                         $outputFolder = null,
Severity: Minor
Found in source/Threema/MsgApi/Helpers/E2EHelper.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\Salt' in method 'openSecretBox'.
Open

        $data = Salt::secretbox_open($boxPad, $nonce, $key);
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptToolSalt.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Salt' in method 'encryptImageData'.
Open

            Salt::decodeInput($nonce),
Severity: Minor
Found in source/Threema/MsgApi/Tools/CryptToolSalt.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

            Common::e($result->getErrorMessage());
Severity: Minor
Found in source/Threema/Console/Command/Credits.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

            Common::e($result->getErrorMessage());
Severity: Minor
Found in source/Threema/Console/Command/LookupIdByPhoneNo.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

        Common::required($threemaId, $from, $secret, $privateKey, $path);
Severity: Minor
Found in source/Threema/Console/Command/SendE2EFile.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'doRun'.
Open

            Common::l('Error: '.$result->getErrorMessage());
Severity: Minor
Found in source/Threema/Console/Command/SendSimple.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Threema\Console\Common' in method 'help'.
Open

        Common::l('Threema PHP MsgApi Tool');
Severity: Minor
Found in source/Threema/Console/Run.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language