Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

Missing class import via use statement (line '346', column '23').
Open

            throw new XenForo_Exception('Message "' . $messageId . '" has already been received and is already saved. This may indicate a replay attack.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Callback.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '117', column '60').
Open

                $status['libsodiumphp']['descr']     = new XenForo_Phrase('option_threema_gateway_status_libsodiumphp_outdated');
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '115', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '568', column '23').
Open

            throw new XenForo_Exception('Could not get user 2FA data.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '213', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_sdk'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '245', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_keystorepath'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '39', column '27').
Open

        $gwSettings = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '111', column '52').
Open

                $status['libsodium']['text'] = new XenForo_Phrase('option_threema_gateway_status_libsodium_version', ['version' => \Sodium\version_string()]);
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '41', column '28').
Open

        $this->input = new XenForo_Input($request);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Callback.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '28', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '33', column '36').
Open

            $dataWriter->error(new XenForo_Phrase('threemagw_invalid_keystorepath'), $fieldName);
Severity: Minor
Found in src/library/ThreemaGateway/Option/PhpKeyStorePath.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '153', column '31').
Open

            $gwSettings = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '161', column '49').
Open

            $status['phpsdk']['addition'] = new XenForo_Phrase('option_threema_gateway_status_phpsdk_featurelevel', ['level' => $sdk->getFeatureLevel()]);
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '228', column '51').
Open

            $status['credits']['descr']     = new XenForo_Phrase('option_threema_gateway_status_credits_error');
Severity: Minor
Found in src/library/ThreemaGateway/Option/Status.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '63', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '57', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_sending_failed') . ' ' . $e->getMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Sender.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '117', column '27').
Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_account_locked_due_to_high_number_of_sent_messages'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Sender.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '170', column '27').
Open

                throw new XenForo_Exception('preProcessPending() could not get any pending request data.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '496', column '23').
Open

            throw new Exception('preSaveData() returned an error and prevented data saving.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method applyFilter has a boolean flag argument $failOnError, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function applyFilter($filterType, $filterData, $failOnError = true)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/TextMessage.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language