Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

Missing class import via use statement (line '233', column '29').
Open

            $keystore = new ThreemaGateway_Handler_DbKeystore();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '575', column '23').
Open

            throw new XenForo_Exception('Could not get provider data. (error: ' . $e->getMessage() . ')');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '29', column '27').
Open

            $error = (new XenForo_Phrase('threemagw_invalid_threema_id'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '235', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_privatekey'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '179', column '23').
Open

            throw new XenForo_Exception('Parameter $messageId missing.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Receiver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method checkThreemaId has a boolean flag argument $checkExistence, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function checkThreemaId(&$threemaid, $type, &$error, $checkExistence = true)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '38', column '25').
Open

        $gwServer = new ThreemaGateway_Handler_Action_GatewayServer;
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getFileList has a boolean flag argument $queryMetaData, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getFileList($mimeType = null, $fileType = null, $threemaId = null, $queryMetaData = true)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Receiver.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '83', column '27').
Open

                throw new XenForo_Exception('Unknown filter type: ' . $filterType);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/DeliveryReceipt.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '235', column '29').
Open

            $keystore = new Threema\MsgApi\PublicKeyStores\PhpFile(__DIR__ . '/../' . $phpKeystore['path']);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '109', column '27').
Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Sender.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '76', column '35').
Open

            $this->settings = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method __construct has a boolean flag argument $skipPermissionCheck, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($alreadyPrepared = false, $skipPermissionCheck = false)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Receiver.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '523', column '23').
Open

            throw new Exception('postSaveData() returned an error.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '546', column '23').
Open

            throw new XenForo_Exception('Could not get provider data from session using key ' . $sessionKey . '.');
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method applyFilter has a boolean flag argument $failOnError, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function applyFilter($filterType, $filterData, $failOnError = true)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/TfaCallback/DeliveryReceipt.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '45', column '27').
Open

            $error = (new XenForo_Phrase('threemagw_threema_id_does_not_exist'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '124', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_getting_credits_failed') . ' ' . $result->getErrorMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language