Sign upLogin

soumya92/barista

View on GitHub
Star
modules/battery/battery.go

Summary

Maintainability
A
3 hrs
Test Coverage
A
99%

Function batteryInfo has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func batteryInfo(name string) Info {
    batteryPath := fmt.Sprintf("/sys/class/power_supply/%s/uevent", name)
    l.Fine("Reading from %s", batteryPath)
    f, err := fs.Open(batteryPath)
    if err != nil {
Severity: Minor
Found in modules/battery/battery.go - About 1 hr to fix

    Function allBatteriesInfo has 57 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func allBatteriesInfo() Info {
    dir, err := fs.Open("/sys/class/power_supply")
    if err != nil {
        l.Log("No batteries: %s", err)
        return Info{Status: Disconnected}
    Severity: Minor
    Found in modules/battery/battery.go - About 1 hr to fix

      Function allBatteriesInfo has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func allBatteriesInfo() Info {
    dir, err := fs.Open("/sys/class/power_supply")
    if err != nil {
        l.Log("No batteries: %s", err)
        return Info{Status: Disconnected}
      Severity: Minor
      Found in modules/battery/battery.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status