speedworks/speedy

View on GitHub

Showing 149 of 149 total issues

Method orWhere has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function orWhere()
    {
        $numArgs = func_num_args();
        $args = func_get_args();
        $col = null;
Severity: Minor
Found in Core/Classes/DB.php - About 1 hr to fix

    Method where has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function where()
        {
            $numArgs = func_num_args();
            $args = func_get_args();
            $col = null;
    Severity: Minor
    Found in Core/Classes/DB.php - About 1 hr to fix

      Avoid using undefined variables such as '$options' which will lead to PHP notices.
      Open

              ->send($options);
      Severity: Minor
      Found in Core/Classes/Mailer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
      {
          private function bar()
          {
              // $message is undefined
              echo $message;
          }
      }

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$options' which will lead to PHP notices.
      Open

              $options['ssl']['verify_peer'] = false;
      Severity: Minor
      Found in Core/Classes/Mailer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
      {
          private function bar()
          {
              // $message is undefined
              echo $message;
          }
      }

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Method Authorize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function Authorize($authType, $redirectTo=null)
          {
              $auth = new BaseAuth();
              if($authType == "session")
              {
      Severity: Minor
      Found in Core/Middleware/Auth.php - About 1 hr to fix

        Method view has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function view($view, $arrayParams = [], $exit = false)
            {
                $loader = new Twig_Loader_Filesystem(__DIR__.'/../../Views');
                $cache = __DIR__.'/../../Storage/Cache/Views';
                if(!$_ENV['cache_template'])
        Severity: Minor
        Found in Core/Classes/BaseController.php - About 1 hr to fix

          Method Authenticate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function Authenticate()
              {
                  $auth = new BaseAuth();
                  if($this->type == "KEY")
                  {
          Severity: Minor
          Found in Core/Middleware/Auth.php - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if($this->orWhereConds != null)
                    {
                        if($flag == 0)
                        {
                            $where .= ' WHERE ';
            Severity: Major
            Found in Core/Classes/DB.php and 2 other locations - About 55 mins to fix
            Core/Classes/DB.php on lines 235..252
            Core/Classes/DB.php on lines 253..270

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if($this->inConds != null)
                    {
                        if($flag == 0)
                        {
                            $where .= ' WHERE ';
            Severity: Major
            Found in Core/Classes/DB.php and 2 other locations - About 55 mins to fix
            Core/Classes/DB.php on lines 217..234
            Core/Classes/DB.php on lines 253..270

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if($this->notInConds != null)
                    {
                        if($flag == 0)
                        {
                            $where .= ' WHERE ';
            Severity: Major
            Found in Core/Classes/DB.php and 2 other locations - About 55 mins to fix
            Core/Classes/DB.php on lines 217..234
            Core/Classes/DB.php on lines 235..252

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function ErrorHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function ErrorHandler($errno, $errstr, $errfile, $errline)
            {
                if (!(error_reporting() & $errno))
                {
                    return;
            Severity: Minor
            Found in public/index.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static function set($cookieName, $cookieValue=null, $expiryDays=365, $path=null, $domain=null, $secure=null, $httpOnly=null)
            Severity: Major
            Found in Core/Classes/Cookie.php - About 50 mins to fix

              Avoid variables with short names like $db. Configured minimum length is 3.
              Open

                      $db = DB::ADO();
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $rs. Configured minimum length is 3.
              Open

                      $rs = $db->Execute('SELECT * from users WHERE id = ? AND user_name = ? AND status = 1',[$uid, $uname]);
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $db. Configured minimum length is 3.
              Open

                      $db = new DB();
              Severity: Minor
              Found in Core/Classes/DB.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $db. Configured minimum length is 3.
              Open

                      $db = DB::ADO();
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $rs. Configured minimum length is 3.
              Open

                      $rs = $db->Execute('select user_id from api_keys WHERE api_key = ? AND status = ? ',[$key, 1]);
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $db. Configured minimum length is 3.
              Open

                      $db = DB::ADO();
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $rs. Configured minimum length is 3.
              Open

                      $rs = $db->Execute('SELECT * from users WHERE user_name = ? AND password = ? AND status = 1',[$userName, System::GenerateHash($password)]);
              Severity: Minor
              Found in Core/Classes/BaseAuth.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Avoid variables with short names like $db. Configured minimum length is 3.
              Open

                      $db = ADONewConnection($_ENV['DB_ADO_DRIVER']);
              Severity: Minor
              Found in Core/Classes/DB.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
                  private $q = 15; // VIOLATION - Field
                  public static function main( array $as ) { // VIOLATION - Formal
                      $r = 20 + $this->q; // VIOLATION - Local
                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                          $r += $this->q;
                      }
                  }
              }

              Source https://phpmd.org/rules/naming.html#shortvariable

              Severity
              Category
              Status
              Source
              Language