Sign upLogin

sylvchev/mdla

View on GitHub
Star

Showing 119 of 119 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    _ = objerr.plot(
        step * arange(1, len(objective_error) + 1),
        objective_error,
Severity: Major
Found in examples/example_multivariate.py and 3 other locations - About 1 hr to fix
examples/example_multivariate.py on lines 32..34
examples/example_univariate.py on lines 26..28
examples/example_univariate.py on lines 40..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    _ = detection.plot(
        step * arange(1, len(detect_rate) + 1),
        detect_rate,
Severity: Major
Found in examples/example_univariate.py and 3 other locations - About 1 hr to fix
examples/example_multivariate.py on lines 18..20
examples/example_multivariate.py on lines 32..34
examples/example_univariate.py on lines 26..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    _ = objerr.plot(
        step * arange(1, len(objective_error) + 1),
        objective_error,
Severity: Major
Found in examples/example_univariate.py and 3 other locations - About 1 hr to fix
examples/example_multivariate.py on lines 18..20
examples/example_multivariate.py on lines 32..34
examples/example_univariate.py on lines 40..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

mul2.errorbar(
    range(1, n_nonzero_coefs + 1),
    rmse_uniform3.mean(1),
    yerr=rmse_uniform3.std(1),
Severity: Major
Found in examples/example_sparse_decomposition.py and 2 other locations - About 1 hr to fix
examples/example_sparse_decomposition.py on lines 151..154
examples/example_sparse_decomposition.py on lines 171..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _multivariate_OMP has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def _multivariate_OMP(signal, dictionary, n_nonzero_coefs=None, verbose=False):
    """Sparse coding multivariate signal with OMP

    Returns residual and a decomposition array (n_nonzero_coefs, 3),
    each line indicating (amplitude, offset, kernel).
Severity: Minor
Found in mdla/mdla.py - About 1 hr to fix

    Function plot_recov has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def plot_recov(wc, wfs, hc, hfs, bd, dr99, dr97, n_iter, figname):
    Severity: Major
    Found in experiments/experiment_dictionary_recovering.py - About 1 hr to fix

      Function _generate_testbed has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _generate_testbed(
      Severity: Major
      Found in examples/example_sparse_decomposition.py - About 1 hr to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            wc, wfs, hc, hfs = o["wc"], o["wfs"], o["hc"], o["hfs"]
        Severity: Major
        Found in experiments/experiment_multivariate_recovering.py and 3 other locations - About 1 hr to fix
        experiments/experiment_dictionary_recovering.py on lines 233..233
        experiments/experiment_multivariate_recovering.py on lines 247..247
        experiments/experiment_multivariate_recovering.py on lines 248..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            wc, wfs, hc, hfs = o["wc"], o["wfs"], o["hc"], o["hfs"]
        Severity: Major
        Found in experiments/experiment_dictionary_recovering.py and 3 other locations - About 1 hr to fix
        experiments/experiment_multivariate_recovering.py on lines 246..246
        experiments/experiment_multivariate_recovering.py on lines 247..247
        experiments/experiment_multivariate_recovering.py on lines 248..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            wcpa, wbc, wg, wfb = o["wcpa"], o["wbc"], o["wg"], o["wfb"]
        Severity: Major
        Found in experiments/experiment_multivariate_recovering.py and 3 other locations - About 1 hr to fix
        experiments/experiment_dictionary_recovering.py on lines 233..233
        experiments/experiment_multivariate_recovering.py on lines 246..246
        experiments/experiment_multivariate_recovering.py on lines 248..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function multivariate_sparse_encode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        def multivariate_sparse_encode(
    X, dictionary, n_nonzero_coefs=None, n_jobs=1, verbose=False
):
    """Sparse coding
        Severity: Minor
        Found in mdla/mdla.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            hcpa, hbc, hg, hfb = o["hcpa"], o["hbc"], o["hg"], o["hfb"]
        Severity: Major
        Found in experiments/experiment_multivariate_recovering.py and 3 other locations - About 1 hr to fix
        experiments/experiment_dictionary_recovering.py on lines 233..233
        experiments/experiment_multivariate_recovering.py on lines 246..246
        experiments/experiment_multivariate_recovering.py on lines 247..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        learned_dict = MiniBatchMultivariateDictLearning(
        Severity: Major
        Found in examples/example_univariate.py and 1 other location - About 1 hr to fix
        examples/example_multivariate.py on lines 127..127

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function plot_kernels has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def plot_kernels(
        Severity: Major
        Found in examples/plot_bci_dict.py - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          learned_dict = MiniBatchMultivariateDictLearning(
          Severity: Major
          Found in examples/example_multivariate.py and 1 other location - About 1 hr to fix
          examples/example_univariate.py on lines 135..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function plot_recov has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def plot_recov(wc, wfs, hc, hfs, dr99, dr97, n_iter, figname):
          Severity: Major
          Found in experiments/experiment_multivariate_recovering.py - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        d = MiniBatchMultivariateDictLearning(
            Severity: Major
            Found in experiments/experiment_dictionary_recovering.py and 1 other location - About 1 hr to fix
            experiments/experiment_multivariate_recovering.py on lines 278..278

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        d = MiniBatchMultivariateDictLearning(
            Severity: Major
            Found in experiments/experiment_multivariate_recovering.py and 1 other location - About 1 hr to fix
            experiments/experiment_dictionary_recovering.py on lines 256..256

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function _generate_testbed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            def _generate_testbed(
    kernel_init_len,
    n_nonzero_coefs,
    n_kernels,
    rng=None,
            Severity: Minor
            Found in examples/example_sparse_decomposition.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _generate_testbed has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _generate_testbed(
            Severity: Major
            Found in experiments/experiment_dictionary_recovering.py - About 50 mins to fix
              Severity
              Category
              Status
              Source
              Language