Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/class.databasequery.php

Summary

Maintainability
C
1 day
Test Coverage

DatabaseQuery has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class DatabaseQuery extends DatabaseStatement
{
    use DatabaseWhereDefinition;
    use DatabaseCacheableExecutionDefinition;
Severity: Minor
Found in symphony/lib/toolkit/class.databasequery.php - About 3 hrs to fix

    File class.databasequery.php has 275 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * @package toolkit
 */
    Severity: Minor
    Found in symphony/lib/toolkit/class.databasequery.php - About 2 hrs to fix

      Method orderBy has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function orderBy($cols, $direction = 'ASC')
    {
        $orders = [];
        $randoms = ['RAND()', 'RANDOM()'];
        if (!is_array($cols)) {
      Severity: Minor
      Found in symphony/lib/toolkit/class.databasequery.php - About 1 hr to fix

        Function orderBy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function orderBy($cols, $direction = 'ASC')
    {
        $orders = [];
        $randoms = ['RAND()', 'RANDOM()'];
        if (!is_array($cols)) {
        Severity: Minor
        Found in symphony/lib/toolkit/class.databasequery.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function countProjection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function countProjection($col = '*')
    {
        $ignoredParts = ['statement', 'optimizer', 'cache', 'projection', 'order by', 'limit', 'offset'];
        $cp = new DatabaseQuery($this->getDB(), ["COUNT($col)"]);
        foreach ($this->getSQL() as $part) {
        Severity: Minor
        Found in symphony/lib/toolkit/class.databasequery.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status