Sign upLogin

symphonycms/symphony-2

View on GitHub
Star
symphony/lib/toolkit/fields/field.textarea.php

Summary

Maintainability
C
1 day
Test Coverage

File field.textarea.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @package toolkit
 */
Severity: Minor
Found in symphony/lib/toolkit/fields/field.textarea.php - About 2 hrs to fix

    Function prepareExportValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function prepareExportValue($data, $mode, $entry_id = null)
    {
        $modes = (object)$this->getExportModes();

        // Export handles:
    Severity: Minor
    Found in symphony/lib/toolkit/fields/field.textarea.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method buildDSRetrievalSQL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
    Severity: Minor
    Found in symphony/lib/toolkit/fields/field.textarea.php - About 1 hr to fix

      Method displayPublishPanel has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null)
      Severity: Minor
      Found in symphony/lib/toolkit/fields/field.textarea.php - About 45 mins to fix

        Function appendFormattedElement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null)
    {
        $attributes = array();

        if (!is_null($mode)) {
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.textarea.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method appendFormattedElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null)
        Severity: Minor
        Found in symphony/lib/toolkit/fields/field.textarea.php - About 35 mins to fix

          Method processRawFieldData has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function processRawFieldData($data, &$status, &$message = null, $simulate = false, $entry_id = null)
          Severity: Minor
          Found in symphony/lib/toolkit/fields/field.textarea.php - About 35 mins to fix

            Function __applyFormatting has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function __applyFormatting($data, $validate = false, &$errors = null)
    {
        $result = '';

        if ($this->get('formatter')) {
            Severity: Minor
            Found in symphony/lib/toolkit/fields/field.textarea.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return null;
            Severity: Major
            Found in symphony/lib/toolkit/fields/field.textarea.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return General::sanitize($data['value']);
              Severity: Major
              Found in symphony/lib/toolkit/fields/field.textarea.php - About 30 mins to fix

                Function buildDSRetrievalSQL has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function buildDSRetrievalSQL($data, &$joins, &$where, $andOperation = false)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog(
                get_called_class() . '::buildDSRetrievalSQL()',
                Severity: Minor
                Found in symphony/lib/toolkit/fields/field.textarea.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function prepareImportValue($data, $mode, $entry_id = null)
    {
        $message = $status = null;
        $modes = (object)$this->getImportModes();
                Severity: Major
                Found in symphony/lib/toolkit/fields/field.textarea.php and 2 other locations - About 1 hr to fix
                symphony/lib/toolkit/fields/field.input.php on lines 242..254
                symphony/lib/toolkit/fields/field.upload.php on lines 676..688

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status