Sign upLogin

trailsjs/trailpack-sequelize

View on GitHub
Star

Showing 29 of 29 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        store: {
          enumerable: false,
          value: configOverrides.store || config.store || app.config.get('models.defaultStore'),
          writable: false
        },
Severity: Minor
Found in lib/transformer.js and 1 other location - About 40 mins to fix
lib/transformer.js on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        .then(ids => childModel.update(values, _.extend({
          where: {
            $and: [
              criteria || {},
              {
Severity: Minor
Found in api/services/FootprintService.js and 1 other location - About 35 mins to fix
api/services/FootprintService.js on lines 310..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        .then(ids => childModel.findAll(_.extend({
          where: {
            $and: [
              criteria || {},
              {
Severity: Minor
Found in api/services/FootprintService.js and 1 other location - About 35 mins to fix
api/services/FootprintService.js on lines 379..390

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return this._getThroughModelAssociation(association, parentId)
        .then(ids => childModel.update(values, _.extend({
          where: {
            $and: [
              criteria || {},
Severity: Major
Found in api/services/FootprintService.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return this.find(parentModelName, parentId)
        .then(parent => this.find(childModelName, parent[association.identifierField], options))
    Severity: Major
    Found in api/services/FootprintService.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return this.find(parentModelName, parentId)
        .then(parent => this.update(childModelName, parent[association.identifierField], values, options))
      Severity: Major
      Found in api/services/FootprintService.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return this._getThroughModelAssociation(association, parentId)
        .then(ids => childModel.findAll(_.extend({
          where: {
            $and: [
              criteria || {},
        Severity: Major
        Found in api/services/FootprintService.js - About 30 mins to fix

          Function createAssociation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            createAssociation(parentModelName, parentId, childAttributeName, values, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
          Severity: Minor
          Found in api/services/FootprintService.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function transformModels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            transformModels (app) {

    // const models = app.models

    return _.mapValues(app.models, (model, modelName) => {
          Severity: Minor
          Found in lib/transformer.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language