Sign upLogin

ujiro99/tlt

View on GitHub
Star

Showing 185 of 185 total issues

Avoid too many return statements within this function.
Open

            return newCoordinates
Severity: Major
Found in src/components/Tree/keyboardCoordinates.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return undefined
    Severity: Major
    Found in src/components/Tree/keyboardCoordinates.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return to + current - from - length + 1
      Severity: Major
      Found in src/services/util.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const handleChange = (color: ColorResult) => {
    upsertTag({ name: tag.name, colorHex: color.hex })
  }
        Severity: Minor
        Found in src/components/Tag/TaskTag.tsx and 1 other location - About 30 mins to fix
        src/components/Tag/TagContextMenu.tsx on lines 66..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

            return current
        Severity: Major
        Found in src/services/util.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return to - (length - 1)
          Severity: Major
          Found in src/services/util.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return to + (current - from)
            Severity: Major
            Found in src/services/util.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return current
              Severity: Major
              Found in src/services/util.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return current
                Severity: Major
                Found in src/services/util.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return Parser.parseArray(range.map((r) => r.data))
                  Severity: Major
                  Found in src/hooks/useTaskManager.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      return current
                    Severity: Major
                    Found in src/services/util.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return current
                      Severity: Major
                      Found in src/services/util.ts - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          const changeColor = (color: ColorResult) => {
    upsertTag({ name: tag.name, colorHex: color.hex })
  }
                        Severity: Minor
                        Found in src/components/Tag/TagContextMenu.tsx and 1 other location - About 30 mins to fix
                        src/components/Tag/TaskTag.tsx on lines 23..25

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid too many return statements within this function.
                        Open

                            return current - length
                        Severity: Major
                        Found in src/services/util.ts - About 30 mins to fix

                          Function useTaskManager has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function useTaskManager(): ITaskManager {
  const [root, setRoot] = useRecoilState<Node>(nodeState)
  const { moveTracking } = useTrackingMove()
  const { moveEventLine } = useEventAlarm()
  const { tags, upsertTag } = useTagHistory()
                          Severity: Minor
                          Found in src/hooks/useTaskManager.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function stopTrackings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export const stopTrackings = (
  root: Node,
  trackings: TrackingState[],
): [Node, CalendarEvent[]] => {
  const events = []
                          Severity: Minor
                          Found in src/hooks/useTrackingState.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function removeItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function removeItem(items: TreeItems, id: UniqueIdentifier) {
  const newItems = []

  for (const item of items) {
    if (item.id === id) {
                          Severity: Minor
                          Found in src/components/Tree/utilities.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function useEditable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function useEditable(line: number): useEditableReturn {
  const [focusLine, setFocusLine] = useRecoilState(focusLineState)
  const [editingLine, setEditingLine] = useRecoilState(editingLineState)

  function isEditing() {
                          Severity: Minor
                          Found in src/hooks/useEditable.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function toText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            static toText(alarm: AlarmRule): String {
    if (alarm == null) return null

    let msg
    if (alarm.anchor === ALARM_ANCHOR.START) {
                          Severity: Minor
                          Found in src/models/alarmRule.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            constructor(keyStr: string) {
    this.keyType = KEY_TYPE.SINGLE
    this.rawKey = keyStr
    this.keys = []
                          Severity: Minor
                          Found in src/models/taskRecordKey.ts - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language