Sign upLogin

unclesp1d3r/CipherSwarm

View on GitHub
Star
app/helpers/attack_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
18%

AttackHelper#attack_status_class manually dispatches method call
Open

    return "default" unless attack.respond_to?(:state)
Severity: Minor
Found in app/helpers/attack_helper.rb by reek

Reek reports a Manual Dispatch smell if it finds source code that manually checks whether an object responds to a method before that method is called. Manual dispatch is a type of Simulated Polymorphism which leads to code that is harder to reason about, debug, and refactor.

Example

class MyManualDispatcher
  attr_reader :foo

  def initialize(foo)
    @foo = foo
  end

  def call
    foo.bar if foo.respond_to?(:bar)
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [9]: MyManualDispatcher manually dispatches method call (ManualDispatch)

There are no issues that match your filters.

Category
Status