Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/api/flow.go

Summary

Maintainability
F
6 days
Test Coverage

Method flowHandler.WaitWorkflow has a Cognitive Complexity of 77 (exceeds 20 allowed). Consider refactoring.
Open

func (h *flowHandler) WaitWorkflow(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
Severity: Minor
Found in pkg/api/flow.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File flow.go has 670 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package api

import (
    "bytes"
    "context"
Severity: Minor
Found in pkg/api/flow.go - About 6 hrs to fix

    Method flowHandler.WaitWorkflow has 130 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (h *flowHandler) WaitWorkflow(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
    Severity: Major
    Found in pkg/api/flow.go - About 4 hrs to fix

      Function ToGRPCCloudEvents has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
      Open

      func ToGRPCCloudEvents(r *http.Request) ([]cloudevents.Event, error) {
    var events []cloudevents.Event
    ct := r.Header.Get("Content-type")
    oct := ct
      Severity: Minor
      Found in pkg/api/flow.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ToGRPCCloudEvents has 97 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func ToGRPCCloudEvents(r *http.Request) ([]cloudevents.Event, error) {
    var events []cloudevents.Event
    ct := r.Header.Get("Content-type")
    oct := ct
      Severity: Major
      Found in pkg/api/flow.go - About 2 hrs to fix

        Function ToGRPCCloudEvents has 12 return statements (exceeds 4 allowed).
        Open

        func ToGRPCCloudEvents(r *http.Request) ([]cloudevents.Event, error) {
    var events []cloudevents.Event
    ct := r.Header.Get("Content-type")
    oct := ct
        Severity: Major
        Found in pkg/api/flow.go - About 1 hr to fix

          Method flowHandler.WaitWorkflow has 10 return statements (exceeds 4 allowed).
          Open

          func (h *flowHandler) WaitWorkflow(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
          Severity: Major
          Found in pkg/api/flow.go - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                if err != nil {
                        respond(w, nil, err)
                        return
                    }
            Severity: Major
            Found in pkg/api/flow.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              } else if str, ok := x.(string); ok {
                    data = []byte(str)
                    b64, err := base64.StdEncoding.DecodeString(str)
                    if err == nil {
                        data = b64
              Severity: Major
              Found in pkg/api/flow.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if err != nil {
                        panic(err)
                    }
                Severity: Major
                Found in pkg/api/flow.go - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) EventListenersSSE(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())
    namespace := mux.Vars(r)["ns"]

    ctx := r.Context()
                  Severity: Major
                  Found in pkg/api/flow.go and 1 other location - About 3 hrs to fix
                  pkg/api/flow.go on lines 741..790

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 298.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) EventHistorySSE(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())
    namespace := mux.Vars(r)["ns"]

    ctx := r.Context()
                  Severity: Major
                  Found in pkg/api/flow.go and 1 other location - About 3 hrs to fix
                  pkg/api/flow.go on lines 670..719

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 298.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) EventListeners(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    p, err := pagination(r)
                  Severity: Major
                  Found in pkg/api/flow.go and 1 other location - About 1 hr to fix
                  pkg/api/flow.go on lines 721..739

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 165.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) EventHistory(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    p, err := pagination(r)
                  Severity: Major
                  Found in pkg/api/flow.go and 1 other location - About 1 hr to fix
                  pkg/api/flow.go on lines 650..668

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 165.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) InstanceOutput(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 792..806
                  pkg/api/flow.go on lines 930..944
                  pkg/api/flow.go on lines 962..976
                  pkg/api/flow.go on lines 978..992
                  pkg/api/flow.go on lines 1332..1346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) ReplayEvent(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 792..806
                  pkg/api/flow.go on lines 930..944
                  pkg/api/flow.go on lines 946..960
                  pkg/api/flow.go on lines 962..976
                  pkg/api/flow.go on lines 978..992

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) InstanceInput(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 792..806
                  pkg/api/flow.go on lines 946..960
                  pkg/api/flow.go on lines 962..976
                  pkg/api/flow.go on lines 978..992
                  pkg/api/flow.go on lines 1332..1346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) InstanceCancel(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 792..806
                  pkg/api/flow.go on lines 930..944
                  pkg/api/flow.go on lines 946..960
                  pkg/api/flow.go on lines 962..976
                  pkg/api/flow.go on lines 1332..1346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) Instance(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 930..944
                  pkg/api/flow.go on lines 946..960
                  pkg/api/flow.go on lines 962..976
                  pkg/api/flow.go on lines 978..992
                  pkg/api/flow.go on lines 1332..1346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                  func (h *flowHandler) InstanceMetadata(w http.ResponseWriter, r *http.Request) {
    slog.Debug("Handling request", "this", this())

    ctx := r.Context()
    namespace := mux.Vars(r)["ns"]
                  Severity: Major
                  Found in pkg/api/flow.go and 5 other locations - About 1 hr to fix
                  pkg/api/flow.go on lines 792..806
                  pkg/api/flow.go on lines 930..944
                  pkg/api/flow.go on lines 946..960
                  pkg/api/flow.go on lines 978..992
                  pkg/api/flow.go on lines 1332..1346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 153.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status