vorteil/vorteil

View on GitHub

Showing 170 of 354 total issues

File ova-template.go has 786 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package xva

/**
 * SPDX-License-Identifier: Apache-2.0
 * Copyright 2020 vorteil.io Pty Ltd
Severity: Major
Found in pkg/xva/ova-template.go - About 1 day to fix

    Function Backends has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
    Open

    func Backends() ([]string, error) {
        var installedVirtualizers []string
        path := os.Getenv("PATH")
        separated := ":"
        if runtime.GOOS == "windows" {
    Severity: Minor
    Found in pkg/virtualizers/util.go - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Bundle.Reader has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
    Open

    func (bundle *Bundle) Reader(tags ...string) io.ReadCloser {
    
        pr, pw := io.Pipe()
    
        go func(pw *io.PipeWriter) {
    Severity: Minor
    Found in pkg/vkern/bundle.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run has a Cognitive Complexity of 51 (exceeds 20 allowed). Consider refactoring.
    Open

    func run(virt virtualizers.Virtualizer, diskpath string, cfg *vcfg.VCFG, name string) error {
    
        // Gather home directory for firecracker storage path
        home, err := homedir.Dir()
        if err != nil {
    Severity: Minor
    Found in pkg/cli/run.go - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File images.go has 624 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package cli
    
    /**
     * SPDX-License-Identifier: Apache-2.0
     * Copyright 2020 vorteil.io Pty Ltd
    Severity: Minor
    Found in pkg/cli/images.go - About 5 hrs to fix

      Method RemoteManager.get has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
      Open

      func (mgr *RemoteManager) get(version CalVer) error {
      
          Logger("Downloading kernel version: %s", version.String())
      
          kernelName := filenameFromVersion(version)
      Severity: Minor
      Found in pkg/vkern/manager-remote.go - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File virtualizer.go has 581 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      package virtualbox
      
      /**
       * SPDX-License-Identifier: Apache-2.0
       * Copyright 2020 vorteil.io Pty Ltd
      Severity: Minor
      Found in pkg/virtualizers/virtualbox/virtualizer.go - About 3 hrs to fix

        Method CLIRemoteManager.get has 115 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (mgr *CLIRemoteManager) get(version CalVer) error {
        
            prog := mgr.log.NewProgress(fmt.Sprintf("Fetching kernel: %s", version.String()), "", 0)
            defer prog.Finish(false)
        
        
        Severity: Major
        Found in pkg/vkern/cli.go - About 3 hrs to fix

          Function LookForIP has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
          Open

          func LookForIP(l *logger.Logger, routes []virtualizers.NetworkInterface) []virtualizers.NetworkInterface {
          
              sub := l.Subscribe()
              inbox := sub.Inbox()
              var msg string
          Severity: Minor
          Found in pkg/virtualizers/util/util.go - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function run has 89 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func run(virt virtualizers.Virtualizer, diskpath string, cfg *vcfg.VCFG, name string) error {
          
              // Gather home directory for firecracker storage path
              home, err := homedir.Dir()
              if err != nil {
          Severity: Major
          Found in pkg/cli/run.go - About 2 hrs to fix

            Method StreamOptimizedWriter.flushGrain has 89 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (w *StreamOptimizedWriter) flushGrain() error {
                var err error
                defer func() {
                    w.grainNo++
                    w.cursor = w.grainNo * GrainSize
            Severity: Major
            Found in pkg/vmdk/stream-optimized.go - About 2 hrs to fix

              Function Backends has 86 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func Backends() ([]string, error) {
                  var installedVirtualizers []string
                  path := os.Getenv("PATH")
                  separated := ":"
                  if runtime.GOOS == "windows" {
              Severity: Major
              Found in pkg/virtualizers/util.go - About 2 hrs to fix

                Method Virtualizer.Start has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
                Open

                func (v *Virtualizer) Start() error {
                    v.logger.Debugf("Starting VM")
                    v.command = exec.Command(v.command.Args[0], v.command.Args[1:]...)
                    v.command.SysProcAttr = &syscall.SysProcAttr{
                        Setpgid: true,
                Severity: Minor
                Found in pkg/virtualizers/qemu/virtualizer_notwindows.go - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method StreamOptimizedWriter.flushGrain has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
                Open

                func (w *StreamOptimizedWriter) flushGrain() error {
                    var err error
                    defer func() {
                        w.grainNo++
                        w.cursor = w.grainNo * GrainSize
                Severity: Minor
                Found in pkg/vmdk/stream-optimized.go - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method SparseWriter.writeGrainData has 82 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (w *SparseWriter) writeGrainData() error {
                    var err error
                
                    firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
                
                
                Severity: Major
                Found in pkg/vmdk/sparse.go - About 2 hrs to fix

                  Function copyImageFileRecursive has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func copyImageFileRecursive(vorteilImage *vdecompiler.IO, ino int, rpath string, destFilePath string) error {
                      var f *os.File
                      var rdr io.Reader
                      var err error
                      var entries []*vdecompiler.DirectoryEntry
                  Severity: Minor
                  Found in pkg/imagetools/cp.go - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method FixedWriter.writeFooter has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (w *FixedWriter) writeFooter() error {
                  
                      var err error
                      _, err = w.Seek(0, io.SeekEnd)
                      if err != nil {
                  Severity: Major
                  Found in pkg/vhd/fixed.go - About 2 hrs to fix

                    Method RemoteManager.get has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (mgr *RemoteManager) get(version CalVer) error {
                    
                        Logger("Downloading kernel version: %s", version.String())
                    
                        kernelName := filenameFromVersion(version)
                    Severity: Major
                    Found in pkg/vkern/manager-remote.go - About 2 hrs to fix

                      Method Bundle.Reader has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (bundle *Bundle) Reader(tags ...string) io.ReadCloser {
                      
                          pr, pw := io.Pipe()
                      
                          go func(pw *io.PipeWriter) {
                      Severity: Major
                      Found in pkg/vkern/bundle.go - About 2 hrs to fix

                        Method SparseWriter.writeGrainData has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (w *SparseWriter) writeGrainData() error {
                            var err error
                        
                            firstDataSector := int64(w.hdr.OverHead) * SectorsPerGrain
                        
                        
                        Severity: Minor
                        Found in pkg/vmdk/sparse.go - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language