vorteil/vorteil

View on GitHub

Showing 207 of 546 total issues

Method DynamicWriter.writeRedundantFooter has 5 return statements (exceeds 4 allowed).
Open

func (w *DynamicWriter) writeRedundantFooter() error {
    conectix := uint64(0x636F6E6563746978)
    timestamp := time.Now().Unix() - 946684800 // 2000 offset

    // CHS crap
Severity: Major
Found in pkg/vhd/dynamic.go - About 35 mins to fix

    Method Writer.writeHeader has 5 return statements (exceeds 4 allowed).
    Open

    func (w *Writer) writeHeader() error {
        header := new(gcpTarPosixHeader)
        copy(header.Name[:], []byte("disk.raw")) // gcp requires the file is called disk.raw
        octal := strconv.FormatUint(uint64(w.length), 8)
    
    
    Severity: Major
    Found in pkg/gcparchive/gcparchive.go - About 35 mins to fix

      Function build has 5 return statements (exceeds 4 allowed).
      Open

      func build(ctx context.Context, w io.WriteSeeker, cfg *vcfg.VCFG, args *BuildArgs) error {
      
          log := args.Logger
      
          fsCompiler, err := NewFilesystemCompiler(string(cfg.System.Filesystem), log, args.PackageReader.FS(), nil)
      Severity: Major
      Found in pkg/vdisk/build.go - About 35 mins to fix

        Method Virtualizer.Start has 5 return statements (exceeds 4 allowed).
        Open

        func (v *Virtualizer) Start() error {
            v.logger.Debugf("Starting VM")
            switch v.State() {
            case "ready":
                v.state = virtualizers.Changing
        Severity: Major
        Found in pkg/virtualizers/virtualbox/virtualizer.go - About 35 mins to fix

          Method StreamOptimizedWriter.Write has 5 return statements (exceeds 4 allowed).
          Open

          func (w *StreamOptimizedWriter) Write(p []byte) (int, error) {
          
              if w.cursor >= w.h.Size() {
                  return 0, io.EOF
              }
          Severity: Major
          Found in pkg/vmdk/stream-optimized.go - About 35 mins to fix

            Method precompiler.Precompile has 5 return statements (exceeds 4 allowed).
            Open

            func (p *precompiler) Precompile(ctx context.Context, fsSize int64) (*compiler, error) {
            
                var err error
            
                c := &compiler{
            Severity: Major
            Found in pkg/xfs/xfs.go - About 35 mins to fix

              Method MonitoringOptions.preprocess has 5 return statements (exceeds 4 allowed).
              Open

              func (opts *MonitoringOptions) preprocess(b Builder) error {
                  if opts.PreProcessCompleteCallback == nil {
                      return nil
                  }
              
              
              Severity: Major
              Found in pkg/vpkg/package.go - About 35 mins to fix

                Function treeImageFileRecurse has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                Open

                func treeImageFileRecurse(vorteilImage *vdecompiler.IO, ino int, name string) (TreeReport, error) {
                    var treeOut TreeReport = TreeReport{
                        Name:     name,
                        Children: make([]TreeReport, 0),
                    }
                Severity: Minor
                Found in pkg/imagetools/tree.go - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method Provisioner.createImage has 5 return statements (exceeds 4 allowed).
                Open

                func (p *Provisioner) createImage(length int64, args *provisioners.ProvisionArgs, blob *storage.Blob) error {
                
                    imagesClient, err := p.getImagesClient()
                    if err != nil {
                        return err
                Severity: Major
                Found in pkg/provisioners/azure/azure.go - About 35 mins to fix

                  Function pushPackage has 5 return statements (exceeds 4 allowed).
                  Open

                  func pushPackage(builder vpkg.Builder, url string, repo []string) error {
                  
                      // check authentication before doing things
                      token, err := checkAuthentication()
                      if err != nil {
                  Severity: Major
                  Found in pkg/cli/repositories.go - About 35 mins to fix

                    Method CLIRemoteManager.updateList has 5 return statements (exceeds 4 allowed).
                    Open

                    func (mgr *CLIRemoteManager) updateList(ctx context.Context) (List, error) {
                        var list List
                        list = mgr.cache
                    
                        // request remote manifest
                    Severity: Major
                    Found in pkg/vkern/cli.go - About 35 mins to fix

                      Method CLIRemoteManager.forceUpdate has 5 return statements (exceeds 4 allowed).
                      Open

                      func (mgr *CLIRemoteManager) forceUpdate(ctx context.Context) error {
                      
                          err := ctx.Err()
                          if err != nil {
                              return err
                      Severity: Major
                      Found in pkg/vkern/cli.go - About 35 mins to fix

                        Method Provisioner.Provision has 5 return statements (exceeds 4 allowed).
                        Open

                        func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
                        
                            var (
                                length int64
                                f      *os.File
                        Severity: Major
                        Found in pkg/provisioners/azure/azure.go - About 35 mins to fix

                          Method Provisioner.Provision has 5 return statements (exceeds 4 allowed).
                          Open

                          func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
                              projectID := p.keyMap["project_id"].(string)
                          
                              img, err := p.computeClient.Images.Get(projectID, args.Name).Do()
                              if err == nil && !args.Force {
                          Severity: Major
                          Found in pkg/provisioners/google/google.go - About 35 mins to fix

                            Method Provisioner.Validate has 5 return statements (exceeds 4 allowed).
                            Open

                            func (p *Provisioner) Validate() error {
                                if p.cfg.Username == "" || p.cfg.Password == "" || p.cfg.Host == "" {
                                    return fmt.Errorf("username,password and host fields should not be empty")
                                }
                            
                            
                            Severity: Major
                            Found in pkg/provisioners/nutanix/nutanix.go - About 35 mins to fix

                              Method Provisioner.uploadBlob has 5 return statements (exceeds 4 allowed).
                              Open

                              func (p *Provisioner) uploadBlob(f *os.File, args *provisioners.ProvisionArgs, blob *storage.Blob) error {
                              
                                  var ps int64
                              
                                  if args.Force {
                              Severity: Major
                              Found in pkg/provisioners/azure/azure.go - About 35 mins to fix

                                Method CalVers.BestMatch has 5 return statements (exceeds 4 allowed).
                                Open

                                func (a CalVers) BestMatch(v CalVer) (CalVer, error) {
                                
                                    idx := sort.Search(a.Len(), func(arg1 int) bool {
                                        return v.LessEq(a[arg1])
                                    })
                                Severity: Major
                                Found in pkg/vkern/calver.go - About 35 mins to fix

                                  Function NewCLIRemoteManager has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func NewCLIRemoteManager(url, dir string, logger elog.View) (*CLIRemoteManager, error) {
                                      mgr := new(CLIRemoteManager)
                                      mgr.log = logger
                                      mgr.url = url
                                      mgr.dir = dir
                                  Severity: Major
                                  Found in pkg/vkern/cli.go - About 35 mins to fix

                                    Method Provisioner.Provision has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func (p *Provisioner) Provision(args *provisioners.ProvisionArgs) error {
                                        var err error
                                        var imageID *string
                                        p.args = *args
                                    
                                    
                                    Severity: Major
                                    Found in pkg/provisioners/amazon/amazon.go - About 35 mins to fix

                                      Method IO.readSuperblock has 5 return statements (exceeds 4 allowed).
                                      Open

                                      func (iio *IO) readSuperblock(index int) (*ext.Superblock, error) {
                                      
                                          entry, err := iio.GPTEntry(UTF16toString(vimg.RootPartitionName))
                                          if err != nil {
                                              return nil, err
                                      Severity: Major
                                      Found in pkg/vdecompiler/fs.go - About 35 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language