Sign upLogin

vorteil/vorteil

View on GitHub
Star

Showing 546 of 546 total issues

Method Virtualizer.Close has 7 return statements (exceeds 4 allowed).
Open

func (v *Virtualizer) Close(force bool) error {
    v.logger.Debugf("Deleting VM")
    if force && !(v.state == virtualizers.Ready) {
        err := v.ForceStop()
        if err != nil {
Severity: Major
Found in pkg/virtualizers/virtualbox/virtualizer.go - About 45 mins to fix

    Method Compiler.Compile has 7 return statements (exceeds 4 allowed).
    Open

    func (c *Compiler) Compile(ctx context.Context, w io.WriteSeeker) error {

    var err error

    err = c.writeSuperblockAndBGDT(ctx, w, 0)
    Severity: Major
    Found in pkg/ext4/compiler.go - About 45 mins to fix

      Method FixedWriter.writeFooter has 7 return statements (exceeds 4 allowed).
      Open

      func (w *FixedWriter) writeFooter() error {

    var err error
    _, err = w.Seek(0, io.SeekEnd)
    if err != nil {
      Severity: Major
      Found in pkg/vhd/fixed.go - About 45 mins to fix

        Function decompileImageRecursive has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func decompileImageRecursive(vorteilImage *vdecompiler.IO, report DecompileReport, symlinkCallbacks []func() error, ino int, rpath string, dpath string) (DecompileReport, []func() error, error) {
        Severity: Minor
        Found in pkg/imagetools/decompile.go - About 45 mins to fix

          Method Virtualizer.Bind has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (v *Virtualizer) Bind(args []string, i int, j int, protocol string, port virtualizers.RouteMap, networkType string) ([]string, string, bool, error) {
          Severity: Minor
          Found in pkg/virtualizers/virtualbox/virtualizer.go - About 45 mins to fix

            Method Virtualizer.initializeNetworkCards has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
            Open

            func (v *Virtualizer) initializeNetworkCards() ([]string, error) {
    v.logger.Debugf("Initializing Network Cards")
    var nicArgs string
    var err error
    var nr string
            Severity: Minor
            Found in pkg/virtualizers/qemu/virtualizer.go - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method ContainerConverter.createVCFG has 7 return statements (exceeds 4 allowed).
            Open

            func (cc *ContainerConverter) createVCFG(config v1.Config, targetDir string) error {

    if _, err := os.Stat(targetDir); err != nil {
        return fmt.Errorf("directory %s does not exist", targetDir)
    }
            Severity: Major
            Found in pkg/vconvert/vconvert.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if firstError == nil {
                            firstError = err
                        }
              Severity: Major
              Found in pkg/vkern/manager-remote.go - About 45 mins to fix

                Method importSharedObjectsOperation.loadLDPathsFromLinkerConfig has 7 return statements (exceeds 4 allowed).
                Open

                func (isoOp *importSharedObjectsOperation) loadLDPathsFromLinkerConfig(path string) error {
    if strings.Contains(path, "*") {
        return nil
    }
    data, err := ioutil.ReadFile(path)
                Severity: Major
                Found in pkg/vproj/import-so.go - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      } else if resp.HTTPResponse.StatusCode != http.StatusOK {
                        err = fmt.Errorf("error downloading %s: %v -- %s", resp.Request.URL(), resp.HTTPResponse.StatusCode, http.StatusText(resp.HTTPResponse.StatusCode))
                        if firstError == nil {
                            firstError = err
                        }
                  Severity: Major
                  Found in pkg/vkern/manager-remote.go - About 45 mins to fix

                    Function uploadPackage has 7 return statements (exceeds 4 allowed).
                    Open

                    func uploadPackage(url string, repo []string, token string, file *os.File) error {
    client := &http.Client{}

    stats, err := file.Stat()
    if err != nil {
                    Severity: Major
                    Found in pkg/cli/repositories.go - About 45 mins to fix

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                      func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
                      Severity: Major
                      Found in pkg/provisioners/amazon/amazon.go and 4 other locations - About 45 mins to fix
                      pkg/provisioners/azure/azure.go on lines 62..72
                      pkg/provisioners/google/google.go on lines 146..157
                      pkg/provisioners/nutanix/nutanix.go on lines 37..47
                      pkg/provisioners/vcenter/vcenter.go on lines 58..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 114.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                      func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
    err := p.Validate()
                      Severity: Major
                      Found in pkg/provisioners/vcenter/vcenter.go and 4 other locations - About 45 mins to fix
                      pkg/provisioners/amazon/amazon.go on lines 71..82
                      pkg/provisioners/azure/azure.go on lines 62..72
                      pkg/provisioners/google/google.go on lines 146..157
                      pkg/provisioners/nutanix/nutanix.go on lines 37..47

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 114.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                      func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
    err := p.Validate()
                      Severity: Major
                      Found in pkg/provisioners/azure/azure.go and 4 other locations - About 45 mins to fix
                      pkg/provisioners/amazon/amazon.go on lines 71..82
                      pkg/provisioners/google/google.go on lines 146..157
                      pkg/provisioners/nutanix/nutanix.go on lines 37..47
                      pkg/provisioners/vcenter/vcenter.go on lines 58..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 114.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                      func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
                      Severity: Major
                      Found in pkg/provisioners/google/google.go and 4 other locations - About 45 mins to fix
                      pkg/provisioners/amazon/amazon.go on lines 71..82
                      pkg/provisioners/azure/azure.go on lines 62..72
                      pkg/provisioners/nutanix/nutanix.go on lines 37..47
                      pkg/provisioners/vcenter/vcenter.go on lines 58..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 114.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 5 locations. Consider refactoring.
                      Open

                      func NewProvisioner(log elog.View, cfg *Config) (*Provisioner, error) {
    p := new(Provisioner)
    p.cfg = cfg
    p.log = log
    err := p.Validate()
                      Severity: Major
                      Found in pkg/provisioners/nutanix/nutanix.go and 4 other locations - About 45 mins to fix
                      pkg/provisioners/amazon/amazon.go on lines 71..82
                      pkg/provisioners/azure/azure.go on lines 62..72
                      pkg/provisioners/google/google.go on lines 146..157
                      pkg/provisioners/vcenter/vcenter.go on lines 58..68

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 114.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func Create(mgr *virtualizers.Manager, name string, headless bool, switchName string) error {
    c := new(Config)
    c.Headless = headless
    c.SwitchName = switchName
    err := mgr.CreateVirtualizer(name, VirtualizerID, c.Marshal())
                      Severity: Minor
                      Found in pkg/virtualizers/hyperv/allocator.go and 1 other location - About 40 mins to fix
                      pkg/virtualizers/vmware/allocator.go on lines 94..103

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 111.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func Create(mgr *virtualizers.Manager, name string, headless bool, networkType string) error {
    c := new(Config)
    c.Headless = headless
    c.NetworkType = networkType
    err := mgr.CreateVirtualizer(name, VirtualizerID, c.Marshal())
                      Severity: Minor
                      Found in pkg/virtualizers/vmware/allocator.go and 1 other location - About 40 mins to fix
                      pkg/virtualizers/hyperv/allocator.go on lines 106..115

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 111.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method ContainerConverter.localHandler has 6 return statements (exceeds 4 allowed).
                      Open

                      func (cc *ContainerConverter) localHandler(path string) error {

    img, err := tarball.ImageFromPath(path, nil)
    if err != nil {
        return err
                      Severity: Major
                      Found in pkg/vconvert/local.go - About 40 mins to fix

                        Function ReaderFromBuilder has 6 return statements (exceeds 4 allowed).
                        Open

                        func ReaderFromBuilder(b Builder) (Reader, error) {

    rdr := new(reader)
    rdr.closeFunc = b.Close
                        Severity: Major
                        Found in pkg/vpkg/package.go - About 40 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language