Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/ext4/super.go

Summary

Maintainability
B
6 hrs
Test Coverage

File super.go has 591 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package ext4

import (
    "bytes"
    "context"
Severity: Minor
Found in pkg/ext4/super.go - About 4 hrs to fix

    Method super.init has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *super) init(totalBlocks, inodesPerGroup int64, nodes *[]node) {
    s.timestamp = time.Now()
    s.layout.inodesPerGroup = inodesPerGroup
    s.layout.totalBlocks = totalBlocks
    s.layout.totalGroupDescriptors = totalGroupsAllowingForGrowth(divide(totalBlocks, BlocksPerGroup))
    Severity: Minor
    Found in pkg/ext4/super.go - About 1 hr to fix

      TODO found
      Open

              // TODO UUID
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      TODO found
      Open

              // TODO JournalUUID
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      TODO found
      Open

              // TODO JnlBackupType
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      TODO found
      Open

              // TODO MountOptions
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      TODO found
      Open

              // TODO DefaultMountOpts
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      TODO found
      Open

              // TODO HashSeed
      Severity: Minor
      Found in pkg/ext4/super.go by fixme

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (s *super) regionIsHole(begin, size int64) bool {

    first := begin / BlockSize
    end := begin + size
    last := (end - 1) / BlockSize
      Severity: Major
      Found in pkg/ext4/super.go and 1 other location - About 1 hr to fix
      pkg/ext/block-usage.go on lines 74..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported const SectorSize should have comment (or a comment on this block) or be unexported
      Open

          SectorSize          = 512
      Severity: Minor
      Found in pkg/ext4/super.go by golint

      exported const CompatDirPrealloc should have comment (or a comment on this block) or be unexported
      Open

          CompatDirPrealloc  = 0x1   // COMPAT_DIR_PREALLOC
      Severity: Minor
      Found in pkg/ext4/super.go by golint

      exported const Signature should have comment (or a comment on this block) or be unexported
      Open

          Signature    = 0xEF53
      Severity: Minor
      Found in pkg/ext4/super.go by golint

      exported const ROCompatSparseSuper should have comment (or a comment on this block) or be unexported
      Open

          ROCompatSparseSuper = 0x1 // RO_COMPAT_SPARSE_SUPER
      Severity: Minor
      Found in pkg/ext4/super.go by golint

      exported const IncompatFiletype should have comment (or a comment on this block) or be unexported
      Open

          IncompatFiletype   = 0x2    // INCOMPAT_FILETYPE
      Severity: Minor
      Found in pkg/ext4/super.go by golint

      There are no issues that match your filters.

      Category
      Status