vorteil/vorteil

View on GitHub
pkg/virtualizers/hyperv/virtualizer.go

Summary

Maintainability
A
3 hrs
Test Coverage
F
5%

Method operation.prepare has 6 return statements (exceeds 4 allowed).
Open

func (o *operation) prepare(args *virtualizers.PrepareArgs) {
    var returnErr error
    progress := o.logger.NewProgress("Preparing Hyper-v machine", "", 0)
    defer progress.Finish(false)
    o.updateStatus(fmt.Sprintf("Preparing hyperv files..."))
Severity: Major
Found in pkg/virtualizers/hyperv/virtualizer.go - About 40 mins to fix

    Method operation.setVMDetails has 5 return statements (exceeds 4 allowed).
    Open

    func (o *operation) setVMDetails(size string) error {
        // set vm memory
        cmd := exec.Command(virtualizers.Powershell, "Set-VMMemory", "-VMName", o.name, "-DynamicMemoryEnabled", "0", "-StartupBytes", size)
        output, err := o.execute(cmd)
        if err != nil {
    Severity: Major
    Found in pkg/virtualizers/hyperv/virtualizer.go - About 35 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (o *operation) finished(err error) {
          o.finishedLock.Lock()
          defer o.finishedLock.Unlock()
          if o.isFinished {
              return
      Severity: Major
      Found in pkg/virtualizers/hyperv/virtualizer.go and 4 other locations - About 1 hr to fix
      pkg/virtualizers/firecracker/util_linux.go on lines 256..273
      pkg/virtualizers/qemu/virtualizer.go on lines 128..145
      pkg/virtualizers/virtualbox/virtualizer.go on lines 294..312
      pkg/virtualizers/vmware/virtualizer.go on lines 388..405

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

      func (v *Virtualizer) Details() (string, string, string, []virtualizers.NetworkInterface, time.Time, *vcfg.VCFG, interface{}) {
          return v.name, v.pname, v.state, v.routes, v.created, v.config, v.source
      }
      Severity: Major
      Found in pkg/virtualizers/hyperv/virtualizer.go and 4 other locations - About 35 mins to fix
      pkg/virtualizers/firecracker/virtualizer_linux.go on lines 44..46
      pkg/virtualizers/qemu/virtualizer.go on lines 375..377
      pkg/virtualizers/virtualbox/virtualizer.go on lines 206..208
      pkg/virtualizers/vmware/virtualizer.go on lines 462..464

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (v *Virtualizer) Initialize(data []byte) error {
          c := new(Config)
          err := c.Unmarshal(data)
          if err != nil {
              return err
      Severity: Minor
      Found in pkg/virtualizers/hyperv/virtualizer.go and 1 other location - About 30 mins to fix
      pkg/virtualizers/vmware/virtualizer.go on lines 360..369

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status