Sign upLogin

vorteil/vorteil

View on GitHub
Star
pkg/vpkg/package.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function Load has 9 return statements (exceeds 4 allowed).
Open

func Load(r io.Reader) (Reader, error) {

    var err error

    hdr := new(header)
Severity: Major
Found in pkg/vpkg/package.go - About 55 mins to fix

    Method builder.Pack has 6 return statements (exceeds 4 allowed).
    Open

    func (b *builder) Pack(w io.Writer) error {

    var err error

    err = b.monitoring.preprocess(b)
    Severity: Major
    Found in pkg/vpkg/package.go - About 40 mins to fix

      Function ReaderFromBuilder has 6 return statements (exceeds 4 allowed).
      Open

      func ReaderFromBuilder(b Builder) (Reader, error) {

    rdr := new(reader)
    rdr.closeFunc = b.Close
      Severity: Major
      Found in pkg/vpkg/package.go - About 40 mins to fix

        Method builder.MergeVCFG has 5 return statements (exceeds 4 allowed).
        Open

        func (b *builder) MergeVCFG(cfg *vcfg.VCFG) error {

    v, err := vcfg.LoadFile(b.vcfg)
    if err != nil {
        return err
        Severity: Major
        Found in pkg/vpkg/package.go - About 35 mins to fix

          Function NewBuilderFromReader has 5 return statements (exceeds 4 allowed).
          Open

          func NewBuilderFromReader(rdr Reader) (Builder, error) {

    var err error
    b := NewBuilder()
    b.(*builder).closeFunc = rdr.Close
          Severity: Major
          Found in pkg/vpkg/package.go - About 35 mins to fix

            Method MonitoringOptions.preprocess has 5 return statements (exceeds 4 allowed).
            Open

            func (opts *MonitoringOptions) preprocess(b Builder) error {
    if opts.PreProcessCompleteCallback == nil {
        return nil
    }
            Severity: Major
            Found in pkg/vpkg/package.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  err = tree.Walk(func(path string, f vio.File) error {
        switch path {
        case vcfgPath:
            rdr.vcfg = f
        case iconPath:
              Severity: Minor
              Found in pkg/vpkg/package.go and 1 other location - About 40 mins to fix
              pkg/vpkg/package.go on lines 576..590

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  err := tree.Walk(func(path string, f vio.File) error {
        switch path {
        case vcfgPath:
            rdr.vcfg = f
        case iconPath:
              Severity: Minor
              Found in pkg/vpkg/package.go and 1 other location - About 40 mins to fix
              pkg/vpkg/package.go on lines 658..672

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              exported function Open should have comment or be unexported
              Open

              func Open(path string) (Reader, error) {
              Severity: Minor
              Found in pkg/vpkg/package.go by golint

              exported function ReaderFromBuilder should have comment or be unexported
              Open

              func ReaderFromBuilder(b Builder) (Reader, error) {
              Severity: Minor
              Found in pkg/vpkg/package.go by golint

              There are no issues that match your filters.

              Category
              Status