File xfs.go has 1127 lines of code (exceeds 500 allowed). Consider refactoring.

Open

package xfs

import (
    "bytes"
    "context"

Method compiler.writeAllocGroup has 304 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *compiler) writeAllocGroup(ctx context.Context, w io.WriteSeeker, ag int64) error {
    var err error

    allocGroupOffset := ag * c.blocksPerAllocGroup() * c.blockSize()
    _, err = w.Seek(allocGroupOffset, io.SeekStart)

Method precompiler.calculateMinimumSize has a Cognitive Complexity of 74 (exceeds 20 allowed). Consider refactoring.

Open

func (p *precompiler) calculateMinimumSize(ctx context.Context) error {

    var err error

    p.allocGroups = 1

• Read up
  Read up

Method compiler.writeAllocGroup has a Cognitive Complexity of 73 (exceeds 20 allowed). Consider refactoring.

Open

func (c *compiler) writeAllocGroup(ctx context.Context, w io.WriteSeeker, ag int64) error {
    var err error

    allocGroupOffset := ag * c.blocksPerAllocGroup() * c.blockSize()
    _, err = w.Seek(allocGroupOffset, io.SeekStart)

• Read up
  Read up

Method precompiler.calculateMinimumSize has 147 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (p *precompiler) calculateMinimumSize(ctx context.Context) error {

    var err error

    p.allocGroups = 1

Method compiler.popInode has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.

Open

func (c *compiler) popInode() io.Reader {

    n, more := <-c.nodes
    if !more {
        return nil

• Read up
  Read up

Method compiler.popInode has 104 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *compiler) popInode() io.Reader {

    n, more := <-c.nodes
    if !more {
        return nil

Method compiler.writeAllocGroup has 34 return statements (exceeds 4 allowed).

Open

func (c *compiler) writeAllocGroup(ctx context.Context, w io.WriteSeeker, ag int64) error {
    var err error

    allocGroupOffset := ag * c.blocksPerAllocGroup() * c.blockSize()
    _, err = w.Seek(allocGroupOffset, io.SeekStart)

Method compiler.precompile has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.

Open

func (c *compiler) precompile(ctx context.Context) error {

    var err error

    // alloc group sizes

• Read up
  Read up

Method compiler.buildBitmap has 58 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func (c *compiler) buildBitmap() {
    c.allocGroupFreeBlocks = make([]int64, c.allocGroups)
    c.allocGroupFreeInodes = make([]int64, c.allocGroups)

    for i := int64(0); i < c.allocGroups; i++ {

Avoid deeply nested control flow statements.

Open

                    if lfll > p.directoryBlockSize() {
                        // directory must be stored in node form
                        x = ddb // data blocks
                        x += 1  // node block

Avoid deeply nested control flow statements.

Open

            if err != nil {
                panic(err) // NOTE: this is only supported if the filetree supports looking up and caching this value in advance, which should make errors impossible
            }

Method precompiler.calculateMinimumSize has 6 return statements (exceeds 4 allowed).

Open

func (p *precompiler) calculateMinimumSize(ctx context.Context) error {

    var err error

    p.allocGroups = 1

Method precompiler.setBlockSize has 5 return statements (exceeds 4 allowed).

Open

func (p *precompiler) setBlockSize(size int64) error {

    if size == 0 {
        p.exponents.blockSize = 12 // 4 KiB
        return nil

Method compiler.buildBitmap has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.

Open

func (c *compiler) buildBitmap() {
    c.allocGroupFreeBlocks = make([]int64, c.allocGroups)
    c.allocGroupFreeInodes = make([]int64, c.allocGroups)

    for i := int64(0); i < c.allocGroups; i++ {

• Read up
  Read up

Method precompiler.Precompile has 5 return statements (exceeds 4 allowed).

Open

func (p *precompiler) Precompile(ctx context.Context, fsSize int64) (*compiler, error) {

    var err error

    c := &compiler{

TODO found

Open

            // TODO: var ln int64 // length (node form)

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

    // distribute nodes amongst alloc groups TODO: see if files can be spread out better amongst the alloc groups

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

            panic(errors.New("super nested extents not yet supported")) // TODO

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

        // TODO: improve performance here by treating uint64s instead of bits

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

    c.nodes = make(chan *vio.TreeNode) // TODO: close this safely

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

        recHeader.CycleData[0] = 0xB0C0D0D0 // TODO: figure out what this is supposed to mean.

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

            // TODO: check this (I'm suspicious of the quality of my work when I wrote it)

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

            // TODO: does this work?

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

        Count:     uint32(c.inodesPerAllocGroup()), // TODO: - c.allocGroupFreeInodes[ag]), -- is it meant to be this way?

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

        // ExtSize TODO: is this necessary?

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

                // TODO: shuffle entries to optimize used space

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

    c.data = make(chan *vio.TreeNode)  // TODO: close this safely

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

func (c *constants) inodeBlocksPerAllocGroup() int64 { // TODO: unit test if it's possible to get an odd number out of this (I'm suspicious...)

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

            Unknown:       0x6E55, // TODO: Figure out what this is supposed to mean.

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        } else if n.File.IsSymlink() {
            // TODO: does this work?
            _ = c.computeNodeExtents(n.NodeSequenceNumber, &dataRange{blocks: c.dataReaderBlocksRemaining}) // called here to ensure things are computed in order
            c.dataReader = io.MultiReader(n.File, io.LimitReader(vio.Zeroes, c.dataReaderBlocksRemaining*c.blockSize()-int64(n.File.Size())))
        } else {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        } else {
            _ = c.computeNodeExtents(n.NodeSequenceNumber, &dataRange{blocks: c.dataReaderBlocksRemaining}) // called here to ensure things are computed in order
            c.dataReader = io.MultiReader(n.File, io.LimitReader(vio.Zeroes, c.dataReaderBlocksRemaining*c.blockSize()-int64(n.File.Size())))
        }

• Read up
  Read up

Your code does not pass gofmt in 1 place. Go fmt your code!

Open

package xfs

• Exclude checks
  • Disable engine
  • Disable check

should replace x += 1 with x++

Open

                        x += 1  // node block

• Exclude checks
  • Disable engine
  • Disable check