server/pkg/publisher/publisher.go

Summary

Maintainability
B
7 hrs
Test Coverage
F
1%

Method Publisher.setRepositoryKeys has 9 return statements (exceeds 4 allowed).
Open

func (publisher *Publisher) setRepositoryKeys(ctx context.Context, storage logical.Storage, repository RepositoryInterface, opts setRepositoryKeysOptions) error {
    entry, err := storage.Get(ctx, storageKeyTufRepositoryKeys)
    if err != nil {
        return fmt.Errorf("error getting storage private keys json entry by the key %q: %w", storageKeyTufRepositoryKeys, err)
    }
Severity: Major
Found in server/pkg/publisher/publisher.go - About 55 mins to fix

    Method Publisher.fetchPGPSigningKey has 8 return statements (exceeds 4 allowed).
    Open

    func (publisher *Publisher) fetchPGPSigningKey(ctx context.Context, storage logical.Storage, initializeKey bool) (*pgp.RSASigningKey, error) {
        entry, err := storage.Get(ctx, storageKeyPGPSigningKey)
        if err != nil {
            return nil, fmt.Errorf("error getting storage pgp signing key json entry by storage key %q: %w", storageKeyPGPSigningKey, err)
        }
    Severity: Major
    Found in server/pkg/publisher/publisher.go - About 50 mins to fix

      Method Publisher.StageReleaseTarget has 7 return statements (exceeds 4 allowed).
      Open

      func (publisher *Publisher) StageReleaseTarget(ctx context.Context, repository RepositoryInterface, releaseName, releaseFilePath string, data io.Reader) error {
          publisher.mu.Lock()
          defer publisher.mu.Unlock()
      
          pathParts := SplitFilepath(filepath.Clean(releaseFilePath))
      Severity: Major
      Found in server/pkg/publisher/publisher.go - About 45 mins to fix

        Method Publisher.GetRepository has 6 return statements (exceeds 4 allowed).
        Open

        func (publisher *Publisher) GetRepository(ctx context.Context, storage logical.Storage, options RepositoryOptions) (RepositoryInterface, error) {
            publisher.mu.Lock()
            defer publisher.mu.Unlock()
        
            awsConfig := &aws.Config{
        Severity: Major
        Found in server/pkg/publisher/publisher.go - About 40 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func SplitFilepath(path string) (result []string) {
              path = filepath.FromSlash(path)
              separator := os.PathSeparator
          
              idx := 0
          Severity: Major
          Found in server/pkg/publisher/publisher.go and 1 other location - About 3 hrs to fix
          server/pkg/gendocs/util.go on lines 10..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 258.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          func indexRuneWithEscaping(s string, r rune) int {
              end := strings.IndexRune(s, r)
              if end == -1 {
                  return -1
              }
          Severity: Minor
          Found in server/pkg/publisher/publisher.go and 1 other location - About 40 mins to fix
          server/pkg/gendocs/util.go on lines 57..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status