wikimedia/mediawiki-core

View on GitHub

Showing 11,498 of 11,498 total issues

File EnhancedChangesList.php has 592 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use MediaWiki\Context\IContextSource;
use MediaWiki\Html\Html;
use MediaWiki\Html\TemplateParser;
Severity: Major
Found in includes/changes/EnhancedChangesList.php - About 1 day to fix

    File ChangeTagsStore.php has 591 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * This program is free software; you can redistribute it and/or modify
     * it under the terms of the GNU General Public License as published by
     * the Free Software Foundation; either version 2 of the License, or
    Severity: Major
    Found in includes/changetags/ChangeTagsStore.php - About 1 day to fix

      DifferenceEngine has 69 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class DifferenceEngine extends ContextSource {
      
          use DeprecationHelper;
      
          /**
      Severity: Major
      Found in includes/diff/DifferenceEngine.php - About 1 day to fix

        Skin has 69 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class Skin extends ContextSource {
            use ProtectedHookAccessorTrait;
        
            /**
             * @var array link options used in Skin::makeLink. Can be set by skin option `link`.
        Severity: Major
        Found in includes/skins/Skin.php - About 1 day to fix

          Message has 69 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Message implements Stringable, MessageSpecifier, Serializable {
              /** Use message text as-is */
              public const FORMAT_PLAIN = 'plain';
              /** Use normal wikitext -> HTML parsing (the result will be wrapped in a block-level HTML tag) */
              public const FORMAT_BLOCK_PARSE = 'block-parse';
          Severity: Major
          Found in includes/Message/Message.php - About 1 day to fix

            File jquery.ui.draggable.js has 590 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*!
             * jQuery UI Draggable 1.9.2
             * http://jqueryui.com
             *
             * Copyright 2012 jQuery Foundation and other contributors
            Severity: Major
            Found in resources/lib/jquery.ui/jquery.ui.draggable.js - About 1 day to fix

              File ApiEditPage.php has 590 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              /**
               * Copyright © 2007 Iker Labarga "<Firstname><Lastname>@gmail.com"
               *
               * This program is free software; you can redistribute it and/or modify
              Severity: Major
              Found in includes/api/ApiEditPage.php - About 1 day to fix

                File SpecialSearch.php has 588 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /**
                 * Copyright © 2004 Brooke Vibber <bvibber@wikimedia.org>
                 *
                 * This program is free software; you can redistribute it and/or modify
                Severity: Major
                Found in includes/specials/SpecialSearch.php - About 1 day to fix

                  Function checkArray has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function checkArray( array $extDependencies ) {
                          $errors = [];
                          foreach ( $extDependencies as $extension => $dependencies ) {
                              foreach ( $dependencies as $dependencyType => $values ) {
                                  switch ( $dependencyType ) {
                  Severity: Minor
                  Found in includes/registration/VersionChecker.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function execute has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function execute() {
                          // Parse some parameters
                          $this->params = $this->extractRequestParams();
                  
                          $prop = array_fill_keys( $this->params['prop'], true );
                  Severity: Minor
                  Found in includes/api/ApiQueryUserContribs.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File jquery.ui.accordion.js has 586 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*!
                   * jQuery UI Accordion 1.9.2
                   * http://jqueryui.com
                   *
                   * Copyright 2012 jQuery Foundation and other contributors
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 day to fix

                    File MediumSpecificBagOStuff.php has 586 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /**
                     * Storage medium specific cache for storing items.
                     *
                     * This program is free software; you can redistribute it and/or modify
                    Severity: Major
                    Found in includes/libs/objectcache/MediumSpecificBagOStuff.php - About 1 day to fix

                      File DBConnRef.php has 586 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      namespace Wikimedia\Rdbms;
                      
                      use InvalidArgumentException;
                      Severity: Major
                      Found in includes/libs/rdbms/database/DBConnRef.php - About 1 day to fix

                        Function makeApi has 251 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function makeApi(sinon) {
                                sinon.wrapMethod = function wrapMethod(object, property, method) {
                                    if (!object) {
                                        throw new TypeError("Should wrap property of object");
                                    }
                        Severity: Major
                        Found in resources/lib/sinonjs/sinon.js - About 1 day to fix

                          Maintenance has 68 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          abstract class Maintenance {
                              /**
                               * Constants for DB access type
                               * @see Maintenance::getDbType()
                               */
                          Severity: Major
                          Found in maintenance/includes/Maintenance.php - About 1 day to fix

                            Method execute has 250 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function execute() {
                                    $services = $this->getServiceContainer();
                                    $permissionManager = $services->getPermissionManager();
                            
                                    $found = 0;
                            Severity: Major
                            Found in maintenance/importImages.php - About 1 day to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          case "genitive":
                                              if ( in_array( $wordEnding, $unvoicedPhonemes ) ) {
                                                  if ( in_array( $wordLastVowel, $roundFrontVowels ) ) {
                                                      $word .= "түң";
                                                  } elseif ( in_array( $wordLastVowel, $unroundFrontVowels ) ) {
                              Severity: Major
                              Found in includes/languages/LanguageTyv.php and 1 other location - About 1 day to fix
                              includes/languages/LanguageTyv.php on lines 119..151

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 286.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          case "accusative":
                                              if ( in_array( $wordEnding, $unvoicedPhonemes ) ) {
                                                  if ( in_array( $wordLastVowel, $roundFrontVowels ) ) {
                                                      $word .= "тү";
                                                  } elseif ( in_array( $wordLastVowel, $unroundFrontVowels ) ) {
                              Severity: Major
                              Found in includes/languages/LanguageTyv.php and 1 other location - About 1 day to fix
                              includes/languages/LanguageTyv.php on lines 69..101

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 286.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function loadParamInfo has 249 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  ApiSandbox.PageLayout.prototype.loadParamInfo = function () {
                                      var dynamicFieldset, dynamicParamNameWidget,
                                          layout = this,
                                          removeDynamicParamWidget = function ( name, item ) {
                                              dynamicFieldset.removeItems( [ item ] );
                              Severity: Major
                              Found in resources/src/mediawiki.special.apisandbox/apisandbox.js - About 1 day to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                      createVNode(_component_cdx_menu, mergeProps({
                                        id: _ctx.menuId,
                                        ref: "menu",
                                        selected: _ctx.modelWrapper,
                                        "onUpdate:selected": _cache[3] || (_cache[3] = ($event) => _ctx.modelWrapper = $event),
                                Severity: Major
                                Found in resources/lib/codex/codex.js and 1 other location - About 1 day to fix
                                resources/lib/codex/codex.js on lines 6310..6329

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 234.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language