wikimedia/mediawiki-core

Method dfnCheckInterval has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function dfnCheckInterval( $start = null, $end = null, $batchSize = 100 ) {
        $dbw = $this->getPrimaryDB();
        $dbr = $this->getDB( DB_REPLICA, [ 'vslow' ] );

        $linksTables = [

Method fetchMessageInfo has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function fetchMessageInfo( $langCode, array &$messageInfo ) {
        $services = $this->getServiceContainer();
        $contLang = $services->getContentLanguage();
        if ( $langCode ) {
            $this->output( "\n... fetching message info for language: $langCode" );

Method doAllPages has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function doAllPages() {
        $dbr = MediaWikiServices::getInstance()->getConnectionProvider()->getReplicaDatabase();
        $i = 0;
        $startId = 0;
        if ( $this->noCount ) {

Method updateTo2 has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function updateTo2( &$json ) {
        if ( isset( $json['config'] ) ) {
            $config = $json['config'];
            $json['config'] = [];
            if ( isset( $config['_prefix'] ) ) {

Consider simplifying this complex logical expression.

Open

            if ( date.getTime() < -62167219200000 || date.getTime() > 253402300799999 ||
                date.getUTCFullYear() !== +m[ 1 ] ||
                date.getUTCMonth() + 1 !== +m[ 2 ] ||
                date.getUTCDate() !== +m[ 3 ] ||
                date.getUTCHours() !== +m[ 4 ] ||

Consider simplifying this complex logical expression.

Open

        if (
            title.indexOf( '.' ) !== -1 && (
                title === '.' || title === '..' ||
                title.indexOf( './' ) === 0 ||
                title.indexOf( '../' ) === 0 ||

Consider simplifying this complex logical expression.

Open

        if ( ( ( $target[0].id != $.datepicker._mainDivId &&
                $target.parents('#' + $.datepicker._mainDivId).length == 0 &&
                !$target.hasClass($.datepicker.markerClassName) &&
                !$target.closest("." + $.datepicker._triggerClass).length &&
                $.datepicker._datepickerShowing && !($.datepicker._inDialog && $.blockUI) ) ) ||

Consider simplifying this complex logical expression.

Open

        if(!(/^(document|window|parent)$/).test(o.containment)) {
            var ce = $(o.containment)[0];
            var co = $(o.containment).offset();
            var over = ($(ce).css("overflow") != 'hidden');

Consider simplifying this complex logical expression.

Open

        if (this.floating && horizontalDirection) {
            return ((horizontalDirection == "right" && isOverRightHalf) || (horizontalDirection == "left" && !isOverRightHalf));
        } else {
            return verticalDirection && ((verticalDirection == "down" && isOverBottomHalf) || (verticalDirection == "up" && !isOverBottomHalf));
        }

Consider simplifying this complex logical expression.

Open

                    if ( $userOptionsLookup->getOption( $watchingUser, 'enotifwatchlistpages' )
                        && ( !$minorEdit || $userOptionsLookup->getOption( $watchingUser, 'enotifminoredits' ) )
                        && $watchingUser->isEmailConfirmed()
                        && $watchingUser->getId() != $userTalkId
                        && !in_array( $watchingUser->getName(),

Consider simplifying this complex logical expression.

Open

        if ( $delta & 1 ) {
            for ( $d = 0; $d <= $limit; ++$d ) {
                $start_diag = max( $value_to_add_forward + $start_forward, -$d );
                $end_diag = min( $end_forward, $d );
                $value_to_add_forward = 1 - $value_to_add_forward;

Consider simplifying this complex logical expression.

Open

        if (
            !$this->mOldRevisionRecord || !$this->mNewRevisionRecord
            || !$this->mOldPage || !$this->mNewPage
            || !$this->mOldPage->equals( $this->mNewPage )
            || $this->mOldRevisionRecord->getId() === null

Consider simplifying this complex logical expression.

Open

        if (
            str_contains( $dbkey, '.' ) &&
            (
                $dbkey === '.' || $dbkey === '..' ||
                str_starts_with( $dbkey, './' ) ||

Consider simplifying this complex logical expression.

Open

            if ( $customised !== $this->custom &&
                ( ( $asc && ( $key < $offset || !$offset ) ) || ( !$asc && $key > $offset ) ) &&
                ( ( $this->prefix && preg_match( $this->prefix, $key ) ) || $this->prefix === false )
            ) {
                $actual = $this->msg( $key )->inLanguage( $this->lang )->plain();

Consider simplifying this complex logical expression.

Open

        if ( isset( self::METADATA_ELEMENTS[$elementName] )
            && !self::isTableOfContentsMarker( $element )
        ) {
            // The element is a metadata element, that we allow to appear in
            // both inline and block contexts.

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static function newFromIDs( $ids ) {
        $ids = array_map( 'intval', (array)$ids ); // paranoia
        if ( !$ids ) {
            // Database::select() doesn't like empty arrays
            return new ArrayIterator( [] );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    private function getTargetAndType( ?string $par, WebRequest $request ) {
        $possibleTargets = [
            $request->getVal( 'wpTarget', null ),
            $par,
            $request->getVal( 'ip', null ),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public static function newFromNames( $names ) {
        $names = array_map( 'strval', (array)$names ); // paranoia
        if ( !$names ) {
            // Database::select() doesn't like empty arrays
            return new ArrayIterator( [] );

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ( isset( $settings[self::PARAM_MAX_CHARS] ) && $len > $settings[self::PARAM_MAX_CHARS] ) {
            $this->failure(
                $this->failureMessage( 'maxchars', [
                    'maxbytes' => $settings[self::PARAM_MAX_BYTES] ?? null,
                    'maxchars' => $settings[self::PARAM_MAX_CHARS] ?? null,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    protected function clearTempAccountCreationThrottle( string $ip ): void {
        $this->output( 'Clearing temp account creation throttle...' );

        $tempAccountCreationThrottle = $this->getConfig()->get( MainConfigNames::TempAccountCreationThrottle );
        if ( !$tempAccountCreationThrottle ) {

• Read up
  Read up