Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

Function execute has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $userName = $this->getOption( 'user', false );
        $summary = $this->getOption( 'summary', 'Imported from text file' );
        $useTimestamp = $this->hasOption( 'use-timestamp' );
        $rc = $this->hasOption( 'rc' );
Severity: Minor
Found in maintenance/importTextFiles.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ProtectionForm.php has 454 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Page protection
 *
 * Copyright © 2005 Brooke Vibber <bvibber@wikimedia.org>
Severity: Minor
Found in includes/page/ProtectionForm.php - About 6 hrs to fix

    File FilterGroup.js has 452 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const FilterItem = require( './FilterItem.js' ),
    utils = require( '../utils.js' );

/**
 * View model for a filter group.
    Severity: Minor
    Found in resources/src/mediawiki.rcfilters/dm/FilterGroup.js - About 6 hrs to fix

      Article has 49 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Article implements Page {
    use ProtectedHookAccessorTrait;
    use NonSerializableTrait;

    /**
      Severity: Minor
      Found in includes/page/Article.php - About 6 hrs to fix

        Module has 49 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class Module implements LoggerAwareInterface {
    /** @var Config */
    protected $config;
    /** @var LoggerInterface */
    protected $logger;
        Severity: Minor
        Found in includes/ResourceLoader/Module.php - About 6 hrs to fix

          LanguageConverter has 49 functions (exceeds 20 allowed). Consider refactoring.
          Open

          abstract class LanguageConverter implements ILanguageConverter {
    use DeprecationHelper;

    /**
     * languages supporting variants
          Severity: Minor
          Found in includes/language/LanguageConverter.php - About 6 hrs to fix

            Method convertGrammar has 170 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function convertGrammar( $word, $case ) {
        $grammarForms =
            MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::GrammarForms );
        if ( isset( $grammarForms['tyv'][$case][$word] ) ) {
            return $grammarForms['tyv'][$case][$word];
            Severity: Major
            Found in includes/languages/LanguageTyv.php - About 6 hrs to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              class TitleArrayFromResult implements Countable, Iterator {
    /** @var IResultWrapper */
    public $res;

    /** @var int */
              Severity: Major
              Found in includes/title/TitleArrayFromResult.php and 1 other location - About 6 hrs to fix
              includes/user/UserArrayFromResult.php on lines 29..93

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 220.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              class UserArrayFromResult extends UserArray implements Countable {
    /** @var IResultWrapper */
    public $res;

    /** @var int */
              Severity: Major
              Found in includes/user/UserArrayFromResult.php and 1 other location - About 6 hrs to fix
              includes/title/TitleArrayFromResult.php on lines 38..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 220.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File HtmlInputTransformHelper.php has 449 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
              Severity: Minor
              Found in includes/Rest/Handler/Helper/HtmlInputTransformHelper.php - About 6 hrs to fix

                Function autoCreateUser has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function autoCreateUser(
        User $user,
        $source,
        $login = true,
        $log = true,
                Severity: Minor
                Found in includes/auth/AuthManager.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function selectSQLText has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function selectSQLText(
        $tables, $vars, $conds = '', $fname = __METHOD__, $options = [], $join_conds = []
    ) {
        if ( !is_array( $tables ) ) {
            if ( $tables === '' || $tables === null || $tables === false ) {
                Severity: Minor
                Found in includes/libs/rdbms/platform/SQLPlatform.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parse has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function parse( $variant = null ) {
        if ( !$variant ) {
            $variant = $this->mConverter->getPreferredVariant();
        }
                Severity: Minor
                Found in includes/language/ConverterRule.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function run( $resultPageSet = null ) {
        $params = $this->extractRequestParams();
        $db = $this->getDB();

        $query = $params['query'];
                Severity: Minor
                Found in includes/api/ApiQueryExtLinksUsage.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function output has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function output( $return = false ) {
        if ( $this->mDoNothing ) {
            return $return ? '' : null;
        }
                Severity: Minor
                Found in includes/Output/OutputPage.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function execute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function execute() {
        $dbw = $this->getPrimaryDB();
        $config = $this->getConfig();
        $specialPageFactory = $this->getServiceContainer()->getSpecialPageFactory();
                Severity: Minor
                Found in maintenance/updateSpecialPages.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addStoreToDevtools has 168 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  function addStoreToDevtools(app, store) {
      if (!componentStateTypes.includes(getStoreType(store.$id))) {
          componentStateTypes.push(getStoreType(store.$id));
      }
      setupDevtoolsPlugin({
                Severity: Major
                Found in resources/lib/pinia/pinia.iife.js - About 6 hrs to fix

                  Function registerPiniaDevtools has 168 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function registerPiniaDevtools(app, pinia) {
      setupDevtoolsPlugin({
          id: 'dev.esm.pinia',
          label: 'Pinia 🍍',
          logo: 'https://pinia.vuejs.org/logo.svg',
                  Severity: Major
                  Found in resources/lib/pinia/pinia.iife.js - About 6 hrs to fix

                    Method getForm has 168 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function getForm( array $pagerOptions ) {
        if ( $this->including() ) {
            // Do not show a form when special page is included in wikitext
            return '';
        }
                    Severity: Major
                    Found in includes/specialpage/ContributionsSpecialPage.php - About 6 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          _over: function(event) {

        var draggable = $.ui.ddmanager.current;
        if (!draggable || (draggable.currentItem || draggable.element)[0] == this.element[0]) return; // Bail if draggable and droppable are same element
                      Severity: Major
                      Found in resources/lib/jquery.ui/jquery.ui.droppable.js and 1 other location - About 6 hrs to fix
                      resources/lib/jquery.ui/jquery.ui.droppable.js on lines 94..104

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 169.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language