Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

AuthManager has 47 functions (exceeds 20 allowed). Consider refactoring.
Open

class AuthManager implements LoggerAwareInterface {
    /**
     * @internal
     * Key in the user's session data for storing login state.
     */
Severity: Minor
Found in includes/auth/AuthManager.php - About 6 hrs to fix

    DatabaseSqlite has 47 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DatabaseSqlite extends Database {
    /** @var string|null Directory for SQLite database files listed under their DB name */
    protected $dbDir;
    /** @var string|null Explicit path for the SQLite database file */
    protected $dbPath;
    Severity: Minor
    Found in includes/libs/rdbms/database/DatabaseSqlite.php - About 6 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          width: function() {
        var scrollWidth,
            offsetWidth;
        // handle IE
        if ( $.ui.ie ) {
      Severity: Major
      Found in resources/lib/jquery.ui/jquery.ui.dialog.js and 1 other location - About 6 hrs to fix
      resources/lib/jquery.ui/jquery.ui.dialog.js on lines 778..801

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          height: function() {
        var scrollHeight,
            offsetHeight;
        // handle IE
        if ( $.ui.ie ) {
      Severity: Major
      Found in resources/lib/jquery.ui/jquery.ui.dialog.js and 1 other location - About 6 hrs to fix
      resources/lib/jquery.ui/jquery.ui.dialog.js on lines 803..826

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function adjustComponentInternal has 162 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          mw.widgets.datetime.DiscordianDateTimeFormatter.prototype.adjustComponentInternal = function ( components, component, delta, mode ) {
        let i, min, max, range, next, preTib, postTib, wasTib;

        if ( delta === 0 ) {
            return components;
      Severity: Major
      Found in resources/src/mediawiki.widgets.datetime/DiscordianDateTimeFormatter.js - About 6 hrs to fix

        Function MwRcfiltersUiFilterTagMultiselectWidget has 162 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const FilterTagMultiselectWidget = function MwRcfiltersUiFilterTagMultiselectWidget( controller, model, savedQueriesModel, config ) {
    const title = new OO.ui.LabelWidget( {
            label: mw.msg( 'rcfilters-activefilters' ),
            classes: [ 'mw-rcfilters-ui-filterTagMultiselectWidget-wrapper-content-title' ]
        } ),
        Severity: Major
        Found in resources/src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js - About 6 hrs to fix

          Method buildForm has 162 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function buildForm() {
        $this->mOut->enableOOUI();
        $out = '';
        $fields = [];
        if ( !$this->disabled ) {
          Severity: Major
          Found in includes/page/ProtectionForm.php - About 6 hrs to fix

            Method checkSvgScriptCallback has 162 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function checkSvgScriptCallback( $element, $attribs, $data = null ) {
        [ $namespace, $strippedElement ] = self::splitXmlNamespace( $element );

        // We specifically don't include:
        // http://www.w3.org/1999/xhtml (T62771)
            Severity: Major
            Found in includes/upload/UploadBase.php - About 6 hrs to fix

              Function position has 161 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              $.fn.position = function( options ) {
    if ( !options || !options.of ) {
        return _position.apply( this, arguments );
    }
              Severity: Major
              Found in resources/lib/jquery.ui/jquery.ui.position.js - About 6 hrs to fix

                File ApiQueryAllDeletedRevisions.php has 435 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
/**
 * Copyright © 2014 Wikimedia Foundation and contributors
 *
 * Heavily based on ApiQueryDeletedrevs,
                Severity: Minor
                Found in includes/api/ApiQueryAllDeletedRevisions.php - About 6 hrs to fix

                  Method handleTables has 161 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function handleTables( $text ) {
        $lines = StringUtils::explode( "\n", $text );
        $out = '';
        $td_history = []; # Is currently a td tag open?
        $last_tag_history = []; # Save history of last lag activated (td, th or caption)
                  Severity: Major
                  Found in includes/parser/Parser.php - About 6 hrs to fix

                    Function getContentObject has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function getContentObject( $defaultContent = null ) {
        $services = MediaWikiServices::getInstance();
        $request = $this->context->getRequest();

        $content = false;
                    Severity: Minor
                    Found in includes/editpage/EditPage.php - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function shiftBoundaries has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function shiftBoundaries( array $lines, array &$changed, array $other_changed ) {
        $i = 0;
        $j = 0;

        assert( count( $lines ) == count( $changed ) );
                    Severity: Minor
                    Found in includes/libs/Diff/DiffEngine.php - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function selectUploadModule has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function selectUploadModule() {
        // chunk or one and only one of the following parameters is needed
        if ( !$this->mParams['chunk'] ) {
            $this->requireOnlyOneParameter( $this->mParams,
                'filekey', 'file', 'url' );
                    Severity: Minor
                    Found in includes/api/ApiUpload.php - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getText has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function getText( $id, $model = null, $format = null, $expSize = null ) {
        if ( !$this->isValidTextId( $id ) ) {
            $msg = "Skipping bad text id " . $id . " of revision " . $this->thisRev;
            $this->progress( $msg );
            return '';
                    Severity: Minor
                    Found in maintenance/includes/TextPassDumper.php - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File SkinModule.php has 434 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
                    Severity: Minor
                    Found in includes/ResourceLoader/SkinModule.php - About 6 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          _getRelativeOffset: function() {

        if(this.cssPosition == "relative") {
            var p = this.element.position();
            return {
                      Severity: Major
                      Found in resources/lib/jquery.ui/jquery.ui.draggable.js and 1 other location - About 6 hrs to fix
                      resources/lib/jquery.ui/jquery.ui.sortable.js on lines 844..856

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 163.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          _getRelativeOffset: function() {

        if(this.cssPosition == "relative") {
            var p = this.currentItem.position();
            return {
                      Severity: Major
                      Found in resources/lib/jquery.ui/jquery.ui.sortable.js and 1 other location - About 6 hrs to fix
                      resources/lib/jquery.ui/jquery.ui.draggable.js on lines 335..347

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 163.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      File BlockUser.php has 433 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
                      Severity: Minor
                      Found in includes/block/BlockUser.php - About 6 hrs to fix

                        File IndexPager.php has 432 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
                        Severity: Minor
                        Found in includes/pager/IndexPager.php - About 6 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language