Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,545 of 11,545 total issues

Function computePosition$1 has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

const computePosition$1 = (reference, floating, config) => __async(void 0, null, function* () {
  const {
    placement = "bottom",
    strategy = "absolute",
    middleware = [],
Severity: Minor
Found in resources/lib/codex/codex.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkReadPermissions has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    private function checkReadPermissions(
        $action,
        User $user,
        PermissionStatus $status,
        $rigor,
Severity: Minor
Found in includes/Permissions/PermissionManager.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setVisibility has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function setVisibility( array $params ) {
        $status = Status::newGood();

        $bitPars = $params['value'];
        $comment = $params['comment'];
Severity: Minor
Found in includes/revisiondelete/RevDelList.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handlePage has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    private function handlePage() {
        // Handle page data.
        $this->debug( "Enter page handler." );
        $pageInfo = [ 'revisionCount' => 0, 'successfulRevisionCount' => 0 ];
Severity: Minor
Found in includes/import/WikiImporter.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sourceStream has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function sourceStream(
        $fp,
        callable $lineCallback = null,
        callable $resultCallback = null,
        $fname = __METHOD__,
Severity: Minor
Found in includes/libs/rdbms/database/Database.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLanguages has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function getLanguages() {
        if ( $this->getConfig()->get( MainConfigNames::HideInterlanguageLinks ) ) {
            return [];
        }
        if ( $this->languageLinks === null ) {
Severity: Minor
Found in includes/skins/Skin.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function expand has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function expand( string $url, $defaultProto = PROTO_FALLBACK ): ?string {
        if ( $defaultProto === PROTO_CANONICAL ) {
            $serverUrl = $this->canonicalServer;
        } elseif ( $defaultProto === PROTO_INTERNAL ) {
            $serverUrl = $this->internalServer;
Severity: Minor
Found in includes/utils/UrlUtils.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function formatTimePeriod has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function formatTimePeriod( $seconds, $format = [] ) {
        if ( !is_array( $format ) ) {
            $format = [ 'avoid' => $format ]; // For backwards compatibility
        }
        if ( !isset( $format['avoid'] ) ) {
Severity: Minor
Found in includes/language/Language.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doTransform has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function doTransform( $image, $dstPath, $dstUrl, $params, $flags = 0 ) {
        if ( !$this->normaliseParams( $image, $params ) ) {
            return new TransformParameterError( $params );
        }
Severity: Minor
Found in includes/media/TransformationalImageHandler.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $params = $this->extractRequestParams();
        $done = [];
        foreach ( $params['prop'] as $p ) {
            switch ( $p ) {
Severity: Minor
Found in includes/api/ApiQuerySiteinfo.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveUserGroups has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    protected function saveUserGroups( string $reason, UserIdentity $user ) {
        if ( $this->userNameUtils->isTemp( $user->getName() ) ) {
            return Status::newFatal( 'userrights-no-tempuser' );
        }
Severity: Minor
Found in includes/specials/SpecialUserRights.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseQuery has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseQuery( $filteredText, $fulltext ) {
        $lc = $this->legalSearchChars( self::CHARS_NO_SYNTAX ); // Minus syntax chars (" and *)
        $searchon = '';
        $this->searchTerms = [];
Severity: Minor
Found in includes/search/SearchMySQL.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $this->init();

        $showWiki = $this->getOption( 'show-wiki' );
        $wikiId = WikiMap::getCurrentWikiId();
Severity: Minor
Found in maintenance/grep.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function purgeFromLogType has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    protected function purgeFromLogType( $type ) {
        $repo = $this->getServiceContainer()->getRepoGroup()->getLocalRepo();
        $dbr = $this->getReplicaDB();

        foreach ( self::$typeMappings[$type] as $logType => $logActions ) {
Severity: Minor
Found in maintenance/purgeChangedFiles.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        if ( !$this->enabled ) {
            $this->fatalError( "Nothing to do -- \$wgUseFileCache is disabled." );
        }
Severity: Minor
Found in maintenance/rebuildFileCache.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function appendJsConfigVar(
        string $key,
        string $value,
        string $strategy = self::MW_MERGE_STRATEGY_UNION
    ): void {
Severity: Major
Found in includes/parser/ParserOutput.php and 1 other location - About 4 hrs to fix
includes/parser/ParserOutput.php on lines 1993..2012

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 181.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function appendExtensionData(
        string $key,
        $value,
        string $strategy = self::MW_MERGE_STRATEGY_UNION
    ): void {
Severity: Major
Found in includes/parser/ParserOutput.php and 1 other location - About 4 hrs to fix
includes/parser/ParserOutput.php on lines 1350..1369

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 181.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function defaultPrefilter has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function defaultPrefilter( elem, props, opts ) {
    var prop, value, toggle, hooks, oldfire, propTween, restoreDisplay, display,
        isBox = "width" in props || "height" in props,
        anim = this,
        orig = {},
Severity: Major
Found in resources/lib/jquery/jquery.js - About 4 hrs to fix

    Function clip has 122 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    OO.ui.mixin.ClippableElement.prototype.clip = function () {
    if ( !this.clipping ) {
        // this.$clippableScrollableContainer and this.$clippableWindow are null, so the below
        // will fail
        return this;
    Severity: Major
    Found in resources/lib/ooui/oojs-ui-core.js - About 4 hrs to fix

      Method import has 122 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function import( ImportableOldRevision $importableRevision, $doUpdates = true ) {
        $dbw = $this->dbProvider->getPrimaryDatabase();

        # Sneak a single revision into place
        $user = $importableRevision->getUserObj() ?: $this->userFactory->newFromName( $importableRevision->getUser() );
      Severity: Major
      Found in includes/import/ImportableOldRevisionImporter.php - About 4 hrs to fix
        Severity
        Category
        Status
        Source
        Language