wikimedia/mediawiki-core

View on GitHub

Showing 11,545 of 11,545 total issues

SlotRecord has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class SlotRecord {
    use NonSerializableTrait;

    public const MAIN = 'main';

Severity: Minor
Found in includes/Revision/SlotRecord.php - About 3 hrs to fix

    AbstractBlock has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractBlock implements Block {
        use WikiAwareEntityTrait;
    
        /** @var CommentStoreComment */
        protected $reason;
    Severity: Minor
    Found in includes/block/AbstractBlock.php - About 3 hrs to fix

      Action has 30 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class Action implements MessageLocalizer {
      
          /**
           * @var Article
           * @since 1.35
      Severity: Minor
      Found in includes/actions/Action.php - About 3 hrs to fix

        LocalisationCache has 30 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class LocalisationCache {
            public const VERSION = 5;
        
            /** @var ServiceOptions */
            private $options;
        Severity: Minor
        Found in includes/language/LocalisationCache.php - About 3 hrs to fix

          SpecialEditWatchlist has 30 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SpecialEditWatchlist extends UnlistedSpecialPage {
              /**
               * Editing modes. EDIT_CLEAR is no longer used; the "Clear" link scared people
               * too much. Now it's passed on to the raw editor, from which it's very easy to clear.
               */
          Severity: Minor
          Found in includes/specials/SpecialEditWatchlist.php - About 3 hrs to fix

            UserGroupManager has 30 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class UserGroupManager {
            
                /**
                 * @internal For use by ServiceWiring
                 */
            Severity: Minor
            Found in includes/user/UserGroupManager.php - About 3 hrs to fix

              ForeignAPIFile has 30 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class ForeignAPIFile extends File {
                  /** @var bool */
                  private $mExists;
                  /** @var array */
                  private $mInfo;
              Severity: Minor
              Found in includes/filerepo/file/ForeignAPIFile.php - About 3 hrs to fix

                Router has 30 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Router {
                    private const PREFIX_PATTERN = '!^/([-_.\w]+(?:/v\d+)?)(/.*)$!';
                
                    /** @var string[] */
                    private $routeFiles;
                Severity: Minor
                Found in includes/Rest/Router.php - About 3 hrs to fix

                  File MessagesMl.php has 319 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  /** Malayalam (മലയാളം)
                   *
                   * @file
                   * @ingroup Languages
                  Severity: Minor
                  Found in languages/messages/MessagesMl.php - About 3 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        switch ( form ) {
                            case 'genitive':
                                word += 'n';
                                break;
                            case 'elative':
                    Severity: Major
                    Found in resources/src/mediawiki.language/languages/fi.js and 1 other location - About 3 hrs to fix
                    resources/lib/jquery.i18n/src/languages/fi.js on lines 24..44

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 108.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                switch ( form ) {
                                    case 'genitive':
                                        word += 'n';
                                        break;
                                    case 'elative':
                    Severity: Major
                    Found in resources/lib/jquery.i18n/src/languages/fi.js and 1 other location - About 3 hrs to fix
                    resources/src/mediawiki.language/languages/fi.js on lines 25..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 108.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public static function createTagWithChecks( string $tag, string $reason, Authority $performer,
                            bool $ignoreWarnings = false, array $logEntryTags = []
                        ) {
                            // are we allowed to do this?
                            $result = self::canCreateTag( $tag, $performer );
                    Severity: Major
                    Found in includes/changetags/ChangeTags.php and 2 other locations - About 3 hrs to fix
                    includes/changetags/ChangeTags.php on lines 856..873
                    includes/changetags/ChangeTags.php on lines 922..939

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        private function resolveDomainInstance( $domain ) {
                            if ( $domain instanceof DatabaseDomain ) {
                                return $domain; // already a domain instance
                            } elseif ( $domain === false || $domain === $this->localDomain->getId() ) {
                                return $this->localDomain;
                    Severity: Major
                    Found in includes/libs/rdbms/lbfactory/LBFactoryMulti.php and 1 other location - About 3 hrs to fix
                    includes/libs/rdbms/loadbalancer/LoadBalancer.php on lines 256..275

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        final protected function resolveDomainInstance( $domain ): DatabaseDomain {
                            if ( $domain instanceof DatabaseDomain ) {
                                return $domain; // already a domain instance
                            } elseif ( $domain === false || $domain === $this->localDomain->getId() ) {
                                return $this->localDomain;
                    Severity: Major
                    Found in includes/libs/rdbms/loadbalancer/LoadBalancer.php and 1 other location - About 3 hrs to fix
                    includes/libs/rdbms/lbfactory/LBFactoryMulti.php on lines 198..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public static function deactivateTagWithChecks( string $tag, string $reason, Authority $performer,
                            bool $ignoreWarnings = false, array $logEntryTags = []
                        ) {
                            // are we allowed to do this?
                            $result = self::canDeactivateTag( $tag, $performer );
                    Severity: Major
                    Found in includes/changetags/ChangeTags.php and 2 other locations - About 3 hrs to fix
                    includes/changetags/ChangeTags.php on lines 856..873
                    includes/changetags/ChangeTags.php on lines 1040..1056

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public static function activateTagWithChecks( string $tag, string $reason, Authority $performer,
                            bool $ignoreWarnings = false, array $logEntryTags = []
                        ) {
                            // are we allowed to do this?
                            $result = self::canActivateTag( $tag, $performer );
                    Severity: Major
                    Found in includes/changetags/ChangeTags.php and 2 other locations - About 3 hrs to fix
                    includes/changetags/ChangeTags.php on lines 922..939
                    includes/changetags/ChangeTags.php on lines 1040..1056

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 155.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function fn has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        fn(state) {
                          return __async(this, null, function* () {
                            var _middlewareData$arrow, _middlewareData$flip;
                            const {
                              placement,
                    Severity: Major
                    Found in resources/lib/codex/codex.js - About 3 hrs to fix

                      Function computePosition has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      OO.ui.mixin.FloatableElement.prototype.computePosition = function () {
                          const newPos = { top: '', left: '', bottom: '', right: '' };
                          const direction = this.$floatableContainer.css( 'direction' );
                      
                          let $offsetParent = this.$floatable.offsetParent();
                      Severity: Major
                      Found in resources/lib/ooui/oojs-ui-core.js - About 3 hrs to fix

                        Method getProtectionInfo has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function getProtectionInfo() {
                                $this->protections = [];
                                $db = $this->getDB();
                        
                                // Get normal protections for existing titles
                        Severity: Major
                        Found in includes/api/ApiQueryInfo.php - About 3 hrs to fix

                          Method execute has 91 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function execute() {
                                  $this->params = $this->extractRequestParams();
                                  if ( $this->params['prop'] !== null ) {
                                      $prop = array_fill_keys( $this->params['prop'], true );
                                      $this->fld_protection = isset( $prop['protection'] );
                          Severity: Major
                          Found in includes/api/ApiQueryInfo.php - About 3 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language