Showing 11,545 of 11,545 total issues
Method showHistory
has 91 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function showHistory() {
# List all stored revisions
$revisions = new MergeHistoryPager(
$this->getContext(),
$this->getLinkRenderer(),
Method getActionLinks
has 91 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getActionLinks() {
$linkRenderer = $this->getLinkRenderer();
if ( !$this->context->getAuthority()->isAllowed( 'deletedhistory' )
|| $this->entry->isDeleted( LogPage::DELETED_ACTION )
) {
File TransactionProfiler.php
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
File TransformationalImageHandler.php
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Base class for handlers which require transforming images in a
* similar way as BitmapHandler does.
*
File DatabaseInstaller.php
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* DBMS-specific installation helper.
*
File ApiQueryCategoryMembers.php
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
*
* This program is free software; you can redistribute it and/or modify
File mediawiki.base.js
has 317 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict';
const slice = Array.prototype.slice;
// Apply site-level data
File ApiParamValidator.php
has 317 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace MediaWiki\Api\Validator;
use Exception;
Function handler
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
$.fn.confirmable.handler = function ( event, options ) {
const $element = $( event.target );
if ( $element.data( 'jquery-confirmable-button' ) ) {
// We're running on a clone of this element that represents the 'Yes' or 'No' button.
Function profile
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
profile: function ( nav ) {
if ( !nav ) {
nav = window.navigator;
}
Function constructor
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor(plugin, hook) {
this.target = null;
this.targetQueue = [];
this.onQueue = [];
this.plugin = plugin;
Method setMainValue
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function setMainValue(
$key,
$value,
$ttl,
?int $version,
Method getNewtalks
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getNewtalks() {
if ( $this->hideNewTalkMessagesForCurrentSession() ) {
return '';
}
Method autoConvert
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function autoConvert( $text, $toVariant = false ) {
$this->loadTables();
if ( !$toVariant ) {
$toVariant = $this->getPreferredVariant();
Method transformImageMagick
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function transformImageMagick( $image, $params ) {
# use ImageMagick
$mainConfig = MediaWikiServices::getInstance()->getMainConfig();
$sharpenReductionThreshold = $mainConfig->get( MainConfigNames::SharpenReductionThreshold );
$sharpenParameter = $mainConfig->get( MainConfigNames::SharpenParameter );
Method run
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function run( $resultPageSet = null ) {
$params = $this->extractRequestParams();
$namespaces = $this->getPageSet()->getGoodAndMissingTitlesByNamespace();
if ( empty( $namespaces[NS_FILE] ) ) {
return;
Method execute
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function execute( $par ) {
$this->setHeaders();
$this->outputHeader();
$out = $this->getOutput();
$out->addModules( 'mediawiki.userSuggest' );
Similar blocks of code found in 2 locations. Consider refactoring. Open
_focusable: function( element ) {
this.focusable = this.focusable.add( element );
this._on( element, {
focusin: function( event ) {
$( event.currentTarget ).addClass( "ui-state-focus" );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 107.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
relativeTime: {
future: function (s) {
return (/^[0-9].+$/.test(s) ? 'tra' : 'in') + ' ' + s;
},
past: '%s fa',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 107.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( factor.from.x !== factor.to.x ) {
child.from = $.effects.setTransition( child, hProps, factor.from.x, child.from );
child.to = $.effects.setTransition( child, hProps, factor.to.x, child.to );
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 107.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76