wikimedia/mediawiki-core

View on GitHub

Showing 11,545 of 11,545 total issues

Method showHistory has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function showHistory() {
        # List all stored revisions
        $revisions = new MergeHistoryPager(
            $this->getContext(),
            $this->getLinkRenderer(),
Severity: Major
Found in includes/specials/SpecialMergeHistory.php - About 3 hrs to fix

    Method getActionLinks has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getActionLinks() {
            $linkRenderer = $this->getLinkRenderer();
            if ( !$this->context->getAuthority()->isAllowed( 'deletedhistory' )
                || $this->entry->isDeleted( LogPage::DELETED_ACTION )
            ) {
    Severity: Major
    Found in includes/logging/DeleteLogFormatter.php - About 3 hrs to fix

      File TransactionProfiler.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /**
       * This program is free software; you can redistribute it and/or modify
       * it under the terms of the GNU General Public License as published by
       * the Free Software Foundation; either version 2 of the License, or
      Severity: Minor
      Found in includes/libs/rdbms/TransactionProfiler.php - About 3 hrs to fix

        File TransformationalImageHandler.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * Base class for handlers which require transforming images in a
         * similar way as BitmapHandler does.
         *
        Severity: Minor
        Found in includes/media/TransformationalImageHandler.php - About 3 hrs to fix

          File DatabaseInstaller.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * DBMS-specific installation helper.
           *
          Severity: Minor
          Found in includes/installer/DatabaseInstaller.php - About 3 hrs to fix

            File ApiQueryCategoryMembers.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /**
             * Copyright © 2006 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
             *
             * This program is free software; you can redistribute it and/or modify
            Severity: Minor
            Found in includes/api/ApiQueryCategoryMembers.php - About 3 hrs to fix

              File mediawiki.base.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              'use strict';
              
              const slice = Array.prototype.slice;
              
              // Apply site-level data
              Severity: Minor
              Found in resources/src/mediawiki.base/mediawiki.base.js - About 3 hrs to fix

                File ApiParamValidator.php has 317 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace MediaWiki\Api\Validator;
                
                use Exception;
                Severity: Minor
                Found in includes/api/Validator/ApiParamValidator.php - About 3 hrs to fix

                  Function handler has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      $.fn.confirmable.handler = function ( event, options ) {
                          const $element = $( event.target );
                  
                          if ( $element.data( 'jquery-confirmable-button' ) ) {
                              // We're running on a clone of this element that represents the 'Yes' or 'No' button.
                  Severity: Major
                  Found in resources/src/jquery/jquery.confirmable.js - About 3 hrs to fix

                    Function profile has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            profile: function ( nav ) {
                                if ( !nav ) {
                                    nav = window.navigator;
                                }
                    
                    
                    Severity: Major
                    Found in resources/lib/jquery.client/jquery.client.js - About 3 hrs to fix

                      Function constructor has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            constructor(plugin, hook) {
                                this.target = null;
                                this.targetQueue = [];
                                this.onQueue = [];
                                this.plugin = plugin;
                      Severity: Major
                      Found in resources/lib/pinia/pinia.iife.js - About 3 hrs to fix

                        Method setMainValue has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private function setMainValue(
                                $key,
                                $value,
                                $ttl,
                                ?int $version,
                        Severity: Major
                        Found in includes/libs/objectcache/WANObjectCache.php - About 3 hrs to fix

                          Method getNewtalks has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getNewtalks() {
                                  if ( $this->hideNewTalkMessagesForCurrentSession() ) {
                                      return '';
                                  }
                          
                          
                          Severity: Major
                          Found in includes/skins/Skin.php - About 3 hrs to fix

                            Method autoConvert has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function autoConvert( $text, $toVariant = false ) {
                                    $this->loadTables();
                            
                                    if ( !$toVariant ) {
                                        $toVariant = $this->getPreferredVariant();
                            Severity: Major
                            Found in includes/language/LanguageConverter.php - About 3 hrs to fix

                              Method transformImageMagick has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  protected function transformImageMagick( $image, $params ) {
                                      # use ImageMagick
                                      $mainConfig = MediaWikiServices::getInstance()->getMainConfig();
                                      $sharpenReductionThreshold = $mainConfig->get( MainConfigNames::SharpenReductionThreshold );
                                      $sharpenParameter = $mainConfig->get( MainConfigNames::SharpenParameter );
                              Severity: Major
                              Found in includes/media/BitmapHandler.php - About 3 hrs to fix

                                Method run has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    private function run( $resultPageSet = null ) {
                                        $params = $this->extractRequestParams();
                                        $namespaces = $this->getPageSet()->getGoodAndMissingTitlesByNamespace();
                                        if ( empty( $namespaces[NS_FILE] ) ) {
                                            return;
                                Severity: Major
                                Found in includes/api/ApiQueryDuplicateFiles.php - About 3 hrs to fix

                                  Method execute has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public function execute( $par ) {
                                          $this->setHeaders();
                                          $this->outputHeader();
                                          $out = $this->getOutput();
                                          $out->addModules( 'mediawiki.userSuggest' );
                                  Severity: Major
                                  Found in includes/specials/SpecialLog.php - About 3 hrs to fix

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                        _focusable: function( element ) {
                                            this.focusable = this.focusable.add( element );
                                            this._on( element, {
                                                focusin: function( event ) {
                                                    $( event.currentTarget ).addClass( "ui-state-focus" );
                                    Severity: Major
                                    Found in resources/lib/jquery.ui/jquery.ui.widget.js and 1 other location - About 3 hrs to fix
                                    resources/lib/jquery.ui/jquery.ui.widget.js on lines 431..441

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 107.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                            relativeTime: {
                                                future: function (s) {
                                                    return (/^[0-9].+$/.test(s) ? 'tra' : 'in') + ' ' + s;
                                                },
                                                past: '%s fa',
                                    Severity: Major
                                    Found in resources/lib/moment/locale/it-ch.js and 1 other location - About 3 hrs to fix
                                    resources/lib/moment/locale/it.js on lines 89..106

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 107.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 2 locations. Consider refactoring.
                                    Open

                                                if ( factor.from.x !== factor.to.x ) {
                                                    child.from = $.effects.setTransition( child, hProps, factor.from.x, child.from );
                                                    child.to = $.effects.setTransition( child, hProps, factor.to.x, child.to );
                                                }
                                    Severity: Major
                                    Found in resources/lib/jquery.ui/jquery.ui.effect-scale.js and 1 other location - About 3 hrs to fix
                                    resources/lib/jquery.ui/jquery.ui.effect-scale.js on lines 249..252

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 107.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language