wikimedia/mediawiki-extensions-DonationInterface

View on GitHub

Showing 275 of 311 total issues

Method getParamsFromURL has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getParamsFromURL(): array {
        // Get country code from request param, or, if it's not sent or is invalid, use
        // geoip lookup
        $country = $this->sanitizedValOrNull( 'country' );

Severity: Minor
Found in special/GatewayChooser.php - About 1 hr to fix

    Function submitPayment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function submitPayment() {
            if ( !mw.donationInterface.validation.validateAmount() ) {
                return;
            }
            if ( !cardSelected ) {
    Severity: Minor
    Found in amazon_gateway/amazon.js - About 1 hr to fix

      Method handleCreatedPayment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleCreatedPayment(
              CreatePaymentResponse $createPaymentResult, PaymentProvider $provider
          ): PaymentResult {
              $transactionStatus = $createPaymentResult->getStatus();
      
      
      Severity: Minor
      Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

        Method setupQueueParams has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function setupQueueParams( $params, $queueName ) {
                switch ( $queueName ) {
                    case 'email-preferences':
                        $message = [
                            'checksum' => $params['checksum'],
        Severity: Minor
        Found in special/EmailPreferences.php - About 1 hr to fix

          Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute( $subpage ) {
                  $this->setHeaders();
                  $this->outputHeader();
                  $out = $this->getOutput();
          
          
          Severity: Minor
          Found in special/EmailPreferences.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getLocalizedValidationErrorResult has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                  $localizedErrors = [];
                  foreach ( $validationErrors as $error ) {
                      $field = $error->getField();
                      $debugMessage = $error->getDebugMessage();
          Severity: Minor
          Found in dlocal_gateway/dlocal.adapter.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleCreatedPayment has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function handleCreatedPayment(
                  IPaymentProvider $provider, PaymentDetailResponse $authorizeResult
              ): PaymentResult {
                  $transactionStatus = $authorizeResult->getStatus();
          
          
          Severity: Minor
          Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getParamsFromURL has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getParamsFromURL(): array {
                  // Get country code from request param, or, if it's not sent or is invalid, use
                  // geoip lookup
                  $country = $this->sanitizedValOrNull( 'country' );
          
          
          Severity: Minor
          Found in special/GatewayChooser.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getLocalizedValidationErrorResult has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                  $localizedErrors = [];
                  foreach ( $validationErrors as $error ) {
                      $field = $error->getField();
                      $debugMessage = $error->getDebugMessage();
          Severity: Minor
          Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function session_resetForNewAttempt has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              public function session_resetForNewAttempt( $force = false ) {
                  $reset = $force;
                  if ( $this->session_getData( 'numAttempt' ) > 3 ) {
                      $reset = true;
                      WmfFramework::setSessionValue( 'numAttempt', 0 );
          Severity: Minor
          Found in gateway_common/gateway.adapter.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function execute( $par ) {
                  // Bow out if gateway chooser is not enabled
                  if ( !$this->getConfig()->get( 'DonationInterfaceEnableGatewayChooser' ) ) {
                      throw new BadTitleError();
                  }
          Severity: Minor
          Found in special/GatewayChooser.php - About 1 hr to fix

            Method session_resetForNewAttempt has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function session_resetForNewAttempt( $force = false ) {
                    $reset = $force;
                    if ( $this->session_getData( 'numAttempt' ) > 3 ) {
                        $reset = true;
                        WmfFramework::setSessionValue( 'numAttempt', 0 );
            Severity: Minor
            Found in gateway_common/gateway.adapter.php - About 1 hr to fix

              Method session_resetOnSwitch has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function session_resetOnSwitch() {
                      $oldData = $this->session_getData( 'Donor' );
                      if ( !is_array( $oldData ) ) {
                          return;
                      }
              Severity: Minor
              Found in gateway_common/gateway.adapter.php - About 1 hr to fix

                Function setup has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function setup() {
                        var component_type,
                            config,
                            containerName = 'component-container',
                            oldShowErrors,
                Severity: Minor
                Found in adyen_gateway/forms/adyen.js - About 1 hr to fix

                  Method handleCreatedPayment has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function handleCreatedPayment(
                          IPaymentProvider $provider, PaymentDetailResponse $authorizeResult
                      ): PaymentResult {
                          $transactionStatus = $authorizeResult->getStatus();
                  
                  
                  Severity: Minor
                  Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

                    Method getMessageFields has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function getMessageFields() {
                            return [
                                'contribution_tracking_id',
                                'anonymous',
                                'utm_source',
                    Severity: Minor
                    Found in gateway_common/DonationData.php - About 1 hr to fix

                      Method defineTransactions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function defineTransactions() {
                              $this->transactions = [];
                      
                              // https://developer.paypal.com/docs/classic/api/merchant/SetExpressCheckout_API_Operation_NVP/
                              $this->transactions['SetExpressCheckout'] = [
                      Severity: Minor
                      Found in paypal_ec_gateway/paypal_express.adapter.php - About 1 hr to fix

                        Method getLocalizedValidationErrorResult has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
                                $localizedErrors = [];
                                foreach ( $validationErrors as $error ) {
                                    $field = $error->getField();
                                    $debugMessage = $error->getDebugMessage();
                        Severity: Minor
                        Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

                          Function createWalletWidget has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              function createWalletWidget() {
                                  var params = {
                                      sellerId: sellerId,
                                      onReady: function ( billingAgreement ) {
                                          if ( !cardSelected ) {
                          Severity: Minor
                          Found in amazon_gateway/amazon.js - About 1 hr to fix

                            Function filter has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function filter( $filterListGlobal ) {
                                    $functions = $this->gateway_adapter->getGlobal( $filterListGlobal );
                            
                                    if (
                                        !$this->gateway_adapter->getGlobal( 'EnableFunctionsFilter' ) ||
                            Severity: Minor
                            Found in extras/custom_filters/filters/functions/functions.body.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language