Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star

Showing 183 of 183 total issues

Function executeViewEditWatchlist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function executeViewEditWatchlist() {
        $ns = NS_MAIN;
        $images = [];

        $watchlist = $this->getWatchlistInfo();
Severity: Minor
Found in includes/specials/SpecialMobileEditWatchlist.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function showReference has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    showReference( id, page, refNumber, pageHTMLParser, gateway, props,
        onShowNestedReference
Severity: Major
Found in src/mobile.startup/references/references.js - About 50 mins to fix

    Function init has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function init( currentPage, currentPageHTMLParser, skin, router ) {
    let editErrorMessage, editRestrictions;
    // see: https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific
    const isReadOnly = mw.config.get( 'wgMinervaReadOnly' );
    const isEditable = !isReadOnly && mw.config.get( 'wgIsProbablyEditable' );
    Severity: Minor
    Found in src/mobile.init/editor.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function initMobileOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function initMobileOptions() {
    const $form = $( '#mobile-options' ),
        $betaToggle = $( '#enable-beta-toggle' ),
        $amcToggle = $( '#enable-amc-toggle' ),
        toggles = [];
    Severity: Minor
    Found in src/mobile.special.mobileoptions.scripts.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    function parse( resp ) {
    let displayTitle;
    const thumb = resp.thumbnail,
        pageprops = resp.pageprops || {
            displaytitle: mw.html.escape( resp.title )
    Severity: Minor
    Found in src/mobile.startup/page/pageJSONParser.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getMobileUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getMobileUrl( $url, $forceHttps = false ) {
        $urlUtils = MediaWikiServices::getInstance()->getUrlUtils();
        $parsedUrl = $urlUtils->parse( $url );
        // if parsing failed, maybe it's a local Url, try to expand and reparse it - task T107505
        if ( !$parsedUrl ) {
    Severity: Minor
    Found in includes/MobileContext.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onMediaWikiPerformAction has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function onMediaWikiPerformAction( $output, $article, $title, $user,
        $request, $entryPoint
    Severity: Minor
    Found in includes/MobileFrontendHooks.php - About 45 mins to fix

      Function isSupportedEditRequest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function isSupportedEditRequest( IContextSource $context ) {
        /** @var MobileContext $mobileContext */
        $mobileContext = MediaWikiServices::getInstance()->getService( 'MobileFrontend.Context' );
        if ( !$mobileContext->shouldDisplayMobileView() ) {
            return false;
      Severity: Minor
      Found in includes/MobileFrontendEditorHooks.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createPromoCampaign has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          onShow,
    actions,
    campaignName,
    campaignActive,
    userEligible,
      Severity: Minor
      Found in src/mobile.startup/promoCampaign/promoCampaign.js - About 45 mins to fix

        Function onBeforeExit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            onBeforeExit: function ( exit, cancel ) {
        const self = this;
        if ( this.hasChanged() && !this.switching ) {
            if ( !this.windowManager ) {
                this.windowManager = OO.ui.getWindowManager();
        Severity: Minor
        Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function shouldDisplayMobileViewInternal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function shouldDisplayMobileViewInternal() {
        // May be overridden programmatically
        if ( $this->forceMobileView ) {
            return true;
        }
        Severity: Minor
        Found in includes/MobileContext.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createPromoCampaign has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function createPromoCampaign(
    onShow,
    actions,
    campaignName,
    campaignActive,
        Severity: Minor
        Found in src/mobile.startup/promoCampaign/promoCampaign.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ( resp.parse.sections[0].anchor !== undefined ) {
                        sectionId = resp.parse.sections[0].anchor;
                    }
        Severity: Minor
        Found in src/mobile.editor.overlay/EditorGateway.js and 1 other location - About 45 mins to fix
        src/mobile.editor.overlay/EditorGateway.js on lines 289..291

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ( resp.parse.sections[0].line !== undefined ) {
                        sectionLine = resp.parse.sections[0].line;
                    }
        Severity: Minor
        Found in src/mobile.editor.overlay/EditorGateway.js and 1 other location - About 45 mins to fix
        src/mobile.editor.overlay/EditorGateway.js on lines 286..288

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getStructuredLanguages has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                languages,
        variants,
        frequentlyUsedLanguages,
        showSuggestedLanguages,
        deviceLanguage
        Severity: Minor
        Found in src/mobile.languages.structured/util.js - About 35 mins to fix

          Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports = function searchHeader( placeholderMsg, action, onInput, defaultSearchPage, autocapitalize ) {
          Severity: Minor
          Found in src/mobile.startup/search/searchHeader.js - About 35 mins to fix

            Function reveal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            Toggler.prototype.reveal = function ( id ) {
    let $target;
    // jQuery will throw for hashes containing certain characters which can break toggling
    try {
        $target = this.$container.find( '#' + escapeSelector( id ) );
            Severity: Minor
            Found in src/mobile.startup/Toggler.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _processMatch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                _processMatch( match ) {
        const self = this;

        if ( match ) {
            if ( match.overlay ) {
            Severity: Minor
            Found in src/mobile.startup/OverlayManager.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                getContent: function () {
        let options;

        const self = this;
            Severity: Minor
            Found in src/mobile.editor.overlay/EditorGateway.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getLastModifiedMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function getLastModifiedMessage( ts, username, gender, historyUrl ) {
    const linkAll = typeof historyUrl === 'undefined',
        keys = {
            seconds: 'mobile-frontend-last-modified-with-user-seconds',
            minutes: 'mobile-frontend-last-modified-with-user-minutes',
            Severity: Minor
            Found in src/mobile.startup/time.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language