Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star

Showing 183 of 183 total issues

Function onOutputPageBeforeHTML has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function onOutputPageBeforeHTML( $out, &$text ) {
        // This hook can be executed more than once per page view if the page content is composed from
        // multiple sources! Anything that doesn't depend on $text should use onBeforePageDisplay.

        $context = $this->mobileContext;
Severity: Minor
Found in includes/MobileFrontendHooks.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onSaveComplete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    onSaveComplete: function ( newRevId, redirectUrl ) {
        EditorOverlayBase.prototype.onSaveComplete.apply( this, arguments );

        // The parent class changes the location hash in a setTimeout, so wait
        // for that to happen before reloading.
Severity: Minor
Found in src/mobile.editor.overlay/SourceEditorOverlay.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _positionImage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    _positionImage: function () {
        const $window = util.getWindow();

        this.adjustDetails();
        // with a hidden details box we have a little bit more space, we just need to use it
Severity: Minor
Found in src/mobile.mediaViewer/ImageCarousel.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function identifyLeadParagraph has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function identifyLeadParagraph( $body ) {
    // Keep in sync with MoveLeadParagraphTransform::isNotEmptyNode()
    function isNotEmptyNode( node ) {
        // Ignore VE whitespace characters
        return !/^[\s↵➞]*$/.test( node.textContent );
Severity: Minor
Found in src/mobile.editor.overlay/identifyLeadParagraph.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filterLanguages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    filterLanguages: function ( searchQuery, searchOrigin ) {
        const filteredList = [];

        if ( searchQuery ) {
            this.options.languages.forEach( function ( language ) {
Severity: Minor
Found in src/mobile.languages.structured/LanguageSearcher.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onSkinAddFooterLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function onSkinAddFooterLinks( Skin $skin, string $key, array &$footerLinks ) {
        $context = $this->mobileContext;
        if ( $key === 'places' ) {
            if ( $context->shouldDisplayMobileView() ) {
                $terms = MobileFrontendSkinHooks::getTermsLink( $skin );
Severity: Minor
Found in includes/MobileFrontendHooks.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function hasEditNoticesFeatureConflict has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function hasEditNoticesFeatureConflict( Config $config, User $user ): bool {
        $gadgetName = $config->get( 'MFEditNoticesConflictingGadgetName' );
        if ( !$gadgetName ) {
            return false;
        }
Severity: Minor
Found in includes/MobileFrontendHooks.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    logFeatureUse: function ( data ) {
        mw.track( 'visualEditorFeatureUse', util.extend( data, {
            // eslint-disable-next-line camelcase
            editor_interface: this.editor
        } ) );
Severity: Minor
Found in src/mobile.editor.overlay/EditorOverlayBase.js and 1 other location - About 35 mins to fix
src/mobile.editor.overlay/EditorOverlayBase.js on lines 188..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    log: function ( data ) {
        mw.track( 'editAttemptStep', util.extend( data, {
            // eslint-disable-next-line camelcase
            editor_interface: this.editor
        } ) );
Severity: Minor
Found in src/mobile.editor.overlay/EditorOverlayBase.js and 1 other location - About 35 mins to fix
src/mobile.editor.overlay/EditorOverlayBase.js on lines 201..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function copyClasses( $from, $to, array $enabled, array $additional ) {
        $styles = HtmlClassUtils::parseClassString(
            $from->hasAttribute( 'class' ) ? $from->getAttribute( 'class' ) : ''
        );
Severity: Minor
Found in includes/Transforms/LazyImageTransform.php and 1 other location - About 30 mins to fix
includes/Transforms/LazyImageTransform.php on lines 242..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function copyStyles( $from, $to, array $enabled, array $additional ) {
        $styles = HtmlStyleUtils::parseStyleString(
            $from->hasAttribute( 'style' ) ? $from->getAttribute( 'style' ) : ''
        );
Severity: Minor
Found in includes/Transforms/LazyImageTransform.php and 1 other location - About 30 mins to fix
includes/Transforms/LazyImageTransform.php on lines 259..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return true;
Severity: Major
Found in includes/MobileContext.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in includes/MobileContext.php - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return $heading.nextUntil( $nextHeading, selector );
      Severity: Major
      Found in src/mobile.startup/PageHTMLParser.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 'SourceEditor';
        Severity: Major
        Found in src/mobile.init/editor.js - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return true;
                Severity: Major
                Found in includes/MobileContext.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return false;
                  Severity: Major
                  Found in includes/MobileContext.php - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language