Sign upLogin

wikimedia/mediawiki-extensions-UniversalLanguageSelector

View on GitHub
Star

Showing 269 of 269 total issues

Function getFontInfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFontInfo( $font, $fontpath ) {
        $info = [];
        $fontdir = basename( $fontpath );

        if ( isset( $font['fontweight'] ) ) {
Severity: Minor
Found in includes/FontRepoCompiler.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onUserGetLanguageObject has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function onUserGetLanguageObject( $user, &$code, $context ) {
        if ( $this->config->get( 'ULSLanguageDetection' ) ) {
            // Vary any caching based on the header value. Note that
            // we need to vary regardless of whether we end up using
            // the header or not, so that requests without the header
Severity: Minor
Found in includes/Hooks.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildQuicklist has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        buildQuicklist: function () {
            var quickList, $quickListSection, $quickListSectionTitle;

            if ( this.$cachedQuicklist !== null ) {
                return this.$cachedQuicklist;
Severity: Minor
Found in lib/jquery.uls/src/jquery.uls.lcd.js - About 1 hr to fix

    Function loadContentLanguageSelector has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function loadContentLanguageSelector( ev ) {
        var $target = $( ev.currentTarget );

        // Avoid reinitializing ULS multiple times for an element
        if ( $target.attr( 'data-uls-loaded' ) ) {
    Severity: Minor
    Found in resources/js/ext.uls.interface.js - About 1 hr to fix

      Function prepareInputMethods has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              prepareInputMethods: function ( languageCode ) {
            var language = $.ime.languages[ languageCode ],
                $imeList = this.$menu.find( '.ime-list' ),
                imeSelector = this;
      Severity: Minor
      Found in lib/jquery.ime/jquery.ime.js - About 1 hr to fix

        Function addLanguageSettingsToNonContentPages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function addLanguageSettingsToNonContentPages() {
        var $languageBtn = $( '#p-lang-btn' );
        var clickHandler = function ( event ) {
            event.stopPropagation();
            mw.loader.using( languageSettingsModules ).then( function () {
        Severity: Minor
        Found in resources/js/ext.uls.interface.js - About 1 hr to fix

          Method getFontInfo has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getFontInfo( $font, $fontpath ) {
        $info = [];
        $fontdir = basename( $fontpath );

        if ( isset( $font['fontweight'] ) ) {
          Severity: Minor
          Found in includes/FontRepoCompiler.php - About 1 hr to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ 'F', '\u090C' ],
            [ '\\>', '\u093D' ],
            [ '\\=', '\u0944' ],
            [ 'X', '\u0950' ],
            Severity: Major
            Found in lib/jquery.ime/rules/mr/mr-inscript.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/gu/gu-inscript2.js on lines 100..114
            lib/jquery.ime/rules/kn/kn-inscript.js on lines 94..107
            lib/jquery.ime/rules/or/or-inscript.js on lines 88..101
            lib/jquery.ime/rules/sa/sa-inscript2.js on lines 99..113
            lib/jquery.ime/rules/ta/ta-inscript.js on lines 87..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ 'X', 'ௐ' ],
            [ '\\)', '௰' ],
            [ '-', '௱' ],
            [ '=', '௲' ],
            Severity: Major
            Found in lib/jquery.ime/rules/ta/ta-inscript.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/gu/gu-inscript2.js on lines 100..114
            lib/jquery.ime/rules/kn/kn-inscript.js on lines 94..107
            lib/jquery.ime/rules/mr/mr-inscript.js on lines 98..111
            lib/jquery.ime/rules/or/or-inscript.js on lines 88..101
            lib/jquery.ime/rules/sa/sa-inscript2.js on lines 99..113

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ '1', '\u200d' ],
            [ '2', '\u200c' ],
            [ '4', '₹' ],
            [ '\\+', 'ૠ' ],
            Severity: Major
            Found in lib/jquery.ime/rules/gu/gu-inscript2.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/kn/kn-inscript.js on lines 94..107
            lib/jquery.ime/rules/mr/mr-inscript.js on lines 98..111
            lib/jquery.ime/rules/or/or-inscript.js on lines 88..101
            lib/jquery.ime/rules/sa/sa-inscript2.js on lines 99..113
            lib/jquery.ime/rules/ta/ta-inscript.js on lines 87..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ 'F', '\uC88C' ],
            [ '\\>', '\u0CBD' ],
            [ '\\=', '\u0CC4' ],
            [ 'H', '\u0CDE' ],
            Severity: Major
            Found in lib/jquery.ime/rules/kn/kn-inscript.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/gu/gu-inscript2.js on lines 100..114
            lib/jquery.ime/rules/mr/mr-inscript.js on lines 98..111
            lib/jquery.ime/rules/or/or-inscript.js on lines 88..101
            lib/jquery.ime/rules/sa/sa-inscript2.js on lines 99..113
            lib/jquery.ime/rules/ta/ta-inscript.js on lines 87..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ '1', '\u200d' ],
            [ '2', '\u200c' ],
            [ '4', '₹' ],
            [ 'e', '॑' ],
            Severity: Major
            Found in lib/jquery.ime/rules/sa/sa-inscript2.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/gu/gu-inscript2.js on lines 100..114
            lib/jquery.ime/rules/kn/kn-inscript.js on lines 94..107
            lib/jquery.ime/rules/mr/mr-inscript.js on lines 98..111
            lib/jquery.ime/rules/or/or-inscript.js on lines 88..101
            lib/jquery.ime/rules/ta/ta-inscript.js on lines 87..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                    patterns_x: [
            [ 'F', '\u0B0C' ],
            [ 'b', '\u0B35' ],
            [ '\\>', '\u0B3D' ],
            [ '\\=', '\u0B44' ],
            Severity: Major
            Found in lib/jquery.ime/rules/or/or-inscript.js and 5 other locations - About 1 hr to fix
            lib/jquery.ime/rules/gu/gu-inscript2.js on lines 100..114
            lib/jquery.ime/rules/kn/kn-inscript.js on lines 94..107
            lib/jquery.ime/rules/mr/mr-inscript.js on lines 98..111
            lib/jquery.ime/rules/sa/sa-inscript2.js on lines 99..113
            lib/jquery.ime/rules/ta/ta-inscript.js on lines 87..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function comparePoints has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function comparePoints(nodeA, offsetA, nodeB, offsetB) {
            // See http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-Comparing
            var nodeC, root, childA, childB, n;
            if (nodeA == nodeB) {
                // Case 1: nodes are the same
            Severity: Minor
            Found in lib/rangy/rangy-core.js - About 1 hr to fix

              Function load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  $.ime.load = function ( inputmethodId ) {
        var dependency,
            deferred = $.Deferred();

        if ( $.ime.inputmethods[ inputmethodId ] ) {
              Severity: Minor
              Found in lib/jquery.ime/jquery.ime.js - About 1 hr to fix

                Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function execute() {
        $request = $this->getRequest();
        if ( !$request->wasPosted() ) {
            $this->dieWithError( [ 'apierror-mustbeposted', $request->getText( 'action' ) ] );
        }
                Severity: Minor
                Found in includes/Api/ApiULSSetLanguage.php - About 1 hr to fix

                  Function apply has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          apply: function () {
            var previousIM,
                inputSettings = this,
                previousLanguage = inputSettings.savedRegistry.language,
                currentlyEnabled = $.ime.preferences.isEnabled(),
                  Severity: Minor
                  Found in resources/js/ext.uls.inputsettings.js - About 1 hr to fix

                    Method onUserGetLanguageObject has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function onUserGetLanguageObject( $user, &$code, $context ) {
        if ( $this->config->get( 'ULSLanguageDetection' ) ) {
            // Vary any caching based on the header value. Note that
            // we need to vary regardless of whether we end up using
            // the header or not, so that requests without the header
                    Severity: Minor
                    Found in includes/Hooks.php - About 1 hr to fix

                      Method getCodepoint has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function getCodepoint( $str ) {
        $values = [];
        $lookingFor = 1;
        $strLen = strlen( $str );
        $number = 0;
                      Severity: Minor
                      Found in data/LanguageNameSearch.php - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                patterns_x: [
            [ 'E', 'Ɛ' ],
            [ 'e', 'ɛ' ],
            // Both G and Y were requested by editors for Ɣ
            [ 'G', 'Ɣ' ],
                        Severity: Major
                        Found in lib/jquery.ime/rules/dag/dag-alt.js and 1 other location - About 1 hr to fix
                        lib/jquery.ime/rules/dag/dag-tilde.js on lines 14..28

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 56.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language