Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star

Showing 912 of 912 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if ( this.tableOfContentsTouched ) {
        if ( newTableOfContentsData.data === 'default' ) {
            if ( currentTableOfContents ) {
                this.fragment.removeMeta( currentTableOfContents );
            }
Severity: Major
Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 2 other locations - About 6 hrs to fix
modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 256..273
modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 280..297

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if ( this.newSectionEditLinkOptionTouched ) {
        if ( newNewSectionEditLinkData.data === 'default' ) {
            if ( currentNewSectionEditLinkItem ) {
                this.fragment.removeMeta( currentNewSectionEditLinkItem );
            }
Severity: Major
Found in modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js and 2 other locations - About 6 hrs to fix
modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 256..273
modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js on lines 348..365

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onSkinTemplateNavigation__Universal has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function onSkinTemplateNavigation__Universal( $skin, &$links ): void {
        $services = MediaWikiServices::getInstance();
        $userOptionsLookup = $services->getUserOptionsLookup();
        $config = $services->getConfigFactory()
            ->makeConfig( 'visualeditor' );
Severity: Minor
Found in includes/Hooks.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getSetupProcess has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

ve.ui.MWWikitextLinkAnnotationInspector.prototype.getSetupProcess = function ( data ) {
    // Annotation inspector stages the annotation, so call its parent
    // Call grand-parent
    return ve.ui.AnnotationInspector.super.prototype.getSetupProcess.call( this, data )
        .next( () => {
Severity: Minor
Found in modules/ve-mw/ui/inspectors/ve.ui.MWWikitextLinkAnnotationInspector.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function requestParsoidData has 154 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        requestParsoidData: function ( pageName, options, noRestbase, noMetadata ) {
            const section = options.section !== undefined ? options.section : null,
                useRestbase = !noRestbase && ( conf.fullRestbaseUrl || conf.restbaseUrl ) && section === null;

            options = options || {};
Severity: Major
Found in modules/ve-mw/preinit/ve.init.mw.ArticleTargetLoader.js - About 6 hrs to fix

    Function exports has 152 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function ( grunt ) {
    const conf = grunt.file.readJSON( 'extension.json' ),
        screenshotOptions = {
            reporter: 'spec',
            // TODO: Work out how to catch this timeout and continue.
    Severity: Major
    Found in Gruntfile.js - About 6 hrs to fix

      Method onSkinTemplateNavigation__Universal has 151 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function onSkinTemplateNavigation__Universal( $skin, &$links ): void {
        $services = MediaWikiServices::getInstance();
        $userOptionsLookup = $services->getUserOptionsLookup();
        $config = $services->getConfigFactory()
            ->makeConfig( 'visualeditor' );
      Severity: Major
      Found in includes/Hooks.php - About 6 hrs to fix

        Function teardown has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
        Open

        ve.ui.MWAdvancedSettingsPage.prototype.teardown = function ( data ) {
    // Data initialization
    data = data || {};
    if ( data.action !== 'done' ) {
        return;
        Severity: Minor
        Found in modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function initialize has 135 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ve.ui.MWSaveDialog.prototype.initialize = function () {
    const mwString = require( 'mediawiki.String' );

    // Parent method
    ve.ui.MWSaveDialog.super.prototype.initialize.call( this );
        Severity: Major
        Found in modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js - About 5 hrs to fix

          Function onReplacePart has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
          Open

          ve.ui.MWTemplateDialog.prototype.onReplacePart = function ( removed, added ) {
    const removePages = [];

    if ( removed ) {
        // Remove parameter pages of removed templates
          Severity: Minor
          Found in modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File ve.ui.MWTransclusionDialog.js has 383 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*!
 * VisualEditor user interface MWTransclusionDialog class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
          Severity: Minor
          Found in modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js - About 5 hrs to fix

            Function teardown has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
            Open

            ve.ui.MWSettingsPage.prototype.teardown = function ( data ) {
    // Data initialisation
    data = data || {};
    if ( data.action !== 'done' ) {
        return;
            Severity: Minor
            Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function showPage has 127 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function showPage( title, importTitle ) {
        const specialTitle = mw.Title.newFromText( 'Special:CollabPad/' + title.toString() );

        setTitle( mw.msg( 'collabpad-doctitle', title.getPrefixedText() ) );
            Severity: Major
            Found in modules/ve-mw-collab/ve.init.mw.CollabTarget.init.js - About 5 hrs to fix

              Method execute has 126 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();

        $result = [];
              Severity: Major
              Found in includes/ApiVisualEditorEdit.php - About 5 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    citoidInspectorManual: function () {
        const done = arguments[ arguments.length - 1 ],
            surface = ve.init.target.surface;
        surface.context.inspectors.currentWindow.setModePanel( 'manual' );
        setTimeout( () => {
                Severity: Major
                Found in build/screenshots-client/userGuide.js and 1 other location - About 5 hrs to fix
                build/screenshots-client/userGuide.js on lines 52..64

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 135.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    citoidInspectorReuse: function () {
        const done = arguments[ arguments.length - 1 ],
            surface = ve.init.target.surface;
        surface.context.inspectors.currentWindow.setModePanel( 'reuse' );
        setTimeout( () => {
                Severity: Major
                Found in build/screenshots-client/userGuide.js and 1 other location - About 5 hrs to fix
                build/screenshots-client/userGuide.js on lines 39..51

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 135.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File ve.init.mw.Target.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*!
 * VisualEditor MediaWiki Initialization Target class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
                Severity: Minor
                Found in modules/ve-mw/init/targets/ve.init.mw.Target.js - About 4 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          new OO.ui.ButtonSelectWidget()
            .addItems( [
                new OO.ui.ButtonOptionWidget( {
                    data: 'mw:PageProp/index',
                    label: ve.msg( 'visualeditor-dialog-meta-settings-index-force' )
                  Severity: Major
                  Found in modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js and 1 other location - About 4 hrs to fix
                  modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 63..78

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 132.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          new OO.ui.ButtonSelectWidget()
            .addItems( [
                new OO.ui.ButtonOptionWidget( {
                    data: 'mw:PageProp/newsectionlink',
                    label: ve.msg( 'visualeditor-dialog-meta-settings-newsectioneditlink-force' )
                  Severity: Major
                  Found in modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js and 1 other location - About 4 hrs to fix
                  modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 37..52

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 132.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              ve.dm.MWImageNode.static.getScalablePromise( this.getFilename() ).done( ( info ) => {
                this.scalable.setOriginalDimensions( {
                    width: info.width,
                    height: info.height
                } );
                  Severity: Major
                  Found in modules/ve-mw/dm/models/ve.dm.MWImageModel.js and 1 other location - About 4 hrs to fix
                  modules/ve-mw/dm/models/ve.dm.MWImageModel.js on lines 320..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 130.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language