yannickcr/eslint-plugin-react

View on GitHub

Showing 710 of 710 total issues

Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  create(context) {
    const config = context.options[0] || {};
    const allowInPropTypes = config.allowInPropTypes || false;

    // --------------------------------------------------------------------------
Severity: Minor
Found in lib/rules/forbid-foreign-prop-types.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  create(context) {
    const config = context.options[0] || {};
    const allowGlobals = config.allowGlobals || false;

    /**
Severity: Minor
Found in lib/rules/jsx-no-undef.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create: Components.detect((context, components) => {
    const configuration = context.options[0] || {};
    let fileVarType = 'var';

    const namedConfig = [].concat(
Severity: Major
Found in lib/rules/function-component-definition.js - About 3 hrs to fix

    Function create has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      create(context) {
        const configuration = Object.assign(
          {
            allowReferrer: false,
            warnOnSpreadAttributes: false,
    Severity: Major
    Found in lib/rules/jsx-no-target-blank.js - About 3 hrs to fix

      Function create has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        create(context) {
          const config = context.options[0] || {};
          const allowExpressions = config.allowExpressions || false;
      
          const reactPragma = pragmaUtil.getFromContext(context);
      Severity: Major
      Found in lib/rules/jsx-no-useless-fragment.js - About 3 hrs to fix

        Function create has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

          create(context) {
            const configuration = context.options[0] || {};
        
            function isFunction(node) {
              return configuration.allowFunctions && (node.type === 'ArrowFunctionExpression' || node.type === 'FunctionExpression');
        Severity: Minor
        Found in lib/rules/no-children-prop.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function create has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

          create: Components.detect((context, components, utils) => {
            // variables should be defined here
            const options = context.options;
            const defaultCheckType = options[0] || STATIC_PUBLIC_FIELD;
            const hasAdditionalConfig = options.length > 1;
        Severity: Minor
        Found in lib/rules/static-property-placement.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getFragmentFromContext(context) {
          let pragma = 'Fragment';
          // .eslintrc shared settings (https://eslint.org/docs/user-guide/configuring#adding-shared-settings)
          if (context.settings.react && context.settings.react.fragment) {
            pragma = context.settings.react.fragment;
        Severity: Major
        Found in lib/util/pragma.js and 1 other location - About 3 hrs to fix
        lib/util/pragma.js on lines 18..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getCreateClassFromContext(context) {
          let pragma = 'createReactClass';
          // .eslintrc shared settings (https://eslint.org/docs/user-guide/configuring#adding-shared-settings)
          if (context.settings.react && context.settings.react.createClass) {
            pragma = context.settings.react.createClass;
        Severity: Major
        Found in lib/util/pragma.js and 1 other location - About 3 hrs to fix
        lib/util/pragma.js on lines 34..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function buildReactDeclarationTypes has 93 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function buildReactDeclarationTypes(value, parentName, rootNode) {
            if (
              value
              && value.callee
              && value.callee.object
        Severity: Major
        Found in lib/util/propTypes.js - About 3 hrs to fix

          Function create has 92 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            create(context) {
              function findSpreadVariable(node, name) {
                return variableUtil.getVariableFromContext(context, node, name);
              }
              /**
          Severity: Major
          Found in lib/rules/no-danger-with-children.js - About 3 hrs to fix

            File boolean-prop-naming.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /**
             * @fileoverview Enforces consistent naming for boolean props
             * @author Ev Haus
             */
            
            
            Severity: Minor
            Found in lib/rules/boolean-prop-naming.js - About 3 hrs to fix

              Function create has 90 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                create(context) {
                  const configuration = Object.assign({}, optionDefaults, context.options[0]);
              
                  function reportMissing(node) {
                    report(context, messages.missingType, 'missingType', {
              Severity: Major
              Found in lib/rules/button-has-type.js - About 3 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    function checkNode(node) {
                      if (!node) {
                        return;
                      }
                      if (node.type === 'ObjectExpression') {
                Severity: Major
                Found in lib/rules/sort-default-props.js and 1 other location - About 3 hrs to fix
                lib/rules/jsx-sort-default-props.js on lines 150..162

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    function checkNode(node) {
                      if (!node) {
                        return;
                      }
                      if (node.type === 'ObjectExpression') {
                Severity: Major
                Found in lib/rules/jsx-sort-default-props.js and 1 other location - About 3 hrs to fix
                lib/rules/sort-default-props.js on lines 144..156

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function create has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                Open

                  create(context) {
                    const configuration = context.options[0] || 'syntax';
                    const reactPragma = pragmaUtil.getFromContext(context);
                    const fragmentPragma = pragmaUtil.getFragmentFromContext(context);
                    const openFragShort = '<>';
                Severity: Minor
                Found in lib/rules/jsx-fragments.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function create has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                Open

                  create(context) {
                    function isPrefixDisabled(prefix) {
                      return prefix === false;
                    }
                
                
                Severity: Minor
                Found in lib/rules/jsx-handler-names.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function create has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                Open

                  create: Components.detect((context, components, utils) => {
                    /**
                     * Checks if the component is valid
                     * @param {Object} component The component to process
                     * @returns {boolean} True if the component is valid, false if not.
                Severity: Minor
                Found in lib/rules/no-direct-mutation-state.js - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function JSXOpeningElement has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      JSXOpeningElement(node) {
                        // `dangerouslySetInnerHTML` is only "reserved" on DOM components
                        const nodeReservedList = reservedFirst && !jsxUtil.isDOMComponent(node) ? reservedList.filter((prop) => prop !== 'dangerouslySetInnerHTML') : reservedList;
                
                        node.attributes.reduce((memo, decl, idx, attrs) => {
                Severity: Major
                Found in lib/rules/jsx-sort-props.js - About 3 hrs to fix

                  Function create has 88 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    create(context) {
                      const DEFAULT_DEPTH = 2;
                  
                      const option = context.options[0] || {};
                      const maxDepth = has(option, 'max') ? option.max : DEFAULT_DEPTH;
                  Severity: Major
                  Found in lib/rules/jsx-max-depth.js - About 3 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language