Sign upLogin

zkoss/zk

View on GitHub
Star

Showing 4,841 of 7,782 total issues

Method remove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean remove(Object o) {
        boolean ret = false;
        if (_set.contains(o)) {
            //bug #1819318 Problem while using SortedSet with Databinding
            removeFromSelection(o);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/ListModelSet.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method clone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Object clone() {
        final Radiogroup clone = (Radiogroup) super.clone();
        fixClone(clone);
        if (clone._model != null) {
            if (clone._model instanceof ComponentCloneListener) {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Radiogroup.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setMode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void setMode(String name) {
        if ("popup".equals(name))
            doPopup();
        else if ("overlapped".equals(name))
            doOverlapped();
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Window.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getTheme has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public String getTheme(HttpServletRequest request) {
        Cookie[] cookies = request.getCookies();
        if (cookies == null)
            return "";
        for (Cookie c : cookies) {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/theme/CookieThemeResolver.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setSelectAll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        public void setSelectAll(boolean selectAll) {
            if (selectAll) {
                List<E> all = new LinkedList<>();
                for (int i = 0, j = model.getSize(); i < j; i++) {
                    E o = model.getElementAt(i);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/AbstractListModel.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getLinkedPanel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Tabpanel getLinkedPanel() {
        final int j = getIndex();
        if (j >= 0) {
            final Tabbox tabbox = getTabbox();
            if (tabbox != null) {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Tab.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected void renderProperties(org.zkoss.zk.ui.sys.ContentRenderer renderer) throws java.io.IOException {
        super.renderProperties(renderer);

        render(renderer, "title", _title);
        render(renderer, "maximized", _maximized);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Window.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getPagingEvent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static final PagingEvent getPagingEvent(AuRequest request) {
        final Component comp = request.getComponent();
        final Map<String, Object> data = request.getData();
        int pgi = AuRequests.getInt(data, "", 0);
        final Pageable pageable = (Pageable) comp;
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/event/PagingEvent.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method beforeChildAdded has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void beforeChildAdded(Component child, Component refChild) {
        if (child instanceof Caption) {
            if (_caption != null && _caption != child)
                throw new UiException("Only one caption is allowed: " + this);
            super.beforeChildAdded(child, refChild);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Tab.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getLabel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public String getLabel() {
        final Component cell = getFirstChild();
        if (cell != null) {
            if (cell instanceof Label)
                return ((Label) cell).getValue();
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Group.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onInitRender has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("rawtypes")
    public void onInitRender(Event data) {
        //Bug #2010389
        removeAttribute(ZUL_RADIOGROUP_ON_INITRENDER); //clear syncModel flag
        final Renderer renderer = new Renderer();
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Radiogroup.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method isEventThreadEnabled has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private boolean isEventThreadEnabled(boolean attachedRequired) {
        Desktop desktop = getDesktop();
        if (desktop == null) {
            if (attachedRequired)
                throw new SuspendNotAllowedException("Not attached, " + this);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Window.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method renderProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected void renderProperties(org.zkoss.zk.ui.sys.ContentRenderer renderer) throws java.io.IOException {
        super.renderProperties(renderer);
        if (_columns > 0)
            renderer.render("columns", _columns);
        if (_columns > 0 && _start > 0)
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Frozen.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkOverlappable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private void checkOverlappable(int mode) {
        if (!"false".equals(getDraggable()))
            throw new UiException("Draggable window cannot be modal, overlapped, popup, or highlighted: " + this);

        if (mode == MODAL)
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Window.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMedia has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        public Media getMedia(String pathInfo) {
            if (pathInfo != null) {
                int j = pathInfo.indexOf('/', 1);
                if (j >= 0) {
                    int k = pathInfo.indexOf('/', ++j);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Image.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addOpenPaths has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean addOpenPaths(int[][] paths) {
        boolean added = false;
        final int len = paths != null ? paths.length : 0;
        for (int j = 0; j < len; ++j) {
            if (paths[j] != null) {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/AbstractTreeModel.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getLinkedTab has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public Tab getLinkedTab() {
        final int j = getIndex();
        if (j >= 0) {
            final Tabbox tabbox = getTabbox();
            if (tabbox != null) {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Tabpanel.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setMold has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void setMold(String mold) {
        if (isVertical()) {
            if (mold.startsWith("scale")) {
                throw new WrongValueException("Unsupported vertical orient in mold : " + mold);
            } else {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Slider.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method removeSelectionPaths has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean removeSelectionPaths(int[][] paths) {
        boolean found = false;
        final int len = paths != null ? paths.length : 0;
        for (int j = 0; j < len && !_selection.isEmpty(); ++j) {
            final Path path = new Path(paths[j]);
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/AbstractTreeModel.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setMold has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void setMold(String mold) {
        if (isVertical()) {
            if (mold.startsWith("accordion")) {
                throw new WrongValueException("Unsupported vertical orient in mold : " + mold);
            } else {
Severity: Minor
Found in zul/src/main/java/org/zkoss/zul/Tabbox.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language