Sign upLogin

zkoss/zk

View on GitHub
Star
zkbind/src/main/resources/web/js/zkbind/Binder.ts

Summary

Maintainability
D
2 days
Test Coverage

Function _matchMedia has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function _matchMedia(event: MediaQueryListEvent | MediaQueryList, binder: Binder, value: string): void {
    var cookies = binder._cookies!;
    if (event.matches) {
        var orient = '',
            dpr = 1;
Severity: Minor
Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function unAfter has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    unAfter(cmd: string, fn: CallableFunction): this {
        var ac = this._aftercmd![cmd];
        for (var j = ac ? ac.length : 0; j--;) {
            if (ac[j] == fn) {
                if (!this._processingAfterCommand)
Severity: Minor
Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor(widget: zk.Widget, currentTarget: object) {
        super(); // FIXME: params?
        this.$view = widget;
        this.$currentTarget = currentTarget;
        this._aftercmd = {};
Severity: Minor
Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 1 hr to fix

    Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor(widget: zk.Widget, currentTarget: object) {
        super(); // FIXME: params?
        this.$view = widget;
        this.$currentTarget = currentTarget;
        this._aftercmd = {};
    Severity: Minor
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function $doAfterCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        $doAfterCommand(cmd: string, args?: unknown[]): void {
        var ac = this._aftercmd![cmd],
            tduac = this._toDoUnAftercmd[cmd];
        this._processingAfterCommand = true; // ZK-4482
        for (var i = 0, j = ac ? ac.length : 0; i < j; i++)
    Severity: Minor
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function globalCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        globalCommand(cmd: string, args?: Record<string, unknown>, opts?: zk.EventOptions, timeout?: number): this {
        var wgt = this.$view;
        if (opts) {
            if (opts.duplicateIgnore)
                _fixCommandName('onBindGlobalCommand$', cmd, opts, 'duplicateIgnore');
    Severity: Minor
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function $binder has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        $binder(): zkbind.Binder | undefined {
        // eslint-disable-next-line @typescript-eslint/no-this-alias
        var w: zk.Widget | undefined = this;
        for (; w; w = w.parent) {
            if (w.$ZKBINDER$)
    Severity: Minor
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        command(cmd: string, args?: Record<string, unknown>, opts?: zk.EventOptions, timeout?: number): this {
        var wgt = this.$view;
        if (opts) {
            if (opts.duplicateIgnore)
                _fixCommandName('onBindCommand$', cmd, opts, 'duplicateIgnore');
    Severity: Minor
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        command(cmd: string, args?: Record<string, unknown>, opts?: zk.EventOptions, timeout?: number): this {
        var wgt = this.$view;
        if (opts) {
            if (opts.duplicateIgnore)
                _fixCommandName('onBindCommand$', cmd, opts, 'duplicateIgnore');
    Severity: Major
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts and 1 other location - About 5 hrs to fix
    zkbind/src/main/resources/web/js/zkbind/Binder.ts on lines 292..303

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        globalCommand(cmd: string, args?: Record<string, unknown>, opts?: zk.EventOptions, timeout?: number): this {
        var wgt = this.$view;
        if (opts) {
            if (opts.duplicateIgnore)
                _fixCommandName('onBindGlobalCommand$', cmd, opts, 'duplicateIgnore');
    Severity: Major
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts and 1 other location - About 5 hrs to fix
    zkbind/src/main/resources/web/js/zkbind/Binder.ts on lines 272..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 135.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static postGlobalCommand(dom: HTMLElement, command: string, args?: Record<string, unknown>, opt?: zk.EventOptions, timeout?: number): void {
        var w = zk.Widget.$(dom);
        if (w) {
            var binder = w.$binder();
            if (binder) {
    Severity: Major
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts and 1 other location - About 1 hr to fix
    zkbind/src/main/resources/web/js/zkbind/Binder.ts on lines 336..344

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        static postCommand(dom: HTMLElement, command: string, args?: Record<string, unknown>, opt?: zk.EventOptions, timeout?: number): void {
        var w = zk.Widget.$(dom);
        if (w) {
            var binder = w.$binder();
            if (binder) {
    Severity: Major
    Found in zkbind/src/main/resources/web/js/zkbind/Binder.ts and 1 other location - About 1 hr to fix
    zkbind/src/main/resources/web/js/zkbind/Binder.ts on lines 353..361

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status