Sign upLogin

zkoss/zk

View on GitHub
Star
zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java

Summary

Maintainability
F
5 days
Test Coverage

Method render has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public void render(ActionContext ac, boolean nested) throws DspException, IOException {
        //at least items or end must be specified
        if (!nested || (_itemsSpecified && _items == null) || (_endSpecified && _end < _beg)
                || (!_itemsSpecified && !_endSpecified) || !isEffective())
            return;
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ForEach.java has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* ForEach.java

    Purpose:
        
    Description:
Severity: Minor
Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 4 hrs to fix

    ForEach has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class ForEach extends AbstractAction {
    private String _var, _varStatus;
    private Object _items;
    private int _beg = 0, _end = Integer.MAX_VALUE;
    private boolean _trim;
    Severity: Minor
    Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 3 hrs to fix

      Method renderWith has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          private void renderWith(ActionContext ac, Status st, String txt) throws DspException, IOException {
        final StringBuffer sb = new StringBuffer();
        int idx = 0;
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg, len = txt.length(); j < len && j <= _end; ++j) {
      Severity: Minor
      Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void render(ActionContext ac, boolean nested) throws DspException, IOException {
        //at least items or end must be specified
        if (!nested || (_itemsSpecified && _items == null) || (_endSpecified && _end < _beg)
                || (!_itemsSpecified && !_endSpecified) || !isEffective())
            return;
      Severity: Major
      Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 2 hrs to fix

        Method renderWith has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void renderWith(ActionContext ac, Status st, String txt) throws DspException, IOException {
        final StringBuffer sb = new StringBuffer();
        int idx = 0;
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg, len = txt.length(); j < len && j <= _end; ++j) {
        Severity: Minor
        Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                  if (!nested || (_itemsSpecified && _items == null) || (_endSpecified && _end < _beg)
                || (!_itemsSpecified && !_endSpecified) || !isEffective())
            return;
          Severity: Critical
          Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 1 hr to fix

            Method renderWith has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, Iterator it) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);

        for (int j = 0; ++j <= _beg && it.hasNext();) //skip
            it.next();
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, Enumeration enm) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);

        for (int j = 0; ++j <= _beg && enm.hasMoreElements();) //skip
            enm.nextElement();
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, float[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Float(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, long[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Long(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, double[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Double(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, Object[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = ary[j];
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, byte[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Byte(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, ListIterator it) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = 0, cnt = _end - _beg + 1; it.hasNext() && --cnt >= 0; ++j) {
            final Object val = it.next();
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, short[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Short(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, int[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Integer(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, char[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Character(ary[j]);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method renderWith has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j <= _end; ++j) {
            final Object val = new Integer(j);
            if (_var != null)
            Severity: Minor
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, Iterator it) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);

        for (int j = 0; ++j <= _beg && it.hasNext();) //skip
            it.next();
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 1 other location - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 228..244

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, Enumeration enm) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);

        for (int j = 0; ++j <= _beg && enm.hasMoreElements();) //skip
            enm.nextElement();
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 1 other location - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 210..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 166.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, double[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Double(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, short[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Short(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, byte[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Byte(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, float[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Float(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, int[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Integer(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, long[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Long(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 302..314
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                private void renderWith(ActionContext ac, Status st, char[] ary) throws DspException, IOException {
        final StringWriter out = getFragmentOut(ac, _trim);
        for (int j = _beg; j < ary.length && j <= _end; ++j) {
            final Object val = new Character(ary[j]);
            if (_var != null)
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 6 other locations - About 2 hrs to fix
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 260..272
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 274..286
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 288..300
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 316..328
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 330..342
            zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java on lines 344..356

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 132.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            switch (cc) {
                case 'n':
                    cc = '\n';
                    break;
                case 'r':
            Severity: Major
            Found in zweb/src/main/java/org/zkoss/web/servlet/dsp/action/ForEach.java and 2 other locations - About 50 mins to fix
            zcommon/src/main/java/org/zkoss/lang/Strings.java on lines 481..486
            zcommon/src/main/java/org/zkoss/lang/Strings.java on lines 527..532

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status