Floppy/carbon-diet

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Form.Element.EventObserver = Class.create(Abstract.EventObserver, {
  getValue: function() {
    return Form.Element.getValue(this.element);
  }
});

Found in app/assets/javascripts/standard/prototype.js and 1 other location - About 1 hr to fix

Read up
Read up

app/assets/javascripts/standard/prototype.js on lines 5187..5191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `ATTR` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        ATTR: function(elem, match){
            var name = match[1],
                result = Expr.attrHandle[ name ] ?
                    Expr.attrHandle[ name ]( elem ) :
                    elem[ name ] != null ?

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Function `serializeElements` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  serializeElements: function(elements, options) {
    if (typeof options != 'object') options = { hash: !!options };
    else if (Object.isUndefined(options.hash)) options.hash = true;
    var key, value, submitted = false, submit = options.submit, accumulator, initial;

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Function `dirNodeCheck` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function dirNodeCheck( dir, cur, doneName, checkSet, nodeCheck, isXML ) {
    var sibDir = dir == "previousSibling" && !isXML;
    for ( var i = 0, l = checkSet.length; i < l; i++ ) {
        var elem = checkSet[i];
        if ( elem ) {

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Function `scroll` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  scroll: function() {
    var current = new Date();
    var delta = current - this.lastScrolled;
    this.lastScrolled = current;
    if(this.options.scroll == window) {

Found in app/assets/javascripts/standard/dragdrop.js - About 1 hr to fix

Method `index` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    if not @current_user.nil? and (params[:login] == @current_user.login or params[:login].nil?)
      @profile = @current_user
    else
      @profile = User.find_by_login_and_public(params[:login], true)

Found in app/controllers/profile_controller.rb - About 1 hr to fix

Function `updateElement` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  updateElement: function(selectedElement) {
    if (this.options.updateElement) {
      this.options.updateElement(selectedElement);
      return;
    }

Found in app/assets/javascripts/standard/controls.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `startDrag` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  startDrag: function(event) {
    this.dragging = true;
    if(!this.delta)
      this.delta = this.currentDelta();

Found in app/assets/javascripts/standard/dragdrop.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `scroll` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  scroll: function() {
    var current = new Date();
    var delta = current - this.lastScrolled;
    this.lastScrolled = current;
    if(this.options.scroll == window) {

Found in app/assets/javascripts/standard/dragdrop.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `readAttribute` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  readAttribute: function(element, name) {
    element = $(element);
    if (Prototype.Browser.IE) {
      var t = Element._attributeTranslations.read;
      if (t.values[name]) return t.values[name](element, name);

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `replace` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  Element.Methods.replace = function(element, content) {
    element = $(element);

    if (content && content.toElement) content = content.toElement();
    if (Object.isElement(content)) {

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `get_current_user` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def get_current_user
    return @current_user if @current_user
    if session[:user_id]
      @current_user = User.find_by_id(session[:user_id])
      # If we have a user ID with no user attached, reset session

Found in app/controllers/application_controller.rb - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `validate` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def validate
    unless distance.nil?
      # Find distance immediately before this one, and the one immediately after
      previous = vehicle.vehicle_fuel_purchases.where("purchased_on < ? AND distance IS NOT NULL", purchased_on).order("purchased_on DESC").first
      subsequent = vehicle.vehicle_fuel_purchases.where("purchased_on > ? AND distance IS NOT NULL", purchased_on).order("purchased_on ASC").first

Found in app/models/vehicle_fuel_purchase.rb - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `validate_order` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_order
    # Find reading immediately before this one, and the one immediately after
    previous = electricity_account.electricity_readings.where("taken_on < ?", taken_on).order("taken_on DESC").first
    subsequent = electricity_account.electricity_readings.where("taken_on > ?", taken_on).order("taken_on ASC").first
    # Check readings, make sure they're in sequence

Found in app/models/electricity_reading.rb - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `signup` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def signup
    # Confirm password
    if session[:password] != params[:user][:password_confirmation]
      flash[:notice] = "Passwords did not match, please check and try again"
    # Everything checks out...

Found in app/controllers/user_controller.rb - About 1 hr to fix

Method `amline_settings` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def amline_settings(period)
    case period
    when 0..90
      avg_period = 3
    when 91..365

Found in app/controllers/reports_controller.rb - About 1 hr to fix

Function `getElementsByClassName` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

if (!document.getElementsByClassName) document.getElementsByClassName = function(instanceMethods){
  function iter(name) {
    return name.blank() ? null : "[contains(concat(' ', @class, ' '), ' " + name + " ')]";
  }

Found in app/assets/javascripts/standard/prototype.js - About 1 hr to fix

Function `insertPages` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    insertPages: function(frag)
    {
        var nodes = frag.childNodes;
        var targetPage;
        for (var i = 0; i < nodes.length; ++i)

Found in public/iui/iui.js - About 1 hr to fix

Function `SlideUp` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Effect.SlideUp = function(element) {
  element = $(element).cleanWhitespace();
  var oldInnerBottom = element.down().getStyle('bottom');
  var elementDimensions = element.getDimensions();
  return new Effect.Scale(element, window.opera ? 0 : 1,

Found in app/assets/javascripts/standard/effects.js - About 1 hr to fix

Function `initialize` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  initialize: function(element) {
    this.element = $(element);
    if (!this.element) throw(Effect._elementDoesNotExistError);
    var options = Object.extend({
      style: { }

Found in app/assets/javascripts/standard/effects.js - About 1 hr to fix