GemsTracker/gemstracker-library

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function createAfterWaitDays($filter, $respTrack)
    {
        $createTrack = true;
        $curr        = $this->getAdmissionTime();
        $end         = $respTrack->getEndDate();

Found in classes/Gems/Agenda/Appointment.php and 1 other location - About 7 hrs to fix

Read up
Read up

classes/Gems/Agenda/Appointment.php on lines 306..344

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function createFromStart($filter, $respTrack)
    {
        $createTrack = true;
        $curr        = $this->getAdmissionTime();
        $start       = $respTrack->getStartDate();

Found in classes/Gems/Agenda/Appointment.php and 1 other location - About 7 hrs to fix

Read up
Read up

classes/Gems/Agenda/Appointment.php on lines 227..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 240.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

`Gems_Menu_SubMenuItem` has 54 functions (exceeds 20 allowed). Consider refactoring.
Open

class Gems_Menu_SubMenuItem extends \Gems_Menu_MenuAbstract
{
    private $_hiddenOrgId;
    private $_hiddenParameters = array();  // Added to $request by applyHiddenParameters
    private $_itemOptions;

Found in classes/Gems/Menu/SubMenuItem.php - About 7 hrs to fix

File `SurveyCompareSnippet.php` has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Gems\Snippets\Survey;

class SurveyCompareSnippet extends \MUtil_Snippets_WizardFormSnippetAbstract {

Found in classes/Gems/Snippets/Survey/SurveyCompareSnippet.php - About 7 hrs to fix

Function `getModel` has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    public function getModel()
    {
        if ($this->batch) {
            $model = $this->batch->getVariable('model');
        } else {

Found in classes/Gems/Export/ExportAbstract.php - About 7 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

File `Appointment.php` has 472 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Agenda/Appointment.php - About 7 hrs to fix

Function `_getMap` has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _getMap()
    {
        $cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
        $this->_fieldMap = $this->cache->load($cacheId);

Found in classes/Gems/Tracker/Source/LimeSurvey1m9FieldMap.php - About 7 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `_getMap` has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _getMap()
    {
        $cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
        $this->_fieldMap = $this->cache->load($cacheId);

Found in classes/Gems/Tracker/Source/LimeSurvey4m00FieldMap.php - About 7 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getHtmlOutput` has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    public function getHtmlOutput(\Zend_View_Abstract $view)
    {
        $this->_initView($view);

        $main = $this->creator->div(array('class' => 'panel panel-default', 'id' => 'trackwrapper', 'renderClosingTag' => true));

Found in classes/Gems/Snippets/Respondent/TrafficLightTokenSnippet.php - About 7 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

`Gems_Default_TrackAction` has 51 functions (exceeds 20 allowed). Consider refactoring.
Open

class Gems_Default_TrackAction extends \Gems_Default_RespondentChildActionAbstract
{
    /**
     *
     * @var \Gems_AccessLog

Found in classes/Gems/Default/TrackAction.php - About 7 hrs to fix

Method `createModel` has 178 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createModel($detailed, $action)
    {
        $dbLookup   = $this->util->getDbLookup();
        $dbTracks   = $this->util->getTrackData();
        $commUtil   = $this->util->getCommJobsUtil();

Found in classes/Gems/Default/CommJobAction.php - About 7 hrs to fix

File `InsertSurveySnippet.php` has 456 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Snippets/Tracker/InsertSurveySnippet.php - About 6 hrs to fix

File `DatabaseAction.php` has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Default/DatabaseAction.php - About 6 hrs to fix

`Gems_Tracker_Engine_TrackEngineAbstract` has 49 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Gems_Tracker_Engine_TrackEngineAbstract extends \MUtil_Translate_TranslateableAbstract implements \Gems_Tracker_Engine_TrackEngineInterface
{
    use DbTranslateUtilTrait;
    
    /**

Found in classes/Gems/Tracker/Engine/TrackEngineAbstract.php - About 6 hrs to fix

Function `checkTokenCompletion` has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkTokenCompletion($userId)
    {
        $result = self::COMPLETION_NOCHANGE;

        // Some defaults

Found in classes/Gems/Tracker/Token.php - About 6 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `exportAction` has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function exportAction()
    {
        $step = $this->request->getParam('step');
        $post = $this->request->getPost();

Found in classes/Gems/Controller/ModelSnippetActionAbstract.php - About 6 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

`Gems_Tracker_Survey` has 48 functions (exceeds 20 allowed). Consider refactoring.
Open

class Gems_Tracker_Survey extends \Gems_Registry_CachedArrayTargetAbstract
{
    /**
     * Variable to add tags to the cache for cleanup.
     *

Found in classes/Gems/Tracker/Survey.php - About 6 hrs to fix

File `DbLookup.php` has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Util/DbLookup.php - About 6 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Snippets/ConditionDeleteSnippet.php and 1 other location - About 6 hrs to fix

Read up
Read up

classes/Gems/Snippets/Track/TrackDeleteSnippet.php on lines 1..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 216.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems

Found in classes/Gems/Snippets/Track/TrackDeleteSnippet.php and 1 other location - About 6 hrs to fix

Read up
Read up

classes/Gems/Snippets/ConditionDeleteSnippet.php on lines 1..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 216.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76