Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star

Showing 4,260 of 4,272 total issues

Function appendFiltersChecked has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    protected function appendFiltersChecked(\MUtil_Html_Sequence $seq)
    {
        $seq->h2($this->_('Creation by filter check'));

        $filters = $this->tracer->getFilters();
Severity: Minor
Found in classes/Gems/Snippets/Agenda/AppointmentCheckSnippet.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _getMap has 161 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _getMap()
    {
        $cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
        $this->_fieldMap = $this->cache->load($cacheId);
Severity: Major
Found in classes/Gems/Tracker/Source/LimeSurvey4m00FieldMap.php - About 6 hrs to fix

    File OpenRosa.php has 434 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 *
 * @package    Gems
    Severity: Minor
    Found in classes/OpenRosa/Tracker/Source/OpenRosa.php - About 6 hrs to fix

      Method _getMap has 158 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _getMap()
    {
        $cacheId = 'lsFieldMap'.$this->sourceId . '_'.$this->sourceSurveyId.strtr($this->language, '-.', '__');
        $this->_fieldMap = $this->cache->load($cacheId);
      Severity: Major
      Found in classes/Gems/Tracker/Source/LimeSurvey1m9FieldMap.php - About 6 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($batch->isFinished()) {
            $this->nextDisabled = $batch->getCounter('create_errors');
            $batch->autoStart   = false;

            // Keep the filename after $batch->getMessages(true) cleared the previous
        Severity: Major
        Found in classes/Gems/Tracker/Snippets/ImportTrackSnippetAbstract.php and 1 other location - About 6 hrs to fix
        classes/Gems/Tracker/Snippets/ImportTrackSnippetAbstract.php on lines 501..526

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 210.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if ($batch->isFinished()) {
            $this->nextDisabled = $batch->getCounter('create_errors');
            $batch->autoStart   = false;

            // Keep the filename after $batch->getMessages(true) cleared the previous
        Severity: Major
        Found in classes/Gems/Tracker/Snippets/ImportTrackSnippetAbstract.php and 1 other location - About 6 hrs to fix
        classes/Gems/Tracker/Snippets/ImportTrackSnippetAbstract.php on lines 301..326

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 210.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function isRequestFromAllowedHost has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
        Open

            public function isRequestFromAllowedHost(\Zend_Controller_Request_Abstract $request)
    {
        if (\MUtil_Console::isConsole() || \Zend_Session::$_unitTestEnabled) {
            return null;
        }
        Severity: Minor
        Found in classes/Gems/Util/SiteUtil.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getAutoSearchForm has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getAutoSearchForm()
    {
        $data = $this->getSearchData();
        // \MUtil_Echo::track($data);
        Severity: Minor
        Found in classes/Gems/Snippets/AutosearchFormSnippet.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method checkSurvey has 156 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function checkSurvey($sourceSurveyId, $surveyId, $userId)
    {
        $messages = array();
        $survey   = $this->tracker->getSurvey($surveyId);
        Severity: Major
        Found in classes/Gems/Tracker/Source/LimeSurvey1m9Database.php - About 6 hrs to fix

          Function addSpssFile has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function addSpssFile($filename)
    {
        $model       = $this->model;
        $files       = $this->getFiles();
        $datFileName = array_search($filename, $files);
          Severity: Minor
          Found in classes/Gems/Export/SpssExport.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _loadAllTraversable has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _loadAllTraversable()
    {
        $data  = array();

        foreach (array_reverse($this->directories) as $pathData) {
          Severity: Minor
          Found in classes/Gems/Model/DbaModel.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _toRouteArray has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _toRouteArray(\Gems_Menu_ParameterCollector $source)
    {
        if ($this->get('allowed')) {
            $result = array();
            if ($this->_applyParameterSources($source, $result, true)) {
          Severity: Minor
          Found in classes/Gems/Menu/SubMenuItem.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getChart has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getChart()
    {
        $token = $this->token;
        $data = $this->data;
          Severity: Minor
          Found in classes/Gems/Snippets/Survey/Display/BarChartSnippet.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File FieldsDefinition.php has 411 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

/**
 *
 * @package    Gems
          Severity: Minor
          Found in classes/Gems/Tracker/Engine/FieldsDefinition.php - About 5 hrs to fix

            Gems_Tracker_Source_LimeSurvey1m9Database has 43 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Gems_Tracker_Source_LimeSurvey1m9Database extends \Gems_Tracker_Source_SourceAbstract
{
    const CACHE_TOKEN_INFO = 'tokenInfo';

    const LS_DB_COMPLETION_FORMAT = 'yyyy-MM-dd HH:mm';
            Severity: Minor
            Found in classes/Gems/Tracker/Source/LimeSurvey1m9Database.php - About 5 hrs to fix

              Gems_Tracker has 43 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Gems_Tracker extends \Gems_Loader_TargetLoaderAbstract implements \Gems_Tracker_TrackerInterface
{
    const DB_DATE_FORMAT = 'yyyy-MM-dd';
    const DB_DATETIME_FORMAT = 'yyyy-MM-dd HH:mm:ss';
              Severity: Minor
              Found in classes/Gems/Tracker.php - About 5 hrs to fix

                Method getRoundModel has 145 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getRoundModel($detailed, $action)
    {
        $model = parent::getRoundModel($detailed, $action);

        // Add information about surveys and groups
                Severity: Major
                Found in classes/Gems/Tracker/Engine/StepEngineAbstract.php - About 5 hrs to fix

                  Method applySystemUserSettings has 145 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function applySystemUserSettings($detailed, $action)
    {
        $this->addLeftTable('gems__systemuser_setup', ['gsf_id_user' => 'gsus_id_user'], 'gsus');
        $this->resetOrder();
                  Severity: Major
                  Found in classes/Gems/Model/StaffModel.php - About 5 hrs to fix

                    Function _getTracks has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function _getTracks($trackType, $pageRef, $trackTypeDescription)
    {
        switch ($trackType) {
            case 'tracks':
                $action = 'create';
                    Severity: Minor
                    Found in classes/Gems/Snippets/Tracker/AddTracksSnippet.php - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method createModel has 143 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function createModel()
    {
        $groupby['period_1'] = new \Zend_Db_Expr("YEAR($this->dateFrom)");

        $date = new \MUtil_Date();
                    Severity: Major
                    Found in classes/Gems/Selector/DateSelectorAbstract.php - About 5 hrs to fix
                      Severity
                      Category
                      Status
                      Source
                      Language