Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star

Showing 4,260 of 4,272 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    protected function _getMultiOptions($field)
    {
        $scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
        $qid     = $field['qid'];
Severity: Major
Found in classes/Gems/Tracker/Source/LimeSurvey1m9FieldMap.php and 1 other location - About 5 hrs to fix
classes/Gems/Tracker/Source/LimeSurvey4m00FieldMap.php on lines 302..340

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 198.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    protected function _getMultiOptions($field)
    {
        $scaleId = isset($field['scale_id']) ? $field['scale_id'] : 0;
        $qid     = $field['qid'];
Severity: Major
Found in classes/Gems/Tracker/Source/LimeSurvey4m00FieldMap.php and 1 other location - About 5 hrs to fix
classes/Gems/Tracker/Source/LimeSurvey1m9FieldMap.php on lines 395..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 198.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File ExportAbstract.php has 403 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems
Severity: Minor
Found in classes/Gems/Export/ExportAbstract.php - About 5 hrs to fix

    File TokenData.php has 402 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 *
 * @package    Gems
    Severity: Minor
    Found in classes/Gems/Util/TokenData.php - About 5 hrs to fix

      Function getProfile has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getProfile()
    {
        $queries = '';
        foreach ($this->_db as $name => $adapter) {
            if ($profiles = $adapter->getProfiler()->getQueryProfiles()) {
      Severity: Minor
      Found in classes/ZFDebug/Controller/Plugin/Debug/Plugin/Database.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function runScript has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

          public function runScript(array $data, $includeResultSets = false)
    {
        $results = array();
        if ($data['script']) {
            $queries = \MUtil_Parser_Sql_WordsParser::splitStatements($data['script'], false);
      Severity: Minor
      Found in classes/Gems/Model/DbaModel.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File SurveyMaintenanceModel.php has 399 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 *
 * @package    Gems
      Severity: Minor
      Found in classes/Gems/Model/SurveyMaintenanceModel.php - About 5 hrs to fix

        Method getHtmlOutput has 139 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getHtmlOutput(\Zend_View_Abstract $view)
    {
        $this->_initView($view);

        $main = $this->creator->div(array('class' => 'panel panel-default', 'id' => 'trackwrapper', 'renderClosingTag' => true));
        Severity: Major
        Found in classes/Gems/Snippets/Respondent/TrafficLightTokenSnippet.php - About 5 hrs to fix

          File RespondentExport.php has 397 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

/**
 *
 * @package    Gems
          Severity: Minor
          Found in classes/Gems/Export/RespondentExport.php - About 5 hrs to fix

            File StaffModel.php has 395 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

/**
 * The staff model
 *
            Severity: Minor
            Found in classes/Gems/Model/StaffModel.php - About 5 hrs to fix

              Method _getTracks has 137 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function _getTracks($trackType, $pageRef, $trackTypeDescription)
    {
        switch ($trackType) {
            case 'tracks':
                $action = 'create';
              Severity: Major
              Found in classes/Gems/Snippets/Tracker/AddTracksSnippet.php - About 5 hrs to fix

                File UserLoader.php has 393 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

/**
 *
 * @package    Gems
                Severity: Minor
                Found in classes/Gems/User/UserLoader.php - About 5 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      protected function getUserSelect($login_name, $organization)
    {
        /**
         * Read the needed parameters from the different tables, lots of renames
         * for compatibility across implementations.
                  Severity: Major
                  Found in classes/Gems/User/RadiusUserDefinition.php and 1 other location - About 5 hrs to fix
                  classes/Gems/User/LdapUserDefinition.php on lines 115..156

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 191.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      protected function getUserSelect($login_name, $organization)
    {
        /**
         * Read the needed parameters from the different tables, lots of renames
         * for compatibility across implementations.
                  Severity: Major
                  Found in classes/Gems/User/LdapUserDefinition.php and 1 other location - About 5 hrs to fix
                  classes/Gems/User/RadiusUserDefinition.php on lines 191..232

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 191.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method getModel has 134 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getModel()
    {
        if (empty($this->model)) {
            try {
                $model = new \Gems_Model_JoinModel($this->getFormID(), $this->getTableName(), 'orf');
                  Severity: Major
                  Found in classes/OpenRosa/Tracker/Source/Form.php - About 5 hrs to fix

                    Gems_Agenda_Appointment has 40 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Gems_Agenda_Appointment extends \MUtil_Translate_TranslateableAbstract
{
    /**
     *
     * @var int The id of the appointment
                    Severity: Minor
                    Found in classes/Gems/Agenda/Appointment.php - About 5 hrs to fix

                      Gems_User_Organization has 40 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Gems_User_Organization extends \Gems_Registry_CachedArrayTargetAbstract
{
    /**
     *
     * @var array of class name => class label
                      Severity: Minor
                      Found in classes/Gems/User/Organization.php - About 5 hrs to fix

                        Function getSurveysForExport has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function getSurveysForExport($trackId = null, $roundDescription = null, $flat = false, $keepSourceInactive = false)
    {
        // Read some data from tables, initialize defaults...
        $select = $this->db->select();
                        Severity: Minor
                        Found in classes/Gems/Util/DbLookup.php - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function toActionLink has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function toActionLink($parameterOrLabelSources_args = null)
    {
        if (!$this->get('allowed')) {
            return null;
        }
                        Severity: Minor
                        Found in classes/Gems/Menu/SubMenuItem.php - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function submissionAction has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function submissionAction()
    {
        $this->makeRosaResponse();

        if ($this->getRequest()->isHead()) {
                        Severity: Minor
                        Found in classes/Gems/Default/OpenrosaAction.php - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language