Sign upLogin

GemsTracker/gemstracker-library

View on GitHub
Star

Showing 4,260 of 4,272 total issues

File DateSelectorAbstract.php has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 *
 * @package    Gems
Severity: Minor
Found in classes/Gems/Selector/DateSelectorAbstract.php - About 5 hrs to fix

    Gems_Tracker_Respondent has 39 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Gems_Tracker_Respondent extends \Gems_Registry_TargetAbstract
{
    use \Gems\Translate\GenderTranslation;

    /**
    Severity: Minor
    Found in classes/Gems/Tracker/Respondent.php - About 5 hrs to fix

      Gems_Menu has 39 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Gems_Menu extends \Gems_Menu_MenuAbstract implements \MUtil_Html_HtmlInterface
{
    /**
     *
     * @var \Gems_Menu_SubMenuItem
      Severity: Minor
      Found in classes/Gems/Menu.php - About 5 hrs to fix

        Method getChanges has 128 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getChanges(array $context, $new)
    {
        // Only change anything when there are filters
        $filters = $this->loader->getAgenda()->getFilterList();
        Severity: Major
        Found in classes/Gems/Tracker/Model/Dependency/AppointmentMaintenanceDependency.php - About 5 hrs to fix

          Function _recurseForm has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _recurseForm(\Zend_Form $form)
 {
        $subFormsWithErrors = array();
        $subFormMessages = array();
        $tabId = 0;
          Severity: Minor
          Found in classes/Gems/Form/Decorator/TabErrors.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
    {
        $this->currentUser->disableMask();

        $sql = $this->db->select()->from('gems__comm_jobs')
          Severity: Minor
          Found in classes/Gems/Task/Mail/ExecuteMailJobTask.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getSearchFilter has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getSearchFilter($useRequest = true)
    {
        $filter = parent::getSearchFilter($useRequest);

        if (array_key_exists('status', $filter)) {
          Severity: Minor
          Found in classes/Gems/Default/SurveyMaintenanceAction.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getHtmlOutput has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getHtmlOutput(\Zend_View_Abstract $view)
    {
        $html = $this->getHtmlSequence();
        $org  = $this->token->getOrganization();
          Severity: Minor
          Found in classes/Gems/Snippets/Ask/ShowAllOpenSnippet.php - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _initCache has 125 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _initCache()
    {
        $this->bootstrap('project');

        $useCache = $this->getResource('project')->getCache();
          Severity: Major
          Found in classes/GemsEscort.php - About 5 hrs to fix

            File FieldMaintenanceModel.php has 374 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

/**
 *
 * @package    Gems
            Severity: Minor
            Found in classes/Gems/Tracker/Model/FieldMaintenanceModel.php - About 5 hrs to fix

              Function logEntry has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function logEntry(\Zend_Controller_Request_Abstract $request, $actionId, $changed, $message, $data, $respondentId, $actAsActive = false)
    {
        $action      = $this->getAction($actionId);
        $currentUser = $this->_loader->getCurrentUser();
              Severity: Minor
              Found in classes/Gems/AccessLog.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _toNavigationArray has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _toNavigationArray(\Gems_Menu_ParameterCollector $source)
    {
        $result = parent::_toNavigationArray($source);

        $store  = self::_getSessionStore($this->get('label'));
              Severity: Minor
              Found in classes/Gems/Menu/ContainerItem.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function _getSelectAllCached($cacheId, $sql, $binds = array(), $tags = array(), $natSort = false)
    {
        $cacheId = strtr(get_class($this) . '_a_' . $cacheId, '\\/', '__');

        $result = $this->cache->load($cacheId);
              Severity: Major
              Found in classes/Gems/Util/UtilAbstract.php and 1 other location - About 4 hrs to fix
              classes/Gems/Util/UtilAbstract.php on lines 144..168

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 181.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function _getSelectColCached($cacheId, $sql, $binds = array(), $tags = array(), $natSort = false)
    {
        $cacheId = strtr(get_class($this) . '_a_' . $cacheId, '\\/', '__');

        $result = $this->cache->load($cacheId);
              Severity: Major
              Found in classes/Gems/Util/UtilAbstract.php and 1 other location - About 4 hrs to fix
              classes/Gems/Util/UtilAbstract.php on lines 108..132

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 181.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Gems_Controller_ModelSnippetActionAbstract has 37 functions (exceeds 20 allowed). Consider refactoring.
              Open

              abstract class Gems_Controller_ModelSnippetActionAbstract extends \MUtil_Controller_ModelSnippetActionAbstract
{
    /**
     * Gems only parameters used for the autofilter action. Can be overruled
     * by setting $this->autofilterParameters
              Severity: Minor
              Found in classes/Gems/Controller/ModelSnippetActionAbstract.php - About 4 hrs to fix

                Gems_Menu_MenuAbstract has 37 functions (exceeds 20 allowed). Consider refactoring.
                Open

                abstract class Gems_Menu_MenuAbstract extends \Gems_Loader_TargetLoaderAbstract
{
    use TranslateableTrait;

    /**
                Severity: Minor
                Found in classes/Gems/Menu/MenuAbstract.php - About 4 hrs to fix

                  Method createHeaderFile has 120 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function createHeaderFile(XMLWriter $writer, $filename)
    {
        $columnHeaders = $this->getColumnHeaders();       

        if ($this->batch) {
                  Severity: Major
                  Found in classes/Gems/Export/StreamingStataExport.php - About 4 hrs to fix

                    Method execute has 120 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function execute($jobId = null, $respondentId = null, $organizationId = null, $preview = false, $forceSent = false)
    {
        $this->currentUser->disableMask();

        $sql = $this->db->select()->from('gems__comm_jobs')
                    Severity: Major
                    Found in classes/Gems/Task/Mail/ExecuteMailJobTask.php - About 4 hrs to fix

                      File AutosearchFormSnippet.php has 366 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

/**
 *
 * @package    Gems
                      Severity: Minor
                      Found in classes/Gems/Snippets/AutosearchFormSnippet.php - About 4 hrs to fix

                        File Debug.php has 365 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
/**
 * ZFDebug Zend Additions
 *
 * @category   ZFDebug
                        Severity: Minor
                        Found in classes/ZFDebug/Controller/Plugin/Debug.php - About 4 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language