IBM-Swift/Kitura

Function testBasicDeleteSingle has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testBasicDeleteSingle() {
        router.delete("/users") { (id: Int, respondWith: (RequestError?) -> Void) in
            print("DELETE on /users/\(id)")
            guard let _ = self.userStore.removeValue(forKey: id) else {
                respondWith(.notFound)

Function testBasicPut has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func testBasicPut() {
        router.put("/users") { (id: Int, user: User, respondWith: (User?, RequestError?) -> Void) in
            print("PUT on /users/\(id)")
            self.userStore[id] = user
            respondWith(user, nil)

Function constructIdentOutResultHandler has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static func constructIdentOutResultHandler<IdType: Identifier, OutputType: Codable>(successStatus: HTTPStatusCode = .OK, response: RouterResponse, completion: @escaping () -> Void) -> IdentifierCodableResultClosure<IdType, OutputType> {
        return { id, codableOutput, error in
            var status = successStatus
            if let error = error {
                status = httpStatusCode(from: error)

Function handleHeaderLine has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private func handleHeaderLine(_ line: String, part: inout Part) {
        if let labelRange = getLabelRange(of: "content-type:", in: line) {
            part.type = String(line[line.index(after: labelRange.upperBound)...])
            part.headers[.type] = line
            return

Function performServerTest has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    func performServerTest(_ router: ServerDelegate, options: ServerOptions? = nil, sslOption: SSLOption = SSLOption.both, socketTypeOption: SocketTypeOption = SocketTypeOption.both, timeout: TimeInterval = 10,
                           line: Int = #line, asyncTasks: [(XCTestExpectation) -> Void]) {
        if sslOption != SSLOption.httpsOnly {
            self.useSSL = false
            if socketTypeOption != SocketTypeOption.unix {

Function send has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public func send<T : Encodable>(jsonp: T, callbackParameter: String = "callback") throws -> RouterResponse {
        guard !state.invokedEnd else {
            Log.warning("RouterResponse send(jsonp:) invoked after end() for \(self.request.urlURL)")
            return self
        }

Function getFilePath has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        func getFilePath(from request: RouterRequest) -> String? {
            var filePath = servingFilesPath
            guard let requestPath = request.parsedURLPath.path else {
                return nil
            }

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Array) typed middleware request")
            self.handleMiddleware(T.self, request: request, response: response) { typeSafeMiddleware in
                guard let typeSafeMiddleware = typeSafeMiddleware else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Array) with identifier typed middleware request")
            self.handleMiddleware(T.self, request: request, response: response) { typeSafeMiddleware in
                guard let typeSafeMiddleware = typeSafeMiddleware else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        get(route) { request, response, next in
            Log.verbose("Received GET(Single) typed middleware request")
            self.handleMiddleware(T.self, request: request, response: response) { typeSafeMiddleware in
                guard let typeSafeMiddleware = typeSafeMiddleware else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        delete(route) { request, response, next in
            Log.verbose("Received DELETE (plural with middleware) type-safe request")
            self.handleMiddleware(T.self, request: request, response: response) { typeSafeMiddleware in
                guard let typeSafeMiddleware = typeSafeMiddleware else {
                    return next()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        delete(appendId(path: route)) { request, response, next in
            Log.verbose("Received DELETE (singular) type-safe request")
            guard let identifier = CodableHelpers.parseIdOrSetResponseStatus(Id.self, from: request, response: response) else {
                next()
                return

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        get(appendId(path: route)) { request, response, next in
            Log.verbose("Received GET (singular with identifier) type-safe request")
            guard let identifier = CodableHelpers.parseIdOrSetResponseStatus(Id.self, from: request, response: response) else {
                next()
                return

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        let stringTuple: [(String, User)] = [("1", User(id: 1, name: "Andy")), ("2", User(id: 2, name: "Dave")), ("3", User(id: 3, name: "Ian"))]

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        let intTuple: [(Int, User)] = [(1, User(id: 1, name: "Andy")), (2, User(id: 2, name: "Dave")), (3, User(id: 3, name: "Ian"))]

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        let intTuple: [(Int, User)] = [(1, User(id: 1, name: "Andy")), (2, User(id: 2, name: "Dave")), (3, User(id: 3, name: "Ian"))]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    struct CodableDate: Codable, Equatable {
        let date: Date
        
        init(date: Date) {
            self.date = date

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static var allTests: [(String, (TestSubrouter) -> () throws -> Void)] {
        return [
            ("testSimpleSub", testSimpleSub),
            ("testExternSub", testExternSub),
            ("testSubSubs", testSubSubs),

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    struct CodableDate: Codable, Equatable {
        let date: Date
        init(date: Date) {
            self.date = date
        }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    struct Conflict: Codable, Equatable {
        let field: String

        init(on field: String) {
            self.field = field

• Read up
  Read up