Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star

Showing 47,251 of 47,256 total issues

The parameter $submit_button_caption is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if (!$this->isNew() && $this->getVar('block_type') != 'C') {
            $this->hideFieldFromForm('content');
            $this->hideFieldFromForm('c_type');
        }
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/onupdate.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $_adFormatsList is not named in camelCase.
Open

class SystemAdsenseHandler extends icms_ipf_Handler {
    public $adFormats = array();
    private $_adFormatsList = array();
    private $_objects = FALSE;
Severity: Minor
Found in htdocs/modules/system/admin/adsense/class/adsense.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $form_caption is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if ($this->getType(0)=='addon') {
            $this->doHideFieldFromForm('sat_code');
            $this->doHideFieldFromForm('sat_onfinish');
        } else {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $form_name is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if (!$this->isNew() && $this->getVar('block_type') != 'C') {
            $this->hideFieldFromForm('content');
            $this->hideFieldFromForm('c_type');
        }
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $item_id is not named in camelCase.
Open

    function protector_notify_base($mydirname, $category, $item_id) {
        include_once __DIR__ . '/include/common_functions.php';

        $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/notification.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $form_name is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if ($this->getType(0)=='addon') {
            $this->doHideFieldFromForm('sat_code');
            $this->doHideFieldFromForm('sat_onfinish');
        } else {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The class protector_spamcheck_overrun_message is not named in CamelCase.
Open

class protector_spamcheck_overrun_message extends ProtectorFilterAbstract {

    function execute() {
        // header( 'Location: http://google.com/' ) ; // redirect somewhere
        echo 'Your post looks like SPAM'; // write any message as you like
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/filters_byconfig/spamcheck_overrun_message.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The parameter $module_obj is not named in camelCase.
Open

    function protector_message_append_onuninstall(&$module_obj, &$log) {
        if (is_array(@$GLOBALS['ret'])) {
            foreach ($GLOBALS['ret'] as $message) {
                $log->add(strip_tags($message));
            }
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/onuninstall.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct(&$db) {
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/onuninstall.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct(&$db) {
Severity: Minor
Found in htdocs/modules/system/admin/adsense/class/adsense.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $xoops_root_path is not named in camelCase.
Open

function get_writeoks_from_protector($xoops_root_path, $mytrustdirname) {
    return array (
        dirname(__DIR__) . '/configs'
    );
}
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/include/install_extramodcheck.inc.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/include/postcheck_functions.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $module_obj is not named in camelCase.
Open

    function protector_message_append_onupdate(&$module_obj, &$log) {
        if (is_array(@$GLOBALS['msgs'])) {
            foreach ($GLOBALS['msgs'] as $message) {
                $log->add(strip_tags($message));
            }
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/onupdate.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db =& icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modulesadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $_objects is not named in camelCase.
Open

class SystemAdsenseHandler extends icms_ipf_Handler {
    public $adFormats = array();
    private $_adFormatsList = array();
    private $_objects = FALSE;
Severity: Minor
Found in htdocs/modules/system/admin/adsense/class/adsense.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The class protector_precommon_badip_message is not named in CamelCase.
Open

class protector_precommon_badip_message extends ProtectorFilterAbstract {

    function execute() {
        echo _MD_PROTECTOR_YOUAREBADIP;
        $protector = &Protector::getInstance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/filters_enabled/precommon_badip_message.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $_use_virtual_config is not named in camelCase.
Open

class SystemAutotasksHandler extends icms_ipf_Handler {

    private $_use_virtual_config = FALSE;
    private $_virtual_config = array();
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $submit_button_caption is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if ($this->getType(0)=='addon') {
            $this->doHideFieldFromForm('sat_code');
            $this->doHideFieldFromForm('sat_onfinish');
        } else {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Severity
Category
Status
Source
Language