Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star

Showing 47,251 of 47,256 total issues

The parameter $cancel_js_action is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if ($this->getType(0)=='addon') {
            $this->doHideFieldFromForm('sat_code');
            $this->doHideFieldFromForm('sat_onfinish');
        } else {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/oninstall.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct($db) {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

        $db = icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modules/protector/trust_path/modules/protector/notification.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    $db =& icms_db_Factory::instance();
Severity: Minor
Found in htdocs/install/modulesadmin.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $groups[$i]->getVar('groupid');
Severity: Minor
Found in htdocs/modules/system/admin/groups/groups.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $form_caption is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if (!$this->isNew() && $this->getVar('block_type') != 'C') {
            $this->hideFieldFromForm('content');
            $this->hideFieldFromForm('c_type');
        }
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $block_positions is not named in camelCase.
Open

class SystemBlocksadminHandler extends icms_view_block_Handler {
    private $block_positions;
    private $modules_name;

    public function __construct(&$db) {
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $form_action is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if ($this->getType(0)=='addon') {
            $this->doHideFieldFromForm('sat_code');
            $this->doHideFieldFromForm('sat_onfinish');
        } else {
Severity: Minor
Found in htdocs/modules/system/admin/autotasks/class/autotasks.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $modules_name is not named in camelCase.
Open

class SystemBlocksadminHandler extends icms_view_block_Handler {
    private $block_positions;
    private $modules_name;

    public function __construct(&$db) {
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct($db) {
Severity: Minor
Found in htdocs/modules/system/admin/customtag/class/customtag.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    $id = (!is_null($imgcat_id) ? $imgcat_id : 0);
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $sc. Configured minimum length is 3.
Open

    $sc = 0;
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $fp. Configured minimum length is 3.
Open

                    $fp = @fopen($uploader->getSavedDestination(), 'rb');
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $sc. Configured minimum length is 3.
Open

        $sc = 0;
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_listimg($imgcat_id, $start = 0) {
    global $icmsTpl, $target, $type, $query, $limit;

    if (!is_object(icms::$user)) {
        $groups = array(ICMS_GROUP_ANONYMOUS);
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $image_id is not named in camelCase.
Open

function imanager_delfileok($image_id, $redir = NULL) {
    global $target, $type;
    if (!icms::$security->check()) {
        redirect_header('browser.php?op=list&target=' . $target . '&type=' . $type, 3, implode('<br />', icms::$security->getErrors()));
    }
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $imgcat_id is not named in camelCase.
Open

function imanager_index($imgcat_id = NULL) {
    global $icmsTpl, $icmsConfig, $target, $type, $limit;

    if (!is_object(icms::$user)) {
        $groups = array(ICMS_GROUP_ANONYMOUS);
Severity: Minor
Found in htdocs/modules/system/admin/images/browser.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $cancel_js_action is not named in camelCase.
Open

    public function getForm($form_caption, $form_name, $form_action = FALSE, $submit_button_caption = _CO_ICMS_SUBMIT, $cancel_js_action = FALSE, $captcha = FALSE) {
        if (!$this->isNew() && $this->getVar('block_type') != 'C') {
            $this->hideFieldFromForm('content');
            $this->hideFieldFromForm('c_type');
        }
Severity: Minor
Found in htdocs/modules/system/admin/blocksadmin/class/blocksadmin.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $_objects is not named in camelCase.
Open

class SystemCustomtagHandler extends icms_ipf_Handler {
    private $_objects = FALSE;

    /**
     * Constructor
Severity: Minor
Found in htdocs/modules/system/admin/customtag/class/customtag.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Severity
Category
Status
Source
Language