Kuangcp/JavaBase

View on GitHub

Showing 360 of 360 total issues

Method paintComponent has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void paintComponent(Graphics g) {
        int offset = 4;
        int r = 5;
        int chessR = 20;
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/gomoku/ChessBoard.java - About 1 hr to fix

    Method main has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public static void main(String[] a) {
        final CountDownLatch firstLatch = new CountDownLatch(1);
        final CountDownLatch secondLatch = new CountDownLatch(1);
        // 使用不可变对象
        final BuildFactory.Builder builder = new BuildFactory.Builder();

      Method keyPressed has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public void keyPressed(KeyEvent e) {
              //加了if条件后 实现了墙的限制(如果是游戏中的道具,该怎么办)
              if (e.getKeyCode() == KeyEvent.VK_A) {
                  hero.setDirect(2);
                  if ((hero.getX() - 10) > 0)
      Severity: Minor
      Found in gui/src/main/java/com/github/kuangcp/tank/v1/MainPanelV1.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method keyPressed has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public void keyPressed(KeyEvent e) {
              //加了if条件后 实现了墙的限制(如果是游戏中的道具,该怎么办)
              if (e.getKeyCode() == KeyEvent.VK_A) {
                  hero.setDirect(2);
                  if (PlayStageMgr.instance.willInBorder(hero))
      Severity: Minor
      Found in gui/src/main/java/com/github/kuangcp/tank/v2/MainPanelV2.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method insertWheel has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private boolean insertWheel(String id, Duration delay) {
              long days = delay.toDays();
              if (days > 30) {
                  log.warn("out of timeWheel max delay bound");
                  return false;

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method expCalculate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public static BigDecimal expCalculate(Expression expression) {
              List<ExpressionWord> postfix = getPostfix(expression);  //获取表达式的后缀表达式
              Stack<BigDecimal> result = new Stack<>();  //操作数栈
              if (postfix != null && postfix.size() > 0) {
                  for (int i = 0; i < postfix.size(); i++) {

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method consumerScheduler has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static void consumerScheduler() throws InterruptedException {
              Thread producer = new Thread(() -> {
                  AtomicInteger count = new AtomicInteger();
                  while (true) {
                      try {
      Severity: Minor
      Found in concurrency/src/main/java/thread/InterruptBizDemo.java - About 1 hr to fix

        Method sendCommand has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static void sendCommand() {
            Producer<String, String> producer = null;
            HashSet<ProductStatisticSpan> spans = new HashSet<>();
            spans.add(ProductStatisticSpan.MONTH);
        
        
        Severity: Minor
        Found in kafka/src/main/java/com/github/kuangcp/hi/ProducerDemo.java - About 1 hr to fix

          Method intercept has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
              public Object intercept(Invocation invocation) throws Throwable {
                  MetaObject metaObject;
                  MappedStatement mappedStatement;
                  Object target = invocation.getTarget();

            Method action has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private void action() {
                    if (state == PersonState.FREEZE) {
                        return;
                    }
            
            

              Method actionPerformed has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @Override
                  public void actionPerformed(ActionEvent ae) {
                      if (ae.getActionCommand().equals(ButtonCommand.START)) {
                          this.startNewStage();
                      }

                Method finalShotAction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void finalShotAction() {
                        //判断坦克方向来 初始化子弹的起始发射位置
                        final long nowMs = System.currentTimeMillis();
                        if (lastShotMs != 0 && nowMs - lastShotMs < shotCDMs) {
                            return;
                Severity: Minor
                Found in gui/src/main/java/com/github/kuangcp/tank/domain/EnemyTank.java - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    private OrderDTO convert(Order order, Map<Long, Customer> userMap) {
                      Customer customer = userMap.get(order.getUserId());
                      String username = getName(customer);
                      return OrderDTO.builder()
                          .num(order.getNum())
                  mybatis/src/main/java/com/github/kuangcp/simple/order/service/impl/OrderServiceImpl.java on lines 65..81

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    private OrderDTO convert(Order order) {
                      Customer customer = customerDao.selectById(order.getUserId());
                  
                      String username = getName(customer);
                      return OrderDTO.builder()
                  mybatis/src/main/java/com/github/kuangcp/simple/order/service/impl/OrderServiceImpl.java on lines 47..63

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Consider simplifying this complex logical expression.
                  Open

                                          if ((you.getX() - 10 <= me.getX() - 10 &&
                                                  you.getX() + 10 >= me.getX() - 10 &&
                                                  you.getY() - 15 <= me.getY() + 15 &&
                                                  you.getY() + 15 >= me.getY() + 15)
                                                  ||
                  Severity: Critical
                  Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix

                    Consider simplifying this complex logical expression.
                    Open

                                            if ((you.getX() - 15 <= me.getX() - 10 &&
                                                    you.getX() + 15 >= me.getX() - 10 &&
                                                    you.getY() - 10 <= me.getY() - 15 &&
                                                    you.getY() + 10 >= me.getY() - 15)
                                                    ||
                    Severity: Critical
                    Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                                              if ((you.getX() - 10 <= me.getX() + 15 &&
                                                      you.getX() + 10 >= me.getX() + 15 &&
                                                      you.getY() - 15 <= me.getY() - 10 &&
                                                      you.getY() + 15 >= me.getY() - 10)
                                                      ||
                      Severity: Critical
                      Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix

                        Consider simplifying this complex logical expression.
                        Open

                                                if ((you.getX() - 15 <= me.getX() - 10 &&
                                                        you.getX() + 15 >= me.getX() - 10 &&
                                                        you.getY() - 10 <= me.getY() + 15 &&
                                                        you.getY() + 10 >= me.getY() + 15)
                                                        ||
                        Severity: Critical
                        Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix

                          Consider simplifying this complex logical expression.
                          Open

                                                  if ((you.getX() - 10 <= me.getX() - 15 &&
                                                          you.getX() + 10 >= me.getX() - 15 &&
                                                          you.getY() - 15 <= me.getY() - 10 &&
                                                          you.getY() + 15 >= me.getY() - 10)
                                                          ||
                          Severity: Critical
                          Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix

                            Consider simplifying this complex logical expression.
                            Open

                                                    if ((you.getX() - 10 <= me.getX() + 15 &&
                                                            you.getX() + 10 >= me.getX() + 15 &&
                                                            you.getY() - 15 <= me.getY() - 10 &&
                                                            you.getY() + 15 >= me.getY() - 10)
                                                            ||
                            Severity: Critical
                            Found in gui/src/main/java/com/github/kuangcp/tank/util/TankTool.java - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language