Sign upLogin

RAR1741/RA18_RobotCode

View on GitHub
Star

Showing 108 of 130 total issues

Manipulation has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Manipulation implements Loggable, Configurable {
    private DoubleSolenoidWrapper tilt;
    private TalonSrxWrapper first;
    private TalonSrxWrapper second;
    private TalonSrxWrapper secondFollower;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Manipulation.java - About 4 hrs to fix

File Robot.java has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.redalert1741.powerup;
 
import edu.wpi.cscore.UsbCamera;
import edu.wpi.first.wpilibj.CameraServer;
import edu.wpi.first.wpilibj.DigitalInput;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java - About 3 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Manipulation;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftResetPosMove.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftMove.java on lines 1..37

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Manipulation;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftMove.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftResetPosMove.java on lines 1..37

Method autonomousInit has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void autonomousInit() {
        startLogging(data, "auto");
        reloadConfig();
 
 
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Manipulation;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationBrakeMove.java and 3 other locations - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringGrabberMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java on lines 1..35

Similar blocks of code found in 4 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Manipulation;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java and 3 other locations - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationBrakeMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringGrabberMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java on lines 1..35

Similar blocks of code found in 4 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Scoring;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java and 3 other locations - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationBrakeMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringGrabberMove.java on lines 1..35

Similar blocks of code found in 4 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.Scoring;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/ScoringGrabberMove.java and 3 other locations - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/ManipulationBrakeMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java on lines 1..35
src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java on lines 1..35

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.TankDrive;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveRampRateMove.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/TankDriveBrakeMove.java on lines 1..31

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.powerup.auto.move;
 
import java.util.Map;
 
import org.redalert1741.powerup.TankDrive;
Severity: Major
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveBrakeMove.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/auto/move/TankDriveRampRateMove.java on lines 1..31

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        case 1:
            if(sw == MatchData.OwnedSide.LEFT) {
                autoChoice = "min-auto.json";
            } else if(sc == MatchData.OwnedSide.LEFT) {
                autoChoice = "left_scale.json";
Severity: Major
Found in src/main/java/org/redalert1741/powerup/Robot.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/Robot.java on lines 176..184

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        case 3:
            if(sw == MatchData.OwnedSide.RIGHT) {
                autoChoice = "min-auto.json";
            } else if(sc == MatchData.OwnedSide.RIGHT) {
                autoChoice = "right_scale.json";
Severity: Major
Found in src/main/java/org/redalert1741/powerup/Robot.java and 1 other location - About 1 hr to fix
src/main/java/org/redalert1741/powerup/Robot.java on lines 160..168

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.robotbase.wrapper;
 
import org.redalert1741.robotbase.logging.DataLogger;
import org.redalert1741.robotbase.logging.Loggable;
 
 
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/wrapper/SolenoidWrapper.java and 1 other location - About 55 mins to fix
src/main/java/org/redalert1741/robotbase/wrapper/DoubleSolenoidWrapper.java on lines 1..24

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.robotbase.wrapper;
 
import edu.wpi.first.wpilibj.DoubleSolenoid.Value;
 
import org.redalert1741.robotbase.logging.DataLogger;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/wrapper/DoubleSolenoidWrapper.java and 1 other location - About 55 mins to fix
src/main/java/org/redalert1741/robotbase/wrapper/SolenoidWrapper.java on lines 1..22

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(Math.abs(operator.getY(Hand.kRight))>0.1) {
            manip.setSecondStageHeight(manip.getSecondStageHeight()-(operator.getY(Hand.kRight)*8));
        }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java and 1 other location - About 50 mins to fix
src/main/java/org/redalert1741/powerup/Robot.java on lines 268..270

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(Math.abs(operator.getY(Hand.kLeft))>0.1) {
            manip.setFirstStageHeight(manip.getFirstStageHeight()-(operator.getY(Hand.kLeft)*8));
        }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java and 1 other location - About 50 mins to fix
src/main/java/org/redalert1741/powerup/Robot.java on lines 272..274

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void setFirstStage(double input) {
        if(!brake.get()) {
            first.set(ControlMode.PercentOutput, input);
        } else {
            first.set(ControlMode.PercentOutput, 0);
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Manipulation.java and 1 other location - About 45 mins to fix
src/main/java/org/redalert1741/powerup/Manipulation.java on lines 128..134

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void setFirstStagePos(int pos) {
        if(!brake.get()) {
            first.set(ControlMode.Position, pos);
        } else {
            first.set(ControlMode.PercentOutput, 0);
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Manipulation.java and 1 other location - About 45 mins to fix
src/main/java/org/redalert1741/powerup/Manipulation.java on lines 116..122

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.robotbase.auto.core;
 
public class MissingAutoMoveException extends RuntimeException {
    private static final long serialVersionUID = 1L;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/MissingAutoMoveException.java and 1 other location - About 35 mins to fix
src/main/java/org/redalert1741/robotbase/auto/core/MissingAutoEndException.java on lines 1..9
Severity
Category
Status
Source
Language