Sign upLogin

RAR1741/RA18_RobotCode

View on GitHub
Star

Showing 108 of 130 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package org.redalert1741.robotbase.auto.core;

public class MissingAutoMoveException extends RuntimeException {
    private static final long serialVersionUID = 1L;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/MissingAutoMoveException.java and 1 other location - About 35 mins to fix
src/main/java/org/redalert1741/robotbase/auto/core/MissingAutoEndException.java on lines 1..9

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method autonomousInit has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

    @Override
    public void autonomousInit() {
        startLogging(data, "auto");
        reloadConfig();
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void driveMotors(double left, double right) {
        left1.set(ControlMode.PercentOutput, left);
        right1.set(ControlMode.PercentOutput, right);
    }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/TankDrive.java and 1 other location - About 35 mins to fix
src/main/java/org/redalert1741/powerup/TankDrive.java on lines 83..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void driveMotorsPercentV(double left, double right){
        left1.set(ControlMode.PercentOutput, left);
        right1.set(ControlMode.PercentOutput, right);
    }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/TankDrive.java and 1 other location - About 35 mins to fix
src/main/java/org/redalert1741/powerup/TankDrive.java on lines 64..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Extra separation in import group before 'org.redalert1741.robotbase.wrapper.SolenoidWrapper'
Open

import org.redalert1741.robotbase.wrapper.SolenoidWrapper;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/TankDrive.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'openrio.powerup.MatchData'
Open

import openrio.powerup.MatchData;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.robotbase.auto.core.AutoMoveEnd'
Open

import org.redalert1741.robotbase.auto.core.AutoMoveEnd;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/end/EmptyEnd.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Parameter name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    public Autonomous(List<AutoMove> m) {
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/Autonomous.java by checkstyle

Checks that method parameter names conform to a specified pattern.By using accessModifiers property it is possibleto specify different formats for methods at different visibility levels.

To validate catch parameters please useCatchParameterName.

To validate lambda parameters please useLambdaParameterName.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 46 should be alone on a line.
Open

    public void stop() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.powerup.TankDrive'
Open

import org.redalert1741.powerup.TankDrive;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveBrakeMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 38 should be alone on a line.
Open

    public void stop() {/*doesn't need*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftResetPosMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.powerup.TankDrive'
Open

import org.redalert1741.powerup.TankDrive;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveRampRateMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'java.text.SimpleDateFormat'
Open

import java.text.SimpleDateFormat;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'openrio.powerup.MatchData' import. Should be before 'org.redalert1741.robotbase.wrapper.TalonSrxWrapper'.
Open

import openrio.powerup.MatchData;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'java.io.FileNotFoundException'
Open

import java.io.FileNotFoundException;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/JsonAutoFactory.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.robotbase.config.Config'
Open

import org.redalert1741.robotbase.config.Config;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/wrapper/TalonSrxWrapper.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 48 should be alone on a line.
Open

    public boolean isFinished() { return true; }
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/end/EmptyEnd.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 13 should be alone on a line.
Open

            } while(moves.get(i-1).isAsync());
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/Autonomous.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.powerup.Manipulation'
Open

import org.redalert1741.powerup.Manipulation;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.powerup.Manipulation'
Open

import org.redalert1741.powerup.Manipulation;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationLiftMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Severity
Category
Status
Source
Language