Sign upLogin

RAR1741/RA18_RobotCode

View on GitHub
Star

Showing 108 of 130 total issues

Wrong lexicographical order for 'openrio.powerup.MatchData.GameFeature' import. Should be before 'org.redalert1741.robotbase.wrapper.TalonSrxWrapper'.
Open

import openrio.powerup.MatchData.GameFeature;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 80 should be alone on a line.
Open

    public void setArgs(Map<String, String> args) { /* EmptyEnd has no args */ }
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/end/EmptyEnd.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 47 should be alone on a line.
Open

    public void start() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 34 should be alone on a line.
Open

    public void run() { /* no */ }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveBrakeMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'openrio.powerup.MatchData'
Open

import openrio.powerup.MatchData;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'openrio.powerup.MatchData' import. Should be before 'org.redalert1741.robotbase.wrapper.TalonSrxWrapper'.
Open

import openrio.powerup.MatchData;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/Robot.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 83 should be alone on a line.
Open

    public void setArgs(Map<String, String> args) { /* EmptyMove takes no args */ }
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/move/EmptyMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Only one statement per line allowed.
Open

        amef.put(name, a); return AutoFactory.class;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/AutoFactory.java by checkstyle

Checks that there is only one statement per line.

Rationale: It's very difficult to read multiple statements on one line.

In the Java programming language, statements are the fundamental unit ofexecution. All statements except blocks are terminated by a semicolon.Blocks are denoted by open and close curly braces.

OneStatementPerLineCheck checks the following types of statements:variable declaration statements, empty statements, import statements,assignment statements, expression statements, increment statements,object creation statements, 'for loop' statements, 'break' statements,'continue' statements, 'return' statements, resources statements (optional).

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.powerup.TankDrive'
Open

import org.redalert1741.powerup.TankDrive;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveArcadeMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 46 should be alone on a line.
Open

    public void stop() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationTiltMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 47 should be alone on a line.
Open

    public void start() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ManipulationBrakeMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 34 should be alone on a line.
Open

    public void run() { /* no */ }
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/TankDriveRampRateMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.robotbase.auto.core.AutoMoveMove'
Open

import org.redalert1741.robotbase.auto.core.AutoMoveMove;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/move/EmptyMove.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 70 should be alone on a line.
Open

    public void start() { /* EmptyEnd has no start initialization */ }
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/end/EmptyEnd.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

First sentence of Javadoc is missing an ending period.
Open

    /**
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/AutoFactory.java by checkstyle

Checks thatJavadoc summary sentence does not contain phrases that are not recommended to use.Summaries that contain only the {@inheritDoc} tag are skipped. Check alsoviolate Javadoc that does not contain first sentence.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 47 should be alone on a line.
Open

    public void start() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ScoringGrabberMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.robotbase.wrapper.SolenoidWrapper'
Open

import org.redalert1741.robotbase.wrapper.SolenoidWrapper;
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/TankDrive.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.redalert1741.robotbase.auto.core.AutoMoveEnd'
Open

import org.redalert1741.robotbase.auto.core.AutoMoveEnd;
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/end/EmptyEnd.java by checkstyle

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

'}' at column 46 should be alone on a line.
Open

    public void stop() {/*doesn't need init*/}
Severity: Minor
Found in src/main/java/org/redalert1741/powerup/auto/move/ScoringKickerMove.java by checkstyle

Checks the placement of right curly braces ('}') for code blocks.This check supports if-else, try-catch-finally blocks, while-loops, for-loops,method definitions, class definitions, constructor definitions,instance, static initialization blocks, annotation definitions and enum definitions.For right curly brace of expression blocks of arrays, lambdas and class instancesplease follow issue#5945.For right curly brace of enum constant please follow issue#7519.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

First sentence of Javadoc is missing an ending period.
Open

/**
Severity: Minor
Found in src/main/java/org/redalert1741/robotbase/auto/core/JsonAutoFactory.java by checkstyle

Checks thatJavadoc summary sentence does not contain phrases that are not recommended to use.Summaries that contain only the {@inheritDoc} tag are skipped. Check alsoviolate Javadoc that does not contain first sentence.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Severity
Category
Status
Source
Language