Sign upLogin

SUSE/saptune

View on GitHub
Star

Showing 68 of 96 total issues

Method App.RevertNote has 5 return statements (exceeds 4 allowed).
Open

func (app *App) RevertNote(noteID string, permanent bool) error {

    noteTemplate, err := app.GetNoteByID(noteID)
    if err != nil {
        // to revert an applied note even if the corresponding
Severity: Major
Found in app/app.go - About 35 mins to fix

    Method App.TuneSolution has 5 return statements (exceeds 4 allowed).
    Open

    func (app *App) TuneSolution(solName string) (removedExplicitNotes []string, err error) {
    removedExplicitNotes = make([]string, 0)
    sol, err := app.GetSolutionByName(solName)
    if err != nil {
        return
    Severity: Major
    Found in app/app.go - About 35 mins to fix

      Method App.VerifyNote has 5 return statements (exceeds 4 allowed).
      Open

      func (app *App) VerifyNote(noteID string) (conforming bool, comparisons map[string]note.FieldComparison, valApplyList []string, err error) {
    theNote, err := app.GetNoteByID(noteID)
    if err != nil {
        return
    }
      Severity: Major
      Found in app/app.go - About 35 mins to fix

        Function GetSolutionDefintion has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func GetSolutionDefintion(solsDir, extraDir, noteDir string) map[string]map[string]Solution {
    sols := make(map[string]map[string]Solution)
    sol := make(map[string]Solution)
    currentArch := ""
    arch := ""
        Severity: Minor
        Found in sap/solution/solution.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def main():

    # Check if FORCE is set.
    try:
        if os.environ['FORCE'] != '1':
        Severity: Minor
        Found in ospackage/usr/share/saptune/schemas/1.0/templates/build.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method INISettings.Optimise has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func (vend INISettings) Optimise() (Note, error) {
    blckOK := make(map[string][]string)
    scheds := ""
    next := false
        Severity: Minor
        Found in sap/note/ini.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getInfoTxt has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func getInfoTxt(action string, state bool) (string, string, bool, bool) {
    sinfo := ""

    active, err := system.SystemctlIsRunning(SaptuneService)
    if err != nil {
        Severity: Minor
        Found in actions/serviceacts.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function chkBlkTags has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

        func chkBlkTags(info, tagField string, secFields, actbdev []string) (bool, []string) {
    ret := false
    info = strings.TrimPrefix(info, "blk")
    tagExpr := fmt.Sprintf(".*%s.*", tagField)
    // vendor or model
        Severity: Minor
        Found in txtparser/tags.go - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language