Sign upLogin

Talentica/AndroidWithKotlin

View on GitHub
Star

Showing 83 of 83 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                } else {
                    view.displayError(context.getString(R.string.some_error_occured))
                    view.hideLoading()
                    view.destroy()
                }
Severity: Minor
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt and 1 other location - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoPresenter.kt on lines 136..140

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private fun setDaggerComponent(component: CameraActivityComponent) {
        this.component = component
        this.component?.inject(this)
    }
Severity: Minor
Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/camera/CameraActivity.kt and 1 other location - About 35 mins to fix
customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/landing/LandingActivity.kt on lines 85..88

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private fun setDaggerComponent(component: LandingActivityComponent) {
        this.component = component
        this.component?.inject(this)
    }
Severity: Minor
Found in customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/landing/LandingActivity.kt and 1 other location - About 35 mins to fix
customcamera/src/main/java/com/talentica/androidkotlin/customcamera/ui/camera/CameraActivity.kt on lines 44..47

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Query("select * from products where id = :productId")
    fun loadProduct(productId: Int): LiveData<ProductEntity?>?
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/dao/ProductDao.kt and 1 other location - About 35 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/dao/CommentDao.kt on lines 30..31

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Query("SELECT * FROM comments where productId = :productId")
    fun loadCommentsSync(productId: Int): List<CommentEntity?>?
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/dao/CommentDao.kt and 1 other location - About 35 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/dao/ProductDao.kt on lines 33..34

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        val notifBody = if (body.trim().isEmpty()) context.getString(R.string
                .default_noification_body) else body
Severity: Minor
Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt and 1 other location - About 35 mins to fix
o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt on lines 87..88

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Insert(onConflict = OnConflictStrategy.REPLACE)
    fun insertAll(products: List<ProductEntity>?)
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/dao/ProductDao.kt and 1 other location - About 35 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/dao/CommentDao.kt on lines 33..34

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        val notifTitle = if (title.trim().isEmpty()) context.getString(R.string
                .default_noification_title) else title
Severity: Minor
Found in o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt and 1 other location - About 35 mins to fix
o_notifications/src/main/java/com/talentica/androidkotlin/onotifications/notifications/NotificationPresenter.kt on lines 89..90

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Insert(onConflict = OnConflictStrategy.REPLACE)
    fun insertAll(products: List<CommentEntity>?)
Severity: Minor
Found in app/src/main/java/com/talentica/androidkotlin/db/dao/CommentDao.kt and 1 other location - About 35 mins to fix
app/src/main/java/com/talentica/androidkotlin/db/dao/ProductDao.kt on lines 30..31

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        private val repoName by lazy {
            itemView.findViewById<TextView>(R.id.tv_repo_name)
        }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt and 4 other locations - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 58..60
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 61..63
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 64..66
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 68..70

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        private val repoDesc by lazy {
            itemView.findViewById<TextView>(R.id.tv_repo_desc)
        }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt and 4 other locations - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 55..57
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 61..63
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 64..66
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 68..70

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        private val repoLayout by lazy {
            itemView.findViewById<RelativeLayout>(R.id.rl_repo_holder)
        }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt and 4 other locations - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 55..57
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 58..60
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 61..63
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 64..66

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        private val repoStars by lazy {
            itemView.findViewById<TextView>(R.id.tv_repo_stars)
        }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt and 4 other locations - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 55..57
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 58..60
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 64..66
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 68..70

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        private val repoLastUpdated by lazy {
            itemView.findViewById<TextView>(R.id.tv_last_updated)
        }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt and 4 other locations - About 35 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 55..57
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 58..60
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 61..63
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/RepoAdapter.kt on lines 68..70

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val progressBar: ProgressBar by lazy {
        findViewById<ProgressBar>(R.id.progress_bar)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 13..15
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 21..23
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 25..27
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 20..22

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val btnRetrofit: Button by lazy {
        findViewById<Button>(R.id.btn_load_retrofit)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 13..15
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 21..23
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 25..27
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 20..22

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val repoList: RecyclerView by lazy {
        findViewById<RecyclerView>(R.id.rv_repo_list)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 13..15
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 21..23
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 25..27
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 17..19

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val btnVolley: Button by lazy {
        findViewById<Button>(R.id.btn_load_volley)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 13..15
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 21..23
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 20..22

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val etUsername: EditText by lazy {
        findViewById<EditText>(R.id.et_github_username)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 21..23
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 25..27
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 20..22

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    val btnOkhttp: Button by lazy {
        findViewById<Button>(R.id.btn_load_okhttp)
    }
Severity: Major
Found in networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt and 5 other locations - About 30 mins to fix
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 13..15
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/MainActivity.kt on lines 25..27
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 17..19
networking/src/main/java/com/talentica/androidkotlin/networking/repoui/UserRepositories.kt on lines 20..22
Severity
Category
Status
Source
Language